From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5C62A0350; Tue, 30 Jun 2020 01:26:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F2B41BF5B; Tue, 30 Jun 2020 01:26:35 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 49B3E1BF46 for ; Tue, 30 Jun 2020 01:26:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 936275803F7; Mon, 29 Jun 2020 19:26:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 29 Jun 2020 19:26:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Yo3GGoU1Om2Q3EjYDYFaCl0L4vcz6ESowM3V1anpEuE=; b=RymLNQY5Lo0V55U7 Wm2aDlz9/t/qkh4MW/G3ppPQ8D1B9PpSV3daBE7UHN2DwiYGgsor35C1xxD/H0rx CuHrjabO40MUxAJZOr4rmDAcgtiFeG3EbULeRAtXgstLcosK8j81sv7NQfQk4aXS DU013jkyiCNaTJ6mf6qh1DQ5/GGidecHWJ9xQTbwCudYiqMVHkuwaUHqdMBsfjgr mPqw76VvtqxFIbzgzE/76kcUIuV0ByAKOuRKHEVJh1QmRQXn4OIM3ECgq02Vf59c C7yB++k1+P1Fr/mq2UQ3OVjsS12zALQDls8zvkrH70IUO7Ta64wyA7BCe0WLb3QS XfhDAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Yo3GGoU1Om2Q3EjYDYFaCl0L4vcz6ESowM3V1anpE uE=; b=o8C5+iGBf021Yldv0QOQb0mTxa/uQ9xXjYi9n3vBiwKePseNFC+ICZ7DY 3Kh1h9RW2XCoOqx0lZ61VdMkKcQp9C0JhCCAw1do7O0z7BnyCi+n3AEDwYdz9OIa LzSty7ekHBWhJIaqgqPvO0JcQvKslsExH8UpYYAnnVUYCfhjZ+GOl6EiCC8s56Z/ puB9Inyzr8SiQ0RFlVv11C39OPYJdIie/aUrgGYARBgtNpDYKVwV03s2Z3NToJbg bW+1Nxu1KMz0YAgQvC75wufX+U3NENOUjPWD9GjL6Nm2zoFqWyVjIDWoAKPcTui9 LrSub9Lb9RsZiNDmucBPDzsaoQoSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddttddgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 308733067411; Mon, 29 Jun 2020 19:26:30 -0400 (EDT) From: Thomas Monjalon To: Fady Bader Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com Date: Tue, 30 Jun 2020 01:26:29 +0200 Message-ID: <2273109.IVLB8IxS53@thomas> In-Reply-To: <20200622115528.22928-2-fady@mellanox.com> References: <'20200531124151.16848-2-fady@mellanox.com'> <20200622115528.22928-1-fady@mellanox.com> <20200622115528.22928-2-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/06/2020 13:55, Fady Bader: > Function versioning is not needed on Windows, also the function versioning > implementation is not supported by Windows. I think it was said that "not needed" is not right. Let's just say that it is not supported for now. > Function versioning was disabled on Windows. > > Signed-off-by: Fady Bader > --- > --- a/lib/librte_eal/include/rte_function_versioning.h > +++ b/lib/librte_eal/include/rte_function_versioning.h > +#ifdef RTE_EXEC_ENV_WINDOWS > +#undef RTE_BUILD_SHARED_LIB > +#endif This trick is a bit weird but works. A comment is missing to explain that function versioning is disabled but shared libraries are allowed for Windows.