From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E94A4A0A0C;
	Fri,  2 Jul 2021 12:20:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 77EB341353;
	Fri,  2 Jul 2021 12:20:51 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E72AE40686
 for <dev@dpdk.org>; Fri,  2 Jul 2021 12:20:50 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5D6437F519;
 Fri,  2 Jul 2021 13:20:50 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5D6437F519
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625221250;
 bh=4NxcuglrsPE/F2bxJRL4EYRYDTL6K76zcQYuG01PS9M=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=CuahquMGbXYBvObCUtAm5nIvFYVU9jThKh1uQq6SZSN2AvngVNxgDK6EFjh3O1XEh
 TEgATrQR2jbkAE4Ys1j5B+AeHf46VSSDJuR+2Zqt28Dh4dJOqO7NgnU69aSV7ajjQG
 qMFhCqxD5yaNB20i1wx9XxtwyBXsnybQlug8La5g=
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
 Ivan Malov <ivan.malov@oktetlabs.ru>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>,
 Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
References: <20210527082504.3495-1-ivan.malov@oktetlabs.ru>
 <97d647fc-011a-d99b-4cf6-c2d35350a8bc@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <22746461-398e-21a4-29e2-40ab72d94e5f@oktetlabs.ru>
Date: Fri, 2 Jul 2021 13:20:50 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <97d647fc-011a-d99b-4cf6-c2d35350a8bc@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: add support for
 testpmd-compliant flow rule dumping
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Aman,

On 6/14/21 3:42 PM, Singh, Aman Deep wrote:
> Hi Ivan,
> 
> As a suggestion, can we add a check for debug log_level in
> "rte_flow_snprint" itself.

I see the reason, but I think it a bad idea to put the check
inside the function. If calling function cares, it should do
the check.

> So we can avoid CPU time, in cases where we don't want these logs.

[snip]