From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A966A2EEB for ; Sun, 6 Oct 2019 20:06:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58D261D153; Sun, 6 Oct 2019 20:06:53 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id F02E21D150 for ; Sun, 6 Oct 2019 20:06:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 23EEC20C55; Sun, 6 Oct 2019 14:06:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 06 Oct 2019 14:06:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=8xBdTvOHxPgWlwgztA3eJSxI4gX7i0NIhLI8advuCy8=; b=CNItmQBzltHy 9Q3pnkQpKS/wNq+eFyhJuPhxTD5toxmK3h3Q8aIi7JXIyTA7346P9mHutRJtI4Yq ixlGbxbxCzl2zBAZvDGQfTb5skEYlJ6sggIla4I4zO8T+c8XdqJGt75ofy6gi/Gu SgAYrXVII+OA81T+K8bH6+XNIHHWWRc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=8xBdTvOHxPgWlwgztA3eJSxI4gX7i0NIhLI8advuC y8=; b=GBChScgqVbJq8dcMAXMeARPBUuZoaOWcTkszRriZqXEqTW5SHOrbAw4zU BRP5u/BzICSf3GTqfoeamUGOFiHtdw1qYwh3vm/QbpG0Weh4s7hXIluHptYuteFy 9pP96HXH3PraexDcTcUPKEfsQ7qiFWDhQXvBZ4K1dS8s7c5OYCwZ/ioLHo5vJ+DU asbEueOm73a49sCKblHRN1JJXqePq7QZIPtLXSYOEpI8dchSgsqz4oFCxUON71Hp dFxCM2RicCNIoAuwgF+Ql+in6qDxC7pjaxHtRgUDrD/YqSwaX4fWKRJjddX/MJvV Wy7qXMujoJhBogaaZF4RCnjqZUPYA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrheehgdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A867D6005A; Sun, 6 Oct 2019 14:06:49 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , Jerin Jacob Cc: Dharmik Thakkar , Akhil Goyal , Hemant Agrawal , anoobj@marvell.com, pathreya@marvell.com, Bruce Richardson , dpdk-dev , Honnappa Nagarahalli Date: Sun, 06 Oct 2019 20:06:46 +0200 Message-ID: <22790115.aVAZyMIHDd@xps> In-Reply-To: References: <20191003225732.13463-1-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/10/2019 17:28, Jerin Jacob: > On Fri, Oct 4, 2019 at 4:27 AM Dharmik Thakkar wrote: > > > > Add new meson.build file for crypto/armv8 > > > > Signed-off-by: Dharmik Thakkar > > --- > > drivers/crypto/armv8/meson.build | 25 +++++++++++++++++++++++++ > > drivers/crypto/meson.build | 6 +++--- > > meson_options.txt | 2 ++ > > 3 files changed, 30 insertions(+), 3 deletions(-) > > create mode 100644 drivers/crypto/armv8/meson.build > > > > > option('allow_invalid_socket_id', type: 'boolean', value: false, > > description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly') > > +option('armv8_crypto_dir', type: 'string', value: '', > > + description: 'path to the armv8_crypto library installation directory') You should not need such option if you provide a pkg-config file in your library. > It is not specific to this patch but it is connected to this patch. > > Three years back when Cavium contributed to this driver the situation > was different where only Cavium was contributing to DPDK and now we > have multiple vendors from > ARMv8 platform and ARM itself is contributing it. > > When it is submitted, I was not in favor of the external library. But > various reasons it happened to be the external library where 90% meat > in this library and shim PMD > the driver moved to DPDK. > > Now, I look back, It does not make sense to the external library. Reasons are > - It won't allow another ARMv8 player to contribute to this library as > Marvell owns this repo and there is no upstreaming path to this > library. This is a real issue and you are able to fix it. > - That made this library to not have 'any' change for the last three > year and everyone have there owned copy of this driver. In fact the > library was not compiling for last 2.5 years. > - AES-NI case it makes sense to have an external library as it is a > single vendor and it is not specific to DPDK. But in this, It is > another way around I don't see how it is different, except it is badly maintained. > - If it an external library, we might as well add the PMD code as well > there and that only 10% of the real stuff. > We are not able able to improve anything in this library due to this situation. > > Does anyone care about this PMD? If not, we might as well remove this > DPDK and every vendor can manage the external library and external > PMD(Situation won't change much) External PMD is bad. I think this library should not be specific to DPDK, so it would make sense as an external library. > Thoughts from ARM, other ARMv8 vendors or community?