From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DEBD91B702 for ; Tue, 30 Jan 2018 21:49:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7335D20D48; Tue, 30 Jan 2018 15:49:42 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 30 Jan 2018 15:49:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=poxDOc2F4yOonES1uSGYTeyfVS 2w8jdhPSF+ykFgRFE=; b=O1X9AM8qrNZHooJrFswiQrW+zsbi2SgvstEWttSD5e auk45fwv6tcZBJzXZAwwd3JOEcBUljW1Yz/G9I9mweAvuXK+jVRYzQ93ljmqRdGJ SKINCZuEImuGTVJcNEg7p9HwI3PEVprxYpHfORYXGvP0JOtAkeBNdDo8KTinCP75 E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=poxDOc 2F4yOonES1uSGYTeyfVS2w8jdhPSF+ykFgRFE=; b=qhfnFTRGYwMk2oVcBydv6j ONQ/JZYk3lLipoF+9VDL4QAdmzgW4T+WmYdb35rtfoCQQ18OAk8MDvviK49zmQdJ 8c8IXeY+sORyeS5XsIYiYRRggAV+XskIYoay0EPLKJk8hMxXkqsr0ck1BvcYQVea wjAsCFmvSEEFw2oTFtPP6wjE7iESoEgVfQ9FK1Ic2Nq6QO1Up5fz3H5HNHss8+Lg Ge2SBtzNkrNiU41BQVsYFBFdf90Io39SyI8eRVEVz5/w4OlWEXcUe/r2NsRoNPEn 2F1jHERb7rgdDCIxj0Bs8k9E4/bRSG5FaSFCxZTmnih1cbG8ziiLgZVAD/joJs0g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1DE9924640; Tue, 30 Jan 2018 15:49:42 -0500 (EST) From: Thomas Monjalon To: Yuanhan Liu , "Tan, Jianfeng" , Zhihong Wang Cc: dev@dpdk.org Date: Tue, 30 Jan 2018 21:48:54 +0100 Message-ID: <2279300.srBI6OA966@xps> In-Reply-To: <20180126130455.GC29540@yliu-mob> References: <1516388570-42634-1-git-send-email-zhihong.wang@intel.com> <6637c690-e659-ef2f-a077-d2a8e5f8b120@intel.com> <20180126130455.GC29540@yliu-mob> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 20:49:44 -0000 Hi, There is a compilation error on Ubuntu 12.04 / kernel 3.8. VIRTIO_F_ANY_LAYOUT is undeclared. 26/01/2018 14:04, Yuanhan Liu: > On Sat, Jan 20, 2018 at 01:54:52AM +0800, Tan, Jianfeng wrote: > > > > > > On 1/19/2018 10:42 PM, Yuanhan Liu wrote: > > >On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote: > > >>The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary > > >>descriptor layouts. The vhost-user lib already supports it, but the > > >>feature declaration is missing. This patch fixes the mismatch. > > >I remembered there was a long discussion one year ago, that we can't > > >blindly set this feature, as this flag is reserved (thus should not > > >be set) for virtio 1.0. > > > > We might need to read that old thread again. But as you said, this flag is > > reserved for 1.0, but not used for other purpose yet. So that the feature is > > negotiated does not affect anything, no? > > > > > > > >We should set it when v1.0 is not enabled. > > > > But in fact, vhost kernel reports supported feature bits consisting of > > ANY_LAYOUT and VERSION_1. > > Yes, I was aware of that, and that was also one my points before. > > I now also release that it's a must from migration from vhost-net to > vhost-user. Thus, I'd like to merge it this time. So > > Applied to dpdk-next-virtio.