From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 7C73DC3E2 for ; Mon, 13 Apr 2015 14:55:24 +0200 (CEST) Received: by wgyo15 with SMTP id o15so79765989wgy.2 for ; Mon, 13 Apr 2015 05:55:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=WddBO9PLzbYpSqrMa7M5iHVCf+nUzJ9Fon/tDYfwxwE=; b=Oqd7DKjQaYggUlGJmkcXpSJvI/zvbugpRc65A9o/oN681f0gujhRfgnjXlZ0GYNz3t 99rBp6Y+0/e90a+HUAZLTYRIg8f9uxLGW2oYlNHYiZS7tYVZ6Bx+p5oIDXUK8lxqsU2D cZyEqejspC/bKpu1krAqbHKbQbfzl91Ndw2em5nh6N3NQixqLAoTWg6d47c9fAc/3igb 1+jB1kgNaAB7qTGYzPKsLsckiFbelkud9E3TAAC9TAGUyFmZmiH0cPS63U4eXK3OnaeR RVE708/6pvvCIk+YIPQb6Yu7Sdg2DitPYX9kQIEuSmCIVPEihqdvlpHMBYVyUPwe1Bxk xW5A== X-Gm-Message-State: ALoCoQnn++iSNz9LtmmGvAfwuk6kHEeCdeRdySvevvyFb4T7REN6s1TMILNrHuKkmsowsCcxsiK7 X-Received: by 10.194.121.38 with SMTP id lh6mr6651955wjb.2.1428929724327; Mon, 13 Apr 2015 05:55:24 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id o5sm16671700wia.0.2015.04.13.05.55.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2015 05:55:23 -0700 (PDT) From: Thomas Monjalon To: Raz Amir Date: Mon, 13 Apr 2015 14:54:42 +0200 Message-ID: <2279951.2s8DnS74SK@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1428927569-98070-1-git-send-email-razamir22@gmail.com> References: <1428450303-97954-1-git-send-email-razamir22@gmail.com> <1428927569-98070-1-git-send-email-razamir22@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] Restore support for virtio on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 12:55:24 -0000 Please provide more information in the commit message. We need to know what was the problem (crash) in the git history. Then when doing git blame, we'll have the full explanation. 2015-04-13 15:19, Raz Amir: > Fixes: 8a312224bcde ("eal/bsd: fix fd leak") > > Signed-off-by: Raz Amir > --- > lib/librte_eal/bsdapp/eal/eal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c > index 871d5f4..e20f915 100644 > --- a/lib/librte_eal/bsdapp/eal/eal.c > +++ b/lib/librte_eal/bsdapp/eal/eal.c > @@ -426,7 +426,7 @@ rte_eal_iopl_init(void) > fd = open("/dev/io", O_RDWR); > if (fd < 0) > return -1; > - close(fd); > + /* keep fd open for iopl */ Yes we need a comment but "for iopl" is not descriptive and not very accurate as iopl is a Linux mechanism. > return 0; > } Thanks