From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id E2D45FA6F for ; Thu, 9 Feb 2017 17:26:10 +0100 (CET) Received: by mail-wr0-f180.google.com with SMTP id o16so87410957wra.1 for ; Thu, 09 Feb 2017 08:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=1m7EUitt5UB/kNoO8LMGJ+f8+21oKZdAX1dEVYweAQ8=; b=mHeRsnfLC0a6fjM+kcM3EBncevVUtiskOWKuUiPX+YN22A1XlN4i5tW5nm+KQJbWjv iZWifqy+g4g3Faii4f/oXYvgqPdMXtyZXZ2lujzVITmwbNmVZ52zxWN5/K11m50D9xC+ XNtTwCvIYv2f9v5b/VQ7YSgzOPpaDOt+wKPbZRB6rjBsWy2TqwsLC3C9Gii5RvcX3o6B wQhvUTtbpmi1CpUhmfAw1QLMU0tJ5pR8FFyIchbbZ94JViBZx3VtB+j/BwCYVQaTIKt7 Gsar1kmrw4w9C1asr+rQEQ0iW73aEZ8vtLHwsGdgfFY0tFOHRXRsbk/yxKR3Ukc8ElaM Biaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=1m7EUitt5UB/kNoO8LMGJ+f8+21oKZdAX1dEVYweAQ8=; b=gqgTHStdsKPRkZVRI0LBAtO+hcND2mHep840T+tU9ZYp0yqekL7Nwjtw5gsKh6G9C2 YHIU/bBTh0W/sJlvMYDA+tcO+KvtdpdEn9KtumeO3CNaQCwSYVAJk0UqqNmJA1FkJNV0 +fYW53tN3oiLtYsMYDNqV43GsBpGMZXMliOkLKscoqyHwlTwMUrPwO0kB+m01xGZrEgp B5b4//nx3IwIKsNvRftLx7KMDK2FDxR94Vz4pgKO47WDUTWXEVw+ZhS/jL2N+k+4tirM OZn5+XjHFh1msGvnlAfyASaaOLMw0JRfZMdFryQrf+o5iN9HM+gNOo8bKDMOrJmVWN9L GRyw== X-Gm-Message-State: AMke39mHHYp+vjr90SC1tbcwhwvYznBiWn/KZwZS/XrcP9aGjJ4Tgpoat2QXzYX33BYzsc8k X-Received: by 10.223.139.93 with SMTP id v29mr3967875wra.70.1486657570465; Thu, 09 Feb 2017 08:26:10 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d29sm9626186wmi.19.2017.02.09.08.26.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2017 08:26:09 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org Date: Thu, 09 Feb 2017 17:26:09 +0100 Message-ID: <2281378.PUPUsLso98@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170208145640.66deb7f0@xeon-e3> References: <20170208145640.66deb7f0@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Kill off PCI dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 16:26:11 -0000 2017-02-08 14:56, Stephen Hemminger: > I am trying to make DPDK more agnostic about bus type. The existing API still > has hardwired into that ethernet devices are either PCI or not PCI (ie pci_dev == NULL). > Jan, Jerin, and Shreyansh started the process but it hasn't gone far enough. > > It would make more sense if the existing generic device was used everywhere > including rte_ethdev, rte_ethdev_info, etc. Yes > The ABI breakage is not catastrophic. Just change pci_dev to a device pointer. > One option would be to use NEXT_ABI and/or two different calls and data structures. > Messy but compatible. Something like > rte_dev_info_get returns rte_dev_info but is marked deprecated > rte_device_info_get returns rte_device_info Or we can break the ABI to avoid messy code. > One fallout is that the existing testpmd code makes lots of assumptions that > is working with a PCI device. Things like ability to get/set PCI registers. > I suspect this is already broken if one tries to run it on a virtual device like TAP. > > Can we just turn off that functionality? Which functionality exactly? > Also KNI has more dependencies that ethernet devices are PCI.