From: Thomas Monjalon <thomas@monjalon.net>
To: Vamsi Krishna Attunuru <vattunuru@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] mempool/octeontx2: fix npa pool range errors
Date: Sun, 07 Jul 2019 19:24:26 +0200 [thread overview]
Message-ID: <2282525.4GGbi3Xbp4@xps> (raw)
In-Reply-To: <BYAPR18MB2424EA66267771E1EFF8634FC8F70@BYAPR18MB2424.namprd18.prod.outlook.com>
07/07/2019 16:21, Jerin Jacob Kollanukkaran:
>
> > -----Original Message-----
> > From: vattunuru@marvell.com <vattunuru@marvell.com>
> > Sent: Friday, July 5, 2019 4:04 PM
> > To: dev@dpdk.org
> > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> > Vamsi Krishna Attunuru <vattunuru@marvell.com>
> > Subject: [PATCH v1 1/1] mempool/octeontx2: fix npa pool range errors
> >
> > From: Vamsi Attunuru <vattunuru@marvell.com>
> >
> > Patch fixes npa pool range errors observed while creating mempool.
> > During mempool creation, octeontx2 mempool driver populates pool range
> > fields before enqueueing the buffers. If any enqueue or dequeue operation
> > reaches npa hardware prior to the range field's HW context update, those ops
> > result in npa range errors. Patch adds a routine to read back HW context and
> > verify if range fields are updated or not.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
>
>
> 1) Please fix chek-git-log.sh
>
> $ ./devtools/check-git-log.sh
> Missing 'Fixes' tag:
> mempool/octeontx2: fix npa pool range errors
>
> 2) Please mention this issue happens when mempool objects are
> from different mempool in git commit log
One more comment, the title is supposed to say which behaviour
it is fixing, not the root cause.
next prev parent reply other threads:[~2019-07-07 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 10:33 vattunuru
2019-07-07 14:21 ` Jerin Jacob Kollanukkaran
2019-07-07 17:24 ` Thomas Monjalon [this message]
2019-07-08 4:47 ` [dpdk-dev] [PATCH v1 1/1] mempool/octeontx2: fix mempool creation failure vattunuru
2019-07-08 5:25 ` Jerin Jacob Kollanukkaran
2019-07-08 9:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2282525.4GGbi3Xbp4@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).