From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 54BD61B427;
 Tue, 26 Jun 2018 11:54:50 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id CB9E321B0F;
 Tue, 26 Jun 2018 05:54:49 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Tue, 26 Jun 2018 05:54:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=2JM1ZlB0s7UHCns+ChbXdDanPJ
 lklMuLJsR3rVChM3w=; b=cSxRgJCoFwvwl0KYZ0snyDrpnxrgVerV2BA1A/uP6D
 3aJHSDAS19oXN1AX3U2RM7EQKOotrbEJ55OXrZ7pVXj/zhFfNGS9kGKvAjdPpPwJ
 5EMl+FiIETSqei05nZya2N4YOpNateR9M+W6/0XKLn7Tv/LHTtiga/B/qOG6FNW/
 Q=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=2JM1Zl
 B0s7UHCns+ChbXdDanPJlklMuLJsR3rVChM3w=; b=T4MhJG8hi0hVUWfePggZn2
 x5ujCZf7K23YDN9UGmVvJWDF4HEhyZcosvhm0vwaD9MlqcjfIDH3ARPRDQ80ddP1
 v4i46+XdA0X0s8CQA1P5SrX5q0uBVvxeOYylN3WYqdqsWp/PN04xVJw5bVP78at4
 hAX3yWUFc894tk72fZXGY0iYMPDX+EXTvQZgHR66H/NJluvDyUB21NTU0B2iP0hA
 V4YoJ6r33J/i4QLdBVKgjk3ZuL2GUnXs8EX3TtJ45pwOWoDZlH9ue6yUCMW/DJQM
 F+zKQSF/HPlzzESpIhPJ/E2UCoL4qCjov+xQAmdDGzawnhwek0vy/vWb2dTSmR3Q
 ==
X-ME-Proxy: <xmx:aQ0yW_NhDLzJ0teyLdP_8wNjzYBcJrycQQ3SYC3qT_kxR7UNco_hVg>
 <xmx:aQ0yW6L8kmtlYJvZYjtq6lj6htb_gGkUpCkBWL-G2rro_3lEQ-NimQ>
 <xmx:aQ0yWwFmwWXmibGBcAy1d_sQzkkXiuVzKHkngwjcnxvBwUWB7zKn6A>
 <xmx:aQ0yWyTSr-W1pSqys9Pt3VRW32pTX9qAsiA8Lz7tenmZiCUZDn3AzQ>
 <xmx:aQ0yW8G8cFGeb2hml2oGXS1z0k9dBfqnslNRpiKJJm63YUGo__0tiQ>
 <xmx:aQ0yWxZvbclHYBSdzm4JVgdm0JPc1Qb8lLvIBCBC4x_JrOBIGPi-VA>
X-ME-Sender: <xms:aQ0yWy4na3nOV96Lqt9iYWaC1BppxSY_xneaaXmCu-QWBIqqKaCPTw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 00F7910293;
 Tue, 26 Jun 2018 05:54:48 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: stable@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 stephen@networkplumber.org, pablo.de.lara.guarch@intel.com
Date: Tue, 26 Jun 2018 11:54:47 +0200
Message-ID: <22836779.FGhLq8pQDX@xps>
In-Reply-To: <07e4d536-edd6-292d-5adb-c05793731623@intel.com>
References: <20180619120855.78207-1-ferruh.yigit@intel.com>
 <07e4d536-edd6-292d-5adb-c05793731623@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix build with gcc 8.1
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 09:54:50 -0000

26/06/2018 11:02, Ferruh Yigit:
> --- a/kernel/linux/kni/ethtool/igb/igb_ethtool.c
> +++ b/kernel/linux/kni/ethtool/igb/igb_ethtool.c
> @@ -811,9 +811,10 @@ static void igb_get_drvinfo(struct net_device *netdev,
>  	strncpy(drvinfo->driver,  igb_driver_name, sizeof(drvinfo->driver) - 1);
>  	strncpy(drvinfo->version, igb_driver_version, sizeof(drvinfo->version) - 1);
>  -	strncpy(drvinfo->fw_version, adapter->fw_version,
> -		sizeof(drvinfo->fw_version) - 1);

There is a leading space before the minus of first line.