From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com
 [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 15A5B5A7B
 for <dev@dpdk.org>; Mon, 13 Jul 2015 00:02:05 +0200 (CEST)
Received: by widjy10 with SMTP id jy10so53687305wid.1
 for <dev@dpdk.org>; Sun, 12 Jul 2015 15:02:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=MQifT5hFpDJsBwJTVYTfs0UonVx9ODMc0wjinlHX0+w=;
 b=KJoT3ho4iJk+faaC6xahVPjpCQkVsWkaBoFtoFR23J/41FA+ij4vBHcyB4kkLNK2fM
 NpIb/du+/4wIMeeuby+DIlY5A2MHxTQM+4vkf7m8D9BP7mG93IQXIljK1Af1U7jLenBN
 0+a+1XjPCeGTHcW37g0/QuQXph7dNuD6vd6AfeGpxMhSWlTKAPRBppwmJuHQ7ETN8FZL
 fGl3S0N5IckkT5uFjWrO5dO0HwXPYa3BDm/L0UYQBRaSbKS8d8H5bA9SIdK5FAWeEyLm
 qM9SS7bUGGmil7P27M36ugt0hcPhslcFUwLMUikSUeSow1N3TUKV+uo1yCQqPbOAxpr9
 H0GQ==
X-Gm-Message-State: ALoCoQnWcf4VE+Te0fD+h1Uo+o3On8PIIxiuCwZtV/Ko/Bc8vAhimEIejT5cOqzWF0MxWxveul6O
X-Received: by 10.180.83.72 with SMTP id o8mr16151931wiy.27.1436738524948;
 Sun, 12 Jul 2015 15:02:04 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id j7sm25469004wjz.11.2015.07.12.15.02.03
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 12 Jul 2015 15:02:04 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Mon, 13 Jul 2015 00:00:52 +0200
Message-ID: <2285145.Kg1Z1AH0fV@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1436573936-15956-4-git-send-email-pablo.de.lara.guarch@intel.com>
References: <1436571020-16252-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1436573936-15956-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1436573936-15956-4-git-send-email-pablo.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 3/7] hash: add new functionality to store
	data in hash table
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Jul 2015 22:02:05 -0000

Hi Pablo,
There is a remaining error below:

2015-07-11 01:18, Pablo de Lara:
> +int
> +rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **key=
s,
> +                     uint32_t num_keys, uint64_t *hit_mask, void *da=
ta[])
> +{
> +       RETURN_IF_TRUE(((h =3D=3D NULL) || (keys =3D=3D NULL) || (num=
_keys =3D=3D 0) ||
> +                       (num_keys > RTE_HASH_LOOKUP_BULK_MAX),
> +                       (hit_mask =3D=3D NULL)), -EINVAL);
>=20

lib/librte_hash/rte_cuckoo_hash.c: In function =E2=80=98rte_hash_lookup=
_bulk_data=E2=80=99:
lib/librte_hash/rte_cuckoo_hash.c:1073:41: error: left-hand operand of =
comma expression has no effect [-Werror=3Dunused-value]
    (num_keys > RTE_HASH_LOOKUP_BULK_MAX),
                                         ^

The comma should be ||
Will be fixed before when applying.