From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F1C5A0562; Wed, 14 Apr 2021 12:33:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86E39161976; Wed, 14 Apr 2021 12:33:12 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 3EBA7161975 for ; Wed, 14 Apr 2021 12:33:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 86EFD5803F6; Wed, 14 Apr 2021 06:33:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 14 Apr 2021 06:33:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= b1/goJKUsObFByh4/SlnQp83C/DhT1XxZc3NFtVNXZU=; b=mCFpoVjk6511m6fg ajvSvuDTtBpwaGE2AoxamFnNjidn92/PvVClyC+dOe3XcmSKg3LvIlNdjywo9uW0 9E3n5QULfrFn5Y8Q5oDKht0uibf+S2BK0XVaQhNy0Dy5LJRJ+KKqsap8ceADAPya 05806vVtBy4oXdn8xOguYkEJh0efe+d+Vdj1DX6tu2CrjI8qcvPjvKxAtu0BAYwA Za8fJ7eEs1tLQpTSPuEf98c4KbX5bUH0dpmjgoOXp5w2RcGIIUay1XI5VKWXvAY1 tI29ww9yAEM/BJkL8wn92a6kYwHjnNVB+npl2gEA6FIVUU3BJ3TsAotXMmv+cCad JGnljQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=b1/goJKUsObFByh4/SlnQp83C/DhT1XxZc3NFtVNX ZU=; b=vuxAfWKD2c8J61nK3CWkvu3K5rugGxOVslv70qdCYYhimaL5RvVUwWhKZ VCx7ztdXOV5yo3Q5VtXYaWpo+F7hY8bEoR5wj4m0dkxUOJBXrj8JXDKzmGqehndS gHz+4vfwHVs5lXW/0sa9mAhZkHUrQxqrhGFqlpBXHmUS/8JlUgQ97BlhL2ZNRgMI nn4I38g7cs82FyLp4JcTdvSt1glEtFWY5Qid+PCQA0Pheg8aKazSpWEDeW5DDUgB cU3mwR6QsWIoofaJ4p1yZvgKR+mD1wjaAO9mMg8/VhbQ6Qx73oMUreMjplQU/ogS weIU8pRPko2lpD6E2g2+JjWXSavnA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C32271080066; Wed, 14 Apr 2021 06:33:06 -0400 (EDT) From: Thomas Monjalon To: Haifei Luo Cc: dev@dpdk.org, orika@nvidia.com, viacheslavo@nvidia.com, rasland@nvidia.com, xuemingl@nvidia.com, haifeil@nvidia.com, ajit.khaparde@broadcom.com, Xiaoyun Li , Matan Azrad , Shahaf Shuler , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Ferruh Yigit , Andrew Rybchenko Date: Wed, 14 Apr 2021 12:33:05 +0200 Message-ID: <2287062.Ys29FK9Loc@thomas> In-Reply-To: <1618393890-205395-2-git-send-email-haifeil@nvidia.com> References: <1615277716-64404-1-git-send-email-haifeil@nvidia.com> <1618393890-205395-1-git-send-email-haifeil@nvidia.com> <1618393890-205395-2-git-send-email-haifeil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: dump single flow rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2021 11:51, Haifei Luo: > Previous implementations support dump all the flows. Add new arg > rte_flow in rte_flow_dev_dump to dump one flow. Rewording: The API supported dumping all the flow rules. A parameter is added to allow dumping a specific flow rule. > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -1837,13 +1837,16 @@ all flows with assistance of external tools. > > .. code-block:: console > > - testpmd> flow dump > + To dump all flows: > + testpmd> flow dump all > + and dump one flow: > + testpmd> flow dump rule Comments should not be in the code block. > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -3232,6 +3232,8 @@ enum rte_flow_conv_op { > * > * @param[in] port_id > * The port identifier of the Ethernet device. > + * @param[in] flow > + * The pointer of flow rule to dump. Dump all rules if NULL. Sorry for not making it explicit, when fixing "rte flow" I thought you would replace it also above in the existing function description. I think "The pointer of" is useless in general but I'm OK if you want to keep it. To Ferruh and Andrew: we could make the ethdev API description lighter and more pleasant to read.