From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 424365920 for ; Tue, 25 Nov 2014 10:12:59 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id y19so264091wgg.28 for ; Tue, 25 Nov 2014 01:23:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ahL4twwWU2Y0nQSRnMXyLqg+/vuqLF5+zboNMtnHCHI=; b=IemvH6tsfUA6TN9GA0Bi0jux8hrPjpnZFLJpJcH+XAK6/Arga4w+rPjZmBnFyG77N9 hNuv96rNwyYV3iifQ2w3Hx4kVLymBWNcXpXT5vw8ONq+DKSMm6VpnAl7Rns7Vcy6JHMr OwL7zzFzb+Q1+p6+Tek7z2vRnr9Y6IbemTEet3IPmIa76G5SvYbEgnfOw7cYJ1KLUfQF lhMYjYTTCYohSIJDY51a026qtxwAUEZuTtwjrHi28pnrONjVN4FzaaWYDj8Q3jsiGXT7 y8iLXw5jT5lr5su9mA31w45ht9k9rryGEJUYdLgz9F0sFWlVGrDxs88xK145vDNk2bSM cIxA== X-Gm-Message-State: ALoCoQl3mBLNrS5iCN/Ao8Khj9F+lH4EXkPh8PlwEzm9NSD0cFGLlaGtWSaZdzXSBsK94ib30Ckf X-Received: by 10.195.17.231 with SMTP id gh7mr42074375wjd.21.1416907430860; Tue, 25 Nov 2014 01:23:50 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dx8sm1994509wib.2.2014.11.25.01.23.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Nov 2014 01:23:49 -0800 (PST) From: Thomas Monjalon To: "Wu, Jingjing" Date: Tue, 25 Nov 2014 10:23:25 +0100 Message-ID: <2287389.NcjyIgEEcp@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8B550A3@SHSMSX104.ccr.corp.intel.com> References: <1414654006-7472-1-git-send-email-jingjing.wu@intel.com> <1836839.nqfgSfhOYr@xps13> <9BB6961774997848B5B42BEC655768F8B550A3@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 00/22] Support flow director programming on Fortville X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 09:12:59 -0000 2014-11-25 04:51, Wu, Jingjing: > > Now we move on this API and the old one must be removed. > > Converting ixgbe to this new API must be the top priority. > > It must be clear to everyone that no new Fortville feature will be accepted > > until a full clean-up of the old filtering API. > > If I understand correctly, what you mean is: > If the new patch is using new filter_ctrl API while the similar feature for > Igb and ixgbe are using the old filtering API, we need to clean-up the old filtering > API and promote them to new filtering APIs at first. > For example, if we want to enable ethertype filter on Fortville, we need to move > the igb/ixgbe's ether_type filter to new API at the same patchset. > > What you said is not for others features which has no relationship with filter API. > Correct? No, let me explain the situation to everyone. In DPDK 1.8, some features will have 2 different API. The old API works for ixgbe but don't allow to use i40e. The new API works only for i40e. It's really not convenient and, as a general rule, this kind of breaking is forbidden. But the development of the release 1.8 was especially difficult and we made some trade-offs that we never should do again. This situation is due to i40e developments. So it's the responsibility of the i40e team to fix it by removing the old API. To be sure it will be done quickly, the integration of i40e features in next release cycle (2.0) will be blocked until this API problem is fixed. -- Thomas