DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>,
	"H. Peter Anvin" <hpa@linux.intel.com>
Cc: dev@dpdk.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [dpdk-dev] [RFC UNTESTED PATCH] eal_common_cpuflags: Fix %rbx corruption, and simplify the code
Date: Thu, 20 Mar 2014 18:02:52 +0100	[thread overview]
Message-ID: <2288041.gdk3FRcxLX@xps13> (raw)
In-Reply-To: <20140320163921.GC7721@hmsreliant.think-freely.org>

Hi,

20/03/2014 12:39, Neil Horman :
> On Thu, Mar 20, 2014 at 08:53:50AM -0700, H. Peter Anvin wrote:
> > Neil Horman reported that on x86-64 the upper half of %rbx would get
> > clobbered when the code was compiled PIC or PIE, because the
> > i386-specific code to preserve %ebx was incorrectly compiled.
> > 
> > However, the code is really way more complex than it needs to be.  For
> > one thing, the CPUID instruction only needs %eax (leaf) and %ecx
> > (subleaf) as parameters, and since we are testing for bits, we might
> > as well list the bits explicitly.  Furthermore, we can use an array
> > rather than doing a switch statement inside a structure.
> > 
> > Reported-by: Neil Horman <nhorman@tuxdriver.com>
> > Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

This is a RFC UNTESTED patch.
So should I understand with this acknowledgement that you have tested it?
As a shared library? in 32-bit mode?

-- 
Thomas

  reply	other threads:[~2014-03-20 17:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1395330830-1310-1-git-send-email-hpa@linux.intel.com>
2014-03-20 16:39 ` Neil Horman
2014-03-20 17:02   ` Thomas Monjalon [this message]
2014-03-20 18:04   ` Neil Horman
2014-03-21 14:49   ` [dpdk-dev] [PATCH v2] " Neil Horman
2014-03-21 15:03     ` H. Peter Anvin
2014-03-21 17:48       ` Neil Horman
2014-03-24 11:18         ` Thomas Monjalon
2014-03-24 17:44   ` [dpdk-dev] [PATCH v3] " Neil Horman
2014-03-24 18:09     ` H. Peter Anvin
2014-03-24 19:52       ` Neil Horman
2014-03-24 20:47         ` H. Peter Anvin
2014-03-25 10:41           ` Neil Horman
2014-03-25 17:03   ` [dpdk-dev] [PATCH v4] " Neil Horman
2014-03-25 17:06     ` Chris Wright
2014-03-25 17:37     ` H. Peter Anvin
2014-03-25 19:52   ` [dpdk-dev] [PATCH v5] " Neil Horman
2014-03-25 20:51     ` H. Peter Anvin
2014-04-02 11:16       ` Neil Horman
2014-04-02 11:53         ` Thomas Monjalon
2014-04-02 12:42       ` Thomas Monjalon
2014-03-20 16:44 [dpdk-dev] [RFC UNTESTED PATCH] " H. Peter Anvin
2014-03-20 16:55 ` Neil Horman
2014-03-20 17:03 ` H. Peter Anvin
2014-03-24 16:06   ` Neil Horman
2014-03-24 16:11     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2288041.gdk3FRcxLX@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).