From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEBA9A0613 for <public@inbox.dpdk.org>; Tue, 30 Jul 2019 15:28:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C096B1C129; Tue, 30 Jul 2019 15:28:12 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id EEB251C11C for <dev@dpdk.org>; Tue, 30 Jul 2019 15:28:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8E79121DC7; Tue, 30 Jul 2019 09:28:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Jul 2019 09:28:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=szlcQ94kSbsL5GDlFDWM6hnQ+tNQTWbN8zbW2J6zs+A=; b=IzVZMaqXgES+ Dme4VUz6AhDXN5NvnRI2KlvlLjBXddXssLdl29RXMxqdoONmVycMBtx3L2xNI5Ue wbItb/4U55M2x6VuZs3WKMhrgCwB8tygFy/+Och22eg1hbtzM2c8NzZzvlrqSiQy WKrzjWfHS3JTzWHSyiXISC8IL5ppeZ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=szlcQ94kSbsL5GDlFDWM6hnQ+tNQTWbN8zbW2J6zs +A=; b=QhEVex+s6q1o3ndrpzPEstjL7v1hG/kFHTumysmU+/ddcEJtu5qq7MDHc DZvZdPVq/MTMauIQQRcsEfRsPPfhLbFaYSVAd8KMg8VXVCla0jsAT/3tdY76J/EK jjojoVqHzyCCwKI9+eX3PUmS0SSRd7U3o0zSvH8yIJYVg9GhYrrni+/v2ge3Nsl3 kU7dCBxXsx7e99tVTOHnRtKHC0hkNI3H6q9sLEzD5m8Olx6zYdCXOfGBqhj+ps7k m2gNXIhPv7PJnz0EOn09jxA7W/DIcnQZDtbN8S+Hf5OfK+Poo0bE0AklqS9I21md m8MQnf4FsI1oV7OHAz+jP6mNFTw3w== X-ME-Sender: <xms:6UVAXY9deG1kujWOtyjZYnvBxXItp2T7BdC9xYbMs1U8JRmKDzmB_A> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleefgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepsghuihhlthdrshhopdhthhgvrdhsohenucfkphepjeejrddufeegrddvtdef rddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghloh hnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:6UVAXXk2Tx1mYeCzFoX94if9wXVtLyXa-EzoEryisy0XFU9bdGZUSQ> <xmx:6UVAXWV6SW6LnIjSWMXeD0F8oBPAjvI0_wyed1iW9AMtu1dn-wWQaA> <xmx:6UVAXUEF_eldCaI2-4LYvxX-vo7yjc4N3V1QK9xPZSglYupHpmwYtA> <xmx:6kVAXT3hReDWbcR1E4usvNNk0Xi-28z9qmfMZ_KWlPqlyF8QAxHWjQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0888880060; Tue, 30 Jul 2019 09:28:08 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Neil Horman <nhorman@tuxdriver.com>, Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, david.marchand@redhat.com Date: Tue, 30 Jul 2019 15:28:00 +0200 Message-ID: <2288327.lZm7oOqCcf@xps> In-Reply-To: <20190730122036.GA19075@hmswarspite.think-freely.org> References: <20190705093401.69913-1-bruce.richardson@intel.com> <3048859.hlssD6FjPI@xps> <20190730122036.GA19075@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 30/07/2019 14:20, Neil Horman: > On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > > 05/07/2019 11:39, Thomas Monjalon: > > > 05/07/2019 11:38, Thomas Monjalon: > > > > 05/07/2019 11:35, Bruce Richardson: > > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > > > The names of the rawdev drivers and the resultant libraries they built > > > > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > > > Also, for the built .so/.a libraries, the names were not always > > > > > > consistent between make and meson, as, while meson enforced a consistent > > > > > > naming scheme, make did not, leading to differences - especially for > > > > > > those drivers with "rawdev" in the directory name. > > > > > > > > > > > > This patchset attempts to make things more standardized by removing > > > > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > > > > directory after all - and then standardizing the library names to > > > > > > "librte_rawdev_<name>" for both make and meson. > > > > > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > > > > > I would say we can merge it in 19.08 without prior notice. > > > > Any other opinion? > > > > > > Cc Neil > > > > We got no more opinion. > > Does it mean I can merge it in 19.08-rc3? > > > > > > > Sorry, I meant to get to this and completely forgot. > > I presume that this is solely a name change, and not a functional change, > correct? Correct > I would think if thats the case, you could just release note the switch, and > distributions could all linker files with the old names to maintain > compatibility. I am sending a v2 (rebased with new raw drivers), and adding a note in the release notes.