From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46552A0C40; Sat, 31 Jul 2021 22:44:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEB1C4014D; Sat, 31 Jul 2021 22:44:35 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 2FA7640042 for ; Sat, 31 Jul 2021 22:44:34 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C39B05C0117; Sat, 31 Jul 2021 16:44:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 31 Jul 2021 16:44:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= YF/ahNMI2qUkyADvLmClmehoTYlNrOJLl1yRyJgVJjA=; b=ES9F/8jtem4S4TEv ZVgNTWrTThH41bHq7IY3mxXIMccISOwgNHOXLXhfdIplP6Rcr1EdMFg8QxTRWF+g p9UBoKxUIyUxSljd05YbAqPcY9SZje+3iMPwdco0v3mu38elD9z6kx/vqpZ9nkTU kYFipZG8Lbgtm56Y+Y8a0jmSGb8652O7iFWhtJOVUn2nLbzPFsQenyCocJt9TFNi h4QwpvbBbCV9KObp1SN6gH9/eKfudxsB/7EfdZcFMd2ZGAqeebmiDjlFRuDPY2dv e05MQjCOfdi150m8ll11ivv24lxBu0ZPmBNLbMUlEla7eggk3nAYGwOp7slmxDda uTECDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=YF/ahNMI2qUkyADvLmClmehoTYlNrOJLl1yRyJgVJ jA=; b=XFKXn9/nut6RvMoBFOKy0I3j5CFhxy5GAHnChoM+i6fJH5rxkBTR9kR75 E5wPmD6BbtxG1qvGpFrVvRQCjH+2XOaXLj6K4QHYjac3OAIxj+K7eU42sByrh2kj d875i5qz9h0kvC3ToZtpdiudPQRFdQYFpuVFTdANT9mP0BdTePpVSNTwHqI36Bvc wfveV5GNfyPY4SCEwLyTB+Y6tWqRqDnRJ84E+TdDl+pO3ML9/hlVw9AsZOLwYwH4 WiqGqUNm71ZinRe7ldbBZHf7msj06ahv3Ld4irhOS3aHT/AUuvAlWBtq+03Fx7t7 qAVWg64WycBBi+ZkRnPDH5IgSQ8+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheejgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 31 Jul 2021 16:44:30 -0400 (EDT) From: Thomas Monjalon To: "Xia, Chenbo" Cc: dev@dpdk.org, "Yigit, Ferruh" , "dev@dpdk.org" , "mdr@ashroe.eu" , "david.marchand@redhat.com" , Bruce Richardson , andrew.rybchenko@oktetlabs.ru, konstantin.ananyev@intel.com Date: Sat, 31 Jul 2021 22:44:29 +0200 Message-ID: <2288461.sk2knC87vJ@thomas> In-Reply-To: References: <20210601084131.4277-1-chenbo.xia@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/07/2021 10:44, Bruce Richardson: > On Mon, Jul 26, 2021 at 05:56:17AM +0000, Xia, Chenbo wrote: > > From: Yigit, Ferruh > > > On 7/23/2021 8:39 AM, Xia, Chenbo wrote: > > > > From: dev On Behalf Of Chenbo Xia > > > >> +* pci: To reduce unnecessary ABIs exposed by DPDK bus driver, > > > "rte_bus_pci.h" > > > >> + will be made internal in 21.11 and macros/data structures/functions > > > defined > > > >> + in the header will not be considered as ABI anymore. This change is > > > >> inspired > > > >> + by the RFC > > > https://patchwork.dpdk.org/project/dpdk/list/?series=17176. > > > > > > > > I see there's some ABI improvement work on-going and I think it could be > > > part of > > > > the work. If it makes sense to you, I'd like some ACKs. > > > > > > > > > > Acked-by: Ferruh Yigit > > > > > > I am for reducing the public ABI as much as possible. How big will the > > > change > > > be? Is the 'rte_bus_pci.h' used other than './drivers/bus/pci/'? > > > > I don't see big change here. And I am not sure if I understand your second > > question. The rte_bus_pci.h will still be used by drivers (maybe remove the > > rte prefix and change the file name). > > > The file itself will still be exported in some cases, where the end-user > has their own drivers which need to be compiled, so I'd recommend keeping > the rte_ prefix. However, I think making all bus APIs internal-only to DPDK > is a good idea. I don't understand how it can exported _and_ internal. And about the rte_ prefix, it should be kept even if it used only in internal drivers because it prevent from namespace clash with other libraries included by the drivers. As a rule we should always have rte_ prefix for each symbol used outside of its own library. That said I am OK with the direction of hiding PCI bus API. Applied, thanks.