DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: stable@dpdk.org, dev@dpdk.org, aconole@redhat.com, msantana@redhat.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests
Date: Fri, 02 Aug 2019 22:57:01 +0200	[thread overview]
Message-ID: <2288744.0SrN437FYt@xps> (raw)
In-Reply-To: <1564662465-2925-1-git-send-email-david.marchand@redhat.com>

01/08/2019 14:27, David Marchand:
> The memory tests currently check that, for normal mode (not legacy mode),
> there is no memory left behind when exiting.

I think this is the real bug:
we are checking a behaviour that we cannot achieve currently.

> The problem is that if a ethdev port is allocated when scanning pci
> devices (even if the driver probe fails like when you have a virtio
> management interface attached to the kernel), on exit, dpdk won't free
> the associated memory since ethdev never frees the ethdev memzone.

As you said in this thread, we could think about how to free it properly
in a future release.
For 19.08, I would suggest to disable the test with a comment
explaining the reason.

> Workaround this by disabling pci scan.

If you choose the --no-pci workaround, please add a comment
about the reason.




  parent reply	other threads:[~2019-08-02 20:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 12:27 [dpdk-dev] " David Marchand
2019-08-01 12:29 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-08-01 13:22   ` Gaëtan Rivet
2019-08-01 13:24     ` David Marchand
2019-08-01 13:26       ` David Marchand
2019-08-02 11:13   ` David Marchand
2019-08-02 13:37   ` Aaron Conole
2019-08-02 13:45     ` David Marchand
2019-08-02 20:57 ` Thomas Monjalon [this message]
2019-08-03  9:51   ` David Marchand
2019-08-05 10:19     ` Thomas Monjalon
2019-08-08 11:23       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2288744.0SrN437FYt@xps \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=msantana@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).