From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 21A583777 for ; Mon, 25 Jul 2016 16:54:02 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id o80so161001091wme.1 for ; Mon, 25 Jul 2016 07:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=qGDlufBek01rHmWOeixv4LO98DoALsoy4XZmenKK4VM=; b=MmpL6gfYCHecxom55aEcW2yfV7MJJ3KkWngbEhRzUhdvarMNZ1ZhoKAZDR4uhlxfyU sHqly739JNT7TF9ALy5Quy/hV3u1xG4tsPl+RUT9w+KvXxiz4yMkpVicNzlTvmg8SCuW AakINT1aV2MBeGAo8GiFoPNnxBLMW1ACIPEZgJk7Xq0aRKUL+gzB2ML6EQt8nd2EXL8x yazKBwNJSM2gQNxasbuvl3GzJnaXyK8gKaMKHrLSz28F9cZXyNLzA01L/SwcWpKDVGNi rnT2iOfeHclUDX5CnD7ZIiEtdA6qiV6PoM3XsaNnrnaPpYFgxH0TDGnyfw0tdvCrA2AQ PbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=qGDlufBek01rHmWOeixv4LO98DoALsoy4XZmenKK4VM=; b=eCJ/nS/j0Vz1RT1PfXTf37dZXRvUx8Zjfr7fPARUcrDKOUVNEyVQsB8Ko2wa0eoilG /kRxV3wPcJCmGNogBkIKc1Czt2thPNCKPyfujpGmrItlpPTQ96pounOJ8BJRHVhlXoqe YuvkfqvsXFNqLW+rihPE5ulp7yc38Q2Vaj/F6EZCpDuIST0HWyS2XIOSvF9SFFiveoRQ AsZbDUMxsP7ZvYWooRZA2FrjEi+Wo04i8X7FUrO/Mea3xXDJ33pz2W4VJmhr1JP8Frlu 8KoP59Wawhonnm7UwwLrki+C/fW1G4hYFZHxRgqGbZ9H/58mCz9D1NFt/Vx6uuwbvIVQ E+Zw== X-Gm-Message-State: AEkoouvBVVi392XAaLO6VEhEPDk7Tq64adGLOZ18sKkJfJVqaNrSuUg/75UxkeWH2XP7OorU X-Received: by 10.194.47.206 with SMTP id f14mr16953493wjn.98.1469458441827; Mon, 25 Jul 2016 07:54:01 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d64sm27795643wmc.22.2016.07.25.07.54.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jul 2016 07:54:00 -0700 (PDT) Date: Mon, 25 Jul 2016 07:54:01 -0700 (PDT) X-Google-Original-Date: Mon, 25 Jul 2016 16:54 +0200 From: Thomas Monjalon To: Jerin Jacob Cc: "Ananyev, Konstantin" , dev@dpdk.org Message-ID: <2289614.DUoAzxZEto@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B817D7@irsmsx105.ger.corp.intel.com> References: <1469380060-26696-1-git-send-email-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB97725836B817D7@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ring: fix sc dequeue performance issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2016 14:54:02 -0000 2016-07-24 22:57, Ananyev, Konstantin: > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Use of rte_smb_wmb() instead of rte_smb_rmb() in sc dequeue function creates the additional overhead of waiting for all the STOREs to be > > completed to local buffer from ring buffer memory. The sc dequeue function demands only LOAD-STORE barrier where LOADs from ring > > buffer memory needs to be completed before tail pointer update. Changing to rte_smb_rmb() to enable the required LOAD-STORE barrier. > > > > Fixes: ecc7d10e448e ("ring: guarantee dequeue ordering before tail update") > > > > Signed-off-by: Jerin Jacob > > Acked-by: Konstantin Ananyev Applied, thanks for the quick reaction