From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC24C43EA0; Thu, 18 Apr 2024 14:11:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E724402CC; Thu, 18 Apr 2024 14:11:43 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 359BF40042 for <dev@dpdk.org>; Thu, 18 Apr 2024 14:11:40 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VKxPt2J3QzwSYF; Thu, 18 Apr 2024 20:08:34 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 8BC4918006B; Thu, 18 Apr 2024 20:11:38 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 20:11:37 +0800 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.035; Thu, 18 Apr 2024 14:11:35 +0200 From: Konstantin Ananyev <konstantin.ananyev@huawei.com> To: Tyler Retzlaff <roretzla@linux.microsoft.com>, "dev@dpdk.org" <dev@dpdk.org> CC: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>, Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>, "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>, Bruce Richardson <bruce.richardson@intel.com>, Fengchengwen <fengchengwen@huawei.com>, "Dariusz Sosnowski" <dsosnowski@nvidia.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Harry van Haaren <harry.van.haaren@intel.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Jiayu Hu <hujiayu.hu@foxmail.com>, "Jingjing Wu" <jingjing.wu@intel.com>, Kevin Laatz <kevin.laatz@intel.com>, "Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>, Matan Azrad <matan@nvidia.com>, "Ori Kam" <orika@nvidia.com>, Pallavi Kadam <pallavi.kadam@intel.com>, "Reshma Pattan" <reshma.pattan@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>, Yuying Zhang <Yuying.Zhang@intel.com> Subject: RE: [PATCH 00/16] remove use of VLAs for Windows built code Thread-Topic: [PATCH 00/16] remove use of VLAs for Windows built code Thread-Index: AQHakSD9Kb/+a9mwQUKStIOkNdB3b7Ft794A Date: Thu, 18 Apr 2024 12:11:35 +0000 Message-ID: <228ca3e7cd7f4b5893343527e1727221@huawei.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.170.42] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hi Tyler, > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please provide the details for incorporation > into the series. I submitted the RFC series: https://patchwork.dpdk.org/project/dpdk/list/?series=3D31781 that provides alternate approach to VLA removal (without alloca()) for core libs. Feel free to re-use whatever is appropriate in your series.=20 If time permits, I'll try to look to other libs from your series (probably next week or so). Konstantin >=20 > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. >=20 > Tyler Retzlaff (16): > eal: include header required for alloca > hash: remove use of VLAs for Windows built code > ethdev: remove use of VLAs for Windows built code > gro: remove use of VLAs for Windows built code > latencystats: remove use of VLAs for Windows built code > lpm: remove use of VLAs for Windows built code > rcu: remove use of VLAs for Windows built code > app/testpmd: remove use of VLAs for Windows built code > test: remove use of VLAs for Windows built code > common/idpf: remove use of VLAs for Windows built code > net/i40e: remove use of VLAs for Windows built code > net/ice: remove use of VLAs for Windows built code > net/ixgbe: remove use of VLAs for Windows built code > common/mlx5: remove use of VLAs for Windows built code > net/mlx5: remove use of VLAs for Windows built code > build: enable vla warnings on Windows built code >=20 > app/test-pmd/cmdline.c | 2 +- > app/test-pmd/cmdline_flow.c | 9 +++-- > app/test-pmd/config.c | 16 +++++---- > app/test-pmd/shared_rxq_fwd.c | 2 +- > app/test/test.c | 2 +- > app/test/test_cmdline_string.c | 2 +- > app/test/test_cryptodev.c | 32 +++++++++--------- > app/test/test_cryptodev_blockcipher.c | 4 +-- > app/test/test_cryptodev_crosscheck.c | 2 +- > app/test/test_dmadev.c | 9 +++-- > app/test/test_hash.c | 8 ++--- > app/test/test_mempool.c | 25 +++++++------- > app/test/test_reassembly_perf.c | 4 +-- > app/test/test_reorder.c | 48 +++++++++++++++------= ------ > app/test/test_service_cores.c | 9 +++-- > app/test/test_thash.c | 7 ++-- > config/meson.build | 4 +++ > drivers/common/idpf/idpf_common_rxtx.c | 2 +- > drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 ++-- > drivers/common/mlx5/mlx5_common.h | 4 +-- > drivers/common/mlx5/mlx5_devx_cmds.c | 7 ++-- > drivers/net/i40e/i40e_testpmd.c | 5 ++- > drivers/net/ice/ice_rxtx.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +-- > drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 2 +- > drivers/net/mlx5/mlx5.c | 5 ++- > drivers/net/mlx5/mlx5_flow.c | 6 ++-- > lib/eal/linux/include/rte_os.h | 1 + > lib/eal/windows/include/rte_os.h | 1 + > lib/ethdev/rte_ethdev.c | 9 ++--- > lib/gro/rte_gro.c | 4 +-- > lib/hash/rte_cuckoo_hash.c | 4 +-- > lib/hash/rte_thash.c | 2 +- > lib/latencystats/rte_latencystats.c | 2 +- > lib/lpm/rte_lpm.h | 2 +- > lib/rcu/rte_rcu_qsbr.c | 6 ++-- > 36 files changed, 137 insertions(+), 123 deletions(-) >=20 > -- > 1.8.3.1