From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0086.outbound.protection.outlook.com [104.47.38.86]) by dpdk.org (Postfix) with ESMTP id 38ED24CE4 for ; Tue, 24 Jan 2017 15:37:34 +0100 (CET) Received: from DM5PR03CA0015.namprd03.prod.outlook.com (10.175.104.25) by BN6PR03MB2467.namprd03.prod.outlook.com (10.168.223.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Tue, 24 Jan 2017 14:37:32 +0000 Received: from BN1AFFO11OLC004.protection.gbl (2a01:111:f400:7c10::149) by DM5PR03CA0015.outlook.office365.com (2603:10b6:3:118::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Tue, 24 Jan 2017 14:37:32 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11OLC004.mail.protection.outlook.com (10.58.53.75) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Tue, 24 Jan 2017 14:37:32 +0000 Received: from [127.0.0.1] (B46174-11.ap.freescale.net [10.232.40.108]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0OEb6x6014680; Tue, 24 Jan 2017 07:37:21 -0700 To: Ferruh Yigit , Shreyansh Jain References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-17-git-send-email-hemant.agrawal@nxp.com> <7c521c9c-e868-81c1-39ec-ae26db8fbf69@intel.com> <33f05835-47aa-39d3-0338-01ab165be6d9@nxp.com> CC: , , , , From: Hemant Agrawal Message-ID: <228ff5e7-2fa8-7731-681d-e4759bff93cb@nxp.com> Date: Tue, 24 Jan 2017 20:07:03 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131297422524047656; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(336005)(39450400003)(39860400002)(39410400002)(39840400002)(39400400002)(39380400002)(39850400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(24454002)(199003)(189002)(377454003)(305945005)(92566002)(83506001)(120886001)(53936002)(31686004)(54906002)(230700001)(54356999)(76176999)(50986999)(6636002)(65956001)(6666003)(65806001)(189998001)(31696002)(85426001)(86362001)(5001770100001)(8656002)(104016004)(105606002)(106466001)(97736004)(4001350100001)(2950100002)(65826007)(8936002)(38730400001)(23746002)(36756003)(77096006)(81156014)(81166006)(5660300001)(68736007)(8676002)(229853002)(4326007)(47776003)(93886004)(626004)(356003)(2906002)(33646002)(64126003)(7126002)(50466002)(7246003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2467; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC004; 1:0GpMbqUnR89ibuAao11fFPfviiMKRD7n62Rkp6WnentRcV0DIAcE4E4XGqk3iOlFbFRP8dSjF/g5oo/jh38Al2+XQ+rcPl1UybJOPZDAg79nJcZY7b6akar2EcrcVFXSp3esziosCTYN9GWF+zZvVSm10bOaZ73dd9/TVRXQ0qA5TjqJV0OajpYnYmD65deep2ezZhjIGuzvj7nMImSb7rtfiGyMg+3wCn3zGL8SX1j5EDI+8crwvFmp+3LcJTjBzJ3W3d70fCvBSz/XFwa3PD5U6nDm7s8NOFawwfM+SD+05RchUfHW1s5a/Zh1Wf9bOEMZkaO7XbL2EeZE5IorSkWG5TiPxbZGeW1OHUjN3Gaxh3PybIas1tjPbBwrBnSZJV+8UCLFNJIruPtv4pS3dF1mzMm7to/vW8nqjyHlYhukMMDnp9HpEseSy0Li+kVUU2WhboTkKrBu28PRSUP1niu93GhVtyG+Fl4pdolZ0aV0mlmRs/7yPLgoE0pTgQ4EjS7hoMEnsuWm3mg0qCKHmMqQonarAzPJoy3T5jB8bx7lAbpAHxJ1qoGEjgkJ664cT7G+6FQfR4Z1UT8+uDh3thPU/k3xWnQROCBWtbfSfgdepdd65KiZYqsSLBStT1VP X-MS-Office365-Filtering-Correlation-Id: a5fdc9c8-bc7d-436b-ffcb-08d4446687ec X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2467; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 3:RPECMt9XxPana7N6Z4OueT13EfSuljJx7IIFPEaHlxYZ80uQjHFcTgrm9g7aKEsCIEPZsIkHZECkQCCwSE2W/IfGjbauJR6MaDT5aMEmJSbSB2b+quqCr6NbKnJ4o4O+PSdt7EloiI0AVtpjRfdv7Knbu3BOHsCmcgs/Bxq8cKbrgrFFLvm8B0GlFEtEVtNtKj0kNnxFO6Mrjudm0yhOCM17SUMnynoIFwsXkFISj+JQNKJwLOBxt+W5BTD7Z4WeQDZvXJWxdo2aQ4aJXnvxxZVOTYxBlxxMrcZfkeCYHBJqMpC6Zt3KiaguYiWUlVz1dzy6iK+d2TQmloHN0G10YHFDxuX05yChFcXMrdkPRXfcCpqgDVtzFF5KR6saJ2p9; 25:US6ghGDP3+TvKutxsNGosW7vuV6BgWbX+5ZTKsTG7fxAQ0DrOuFYGGygDBYyYyOHrOuYa+t5RHGWhaRs/0heLGfNmhRKe7TchOPwERf+p5HgzgLDU/aJKvtPjZd3NkxoRH+KtdOZPhqhzx0qdqaXFvC+d9l+6iU9Rc1vHiy5MUlIaKD59DPHv1T8iMiGY8/1ADWqwv6Fgfwbn7EtNQBH1XbccQEo3ZpbKop7h8G4vWqYFP8b7hQNZ5F8YPsKuyxTsvK/kcrZy+D/yxTHO2cfDddtllu+dGP6Y3tISg4crmi0/Xlvbmn2ocznUV+PkDvMbC8iygAAqn+znbiXV7kqZHc8/Hxd53v9SB6zMoVQE9XYzwdtyzlEO8auWQwVcT3zo19q3dGUDTAMgj9/EJptKbjBFs/GAmtfZ+Nh+B5asGL/U+hHxLjGT3DiXvifqh4dF+cocXcva8f8PnGjolLEMw== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 31:oYABiW5U/UbJOyCOACzHyYoJ5XsrQ8JO270/QhjiviNeGP29bwb2/POdkyW5fK8WGc0RaFYbDsvYbD/qyFd36BM5R5I+R5Ub3ZyMZQZ/qePueClPZ1CJFtxK+aapYPD3DIcV3iYMd66DCddkCt7liN7sXnAYtCvayv9zjBm2un98nDYiCLSkQV6e7phaMpethsvDv/+ZFBbmlTG1npPCULM3dsuj5DvFGcui9IhJ22dH14dyKGbOFNQYCsuGfbf9Yezw7OudDr6+JNK79ArR/w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13015025)(13024025)(13017025)(13023025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(20161123565025)(20161123559025); SRVR:BN6PR03MB2467; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2467; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 4:cE+rXtJIk1m4oXTjk8GxF6+xzTYCeDHyaJnkvugtjhunfSOFhvwSeGTNXZhpHIHtOINczte5gV4KI2/WcmrG2UbjDD1ih3vNWopwouhd0B0ALr6LSZm5MPBG/epZLzBsSH5VzrR2weK0DveVq1aEQmiBqTK/w5XBc9M1CGGUqtBMgzpsJGFKBppHystwUdBr4jqKzYlXGi0Vgmx1sytHk3jYYXUVI5gvwMsPncNLy4vJzFGPApKppTcDoF6mJ7PoSQjOYB47CDr6d6Sb/Cz2o4N6NqjmUxkjCrnW6jQLrAHUux/OZsA6TdlTfu5M0kIInnoltF/KM9T765+cm19O8SAP0kSu19Q6X9GdEgSAxo4Pf78QJ2mu2Zo9QhZP7YluEBV/WD+TR+jjBr7agZ/aknT+HFJ1Z4KhTWc9krd9E+CUwv5nOfbAOh8985mrEHYrvu+2za3R24w1HU5MCoa+4il+/estzRh7BI9XTBfKC4mzrftZOhUCo9o/1Y+LR3c4HkFg1SNrQFBH/M8JsAmMrPqh487ZpZ8+/VayloY4e+1QqdOmn/eRg/SpvwmVs+L6COaTiCGH41MqJsEbTkjl5+WY3wxDZEKJXyjjUKatRNonwGxUrxtMf3OcdgnHXz4jbMJMUupp7ipke+NJTHGvWkc/Rru/5bKG76c+hRyYqDsaQL628dQTdiT5mR8lZ20MemUgWprBsdhfie3jzHaU+v8I5Zq7MxD8YEcD5fWoPf+adKAgjysssyBoMLXZ55gl X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2467; 23:mLjCr6w8N6bo0wSDjLMKj1+H5/O1GSj/aMlSp?= =?Windows-1252?Q?Z77ZfXHi0g/7mbAjH/Q9KRqCADjuTpXwefcZvS/hTX6o0ImIrlMxR9ry?= =?Windows-1252?Q?MlEprFhDaNnW78yKfTMbmpvAhz2UFWK85Ev7BzfUF4JNHp2HkfNYnaoP?= =?Windows-1252?Q?US5HC2BwVY5zDB561K1kIKV6D7yrJRgG5imm46HLJr2TAjsD4gamlvgF?= =?Windows-1252?Q?aiJB+RDbqK8ZMWOBEFo31T8vXXvfV3IuQ6QBV6BWAm6ipG2KrJWJ6XnF?= =?Windows-1252?Q?DFUFtVVkr/yRgzvSSrpHyMxljDVNfjHAujXH4WLdhOWY2ExLBJULet8A?= =?Windows-1252?Q?8V3WrOa7ZxdiIF5EGk1ReATEJH/5MSoBXgPMZclCkOP1di99weaaJ5KR?= =?Windows-1252?Q?n2Pi082nqg0zOPiHVMiJ9kmkOcnYekiXre+qtXyR1ye05kf8pNTAp6UE?= =?Windows-1252?Q?qOC5IIHmG1SOJ+F2/sHNyklZv8KB4bH/j6//UWHukSCTJauoaTa6yDwc?= =?Windows-1252?Q?qwWPeMO6VdC1Y7+pGvpFHkGD1PxXQgzXRu21exQAoi6T5KJ+zXqnQub9?= =?Windows-1252?Q?EYIAONoX0EA3y/CPbS5sfG7l4iswxg+UXVMcqu7EToUQCrWjh+9+ITIB?= =?Windows-1252?Q?FANgT0WAmCBFzyCBHGOORhWbaSIOdIoDlKx0xfzNXPqRvsb+Cu0SMaYe?= =?Windows-1252?Q?QVUhfsbg+45ROLLSrOHcjax6dRj7ikpgevf8HFcevcQ2jPOcFgWETUER?= =?Windows-1252?Q?CTex0Z0BuK8vPtBbsMP5VzAATzHE/sWR6NRLXinBj0cSfAOBb7oKGw3G?= =?Windows-1252?Q?F5iq1vB+81karYv+R/doCy2cCiGXyJezouqghnNPeo2NHLkrUrE2V1Uy?= =?Windows-1252?Q?qgLDoXu18sDAqEHHwSI8ynhYahlBDsSrYYUNrt1UgWtqN8IEcDnz3Lu+?= =?Windows-1252?Q?p4STwy7CamZLvKb26uxMzAns0nYR3x7qTP1irc31iXdKyW8PO7rwt+GR?= =?Windows-1252?Q?cAmUY8GlqOEIc6P+IoIa8tzLCwGUmJ7UmTP/0VVeWbljkobPM+7HJ0Ja?= =?Windows-1252?Q?L1/jq25PpvBzWJOARPyCXR1XCPtJtllU4Npf4DJHWiXcLI88hk6nV6o6?= =?Windows-1252?Q?6332bKMJActKGnmIJUBqZIvfyNRUGTBF2B8FJ5lnMRyrEhTrilZVH10I?= =?Windows-1252?Q?iMtVI09phJcZOGEWbR4h5mTyZHQg9vYYWYXZENn+EPR6ywmiOWVkVzcV?= =?Windows-1252?Q?dKtUAGgUIu5CDz6M9j3xRl/lwF8EjUJZ/IZu11hMxqA4UVGGDNtwPAtj?= =?Windows-1252?Q?SsZvs7oi8tuOb0pc7D4QfohpqgyGEJm5m6PnHgVI2uqoHy6ShsXHHjso?= =?Windows-1252?Q?8Mt1Yb19rpzjBHHTzkFyc4I3xWDm4d9B1NuGQqxBE5K4ddFGyxd0W4K7?= =?Windows-1252?Q?mXDtVXgygRimYYtw6gVIiCqaF2fHdgmue8YLlcWKr9T6eLyiBpN0f8VI?= =?Windows-1252?Q?Pc0kI1rPSKfL5YcpywBOU8gb8nX1GYzE8gNxm/l0iGERVXEVJiwkzjKH?= =?Windows-1252?Q?Ma9u8j48umupeZz6C4gfVWOkTzvugvpMfWpb4Fgs7Lm14HumqS6EDlGk?= =?Windows-1252?Q?F7Dz2Q+TLSzsDHyaXuOJ41+/Ww1Eludkf50uB05FYiDUi/ghVW/RpoTj?= =?Windows-1252?Q?qp2qKQCEJ2JtGSM0YUnWoUq7UUmIKMb7pzP/C3vZ/9zZdGMFwST8CyLF?= =?Windows-1252?Q?f6kb5eGDRrf8cukdn0/yW8quozpTeHf/wPcITKrfjGmWXV/tX3dRja2f?= =?Windows-1252?Q?PJH?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 6:WA2tiWyzULWsQgJgbf7H6iImcH6huOKEm9AAksjo8rUv1f+MtS67CHT8M66myzVCMOm/ELCzPNMsNGlNGmu70TR4WlehIhNT4XYqhqCG4fQb9PJ/c3aeTp6eNTZ62L7Chej6uzfU71AJJImvB3EK0bqN1IIcnbCPnJx+YdI1mGJkCJXkVDlIlDX/zZ5lHBYXMwKOtVW6TtiWq9NQHl70hyYvDK+a+jiZISQ67mkJEn94fGYweHqh7lwSOVB5GT13wr+xsSq+9mILnz1sI6h/y2JQy9hjKkW6sbMNdacokNqaw4BYVvtD+A9PehAFtj2lK6PGmGxUUdQNtKMqGim+6luKeSVXfA21LAyzH6NAVbXL1hLAVpoPehyQ7sJWlgpD5fEQTpSpCy5LjIzGP4vMZNwSeLWx1T9Ilyt1ohLgI/m18iltGuMrxHexbMR0QAB7; 5:QZHM/n5DV7YPnMsgqkm04f2zDNSS5qZTHDQDLey+sesfkw/esdM9ChEMAI3JLTbTZVI/Ol3E2lSxM7poRDS6HPpCmQUow/8VGuGFjjptZcbT83zmq3diBbbUNC8BVt5N7VzHX/S/XJw3rSW4kucDkEPrrrGL/nFvIXZvOMvD/sWWRlFyn4fF+ET4Di0xf1ud; 24:ykECAFK6L+bU7vLEhly01R8IJgcyCOeaw+0QVQyvfB6wDD4MH3H5v6+aYFeFOU6rF+tqsTfu3cuBkTIblXkjP+5zJcQ6kGNSWmwUBAeRLYs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 7:MkqPZDCyqbQd+4SnZctQEwZMaJWPbPKWUGaorGicdSPm0fKuT7raiWPN+3Qnnd4m625Sq+KwQkRlcvKZ4EeBrL470R73gjB5rUYAX0+hSWElKfCFu2Fl57NHAtupuq0X0qxA41Bf9NB9IuxX94vcDN1Lau/pifwNF1ziDxAL0Cw66WDCCdx54dahW8O9O82YhKqbI8IREYa+Z+BqhCLvQe5fHnDknp2N0O1taLYL+yJvFFX9N8rswI2LnxUbJVXjCJpVAMgHfY2sgr4uxMxG0JAGqLmJhU/6OY8PIrOK/tYPS6WuKUDgobhGalBTyoUM4aZZSPRvH58LTnDcKiWMtFRxhuu1ze9DEKN23ej9uJhvoTcc4XmINUhyCM9aCF9yjrpy9kB66gNDBaSt04ZDUqa87ph7MCN36+NxWbpEWEeTd2HzlTDiCoczqfuFq7IIInDRa54PdD83K+y7VlTvVA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2017 14:37:32.1239 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2467 Subject: Re: [dpdk-dev] [PATCHv6 16/33] drivers/pool/dpaa2: adding hw offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 14:37:34 -0000 On 1/24/2017 4:19 PM, Ferruh Yigit wrote: > On 1/24/2017 9:12 AM, Shreyansh Jain wrote: >> On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote: >>> On 1/23/2017 11:59 AM, Hemant Agrawal wrote: >>>> Adding NXP DPAA2 architecture specific mempool support >>>> Each mempool instance is represented by a DPBP object >>>> from the FSL-MC bus. >>>> >>>> This patch also registers a dpaa2 type MEMPOOL OPS >>>> >>>> Signed-off-by: Hemant Agrawal >>>> --- >>> <...> >>> >>>> diff --git a/drivers/common/Makefile b/drivers/common/Makefile >>>> index b52931c..0bb75b5 100644 >>>> --- a/drivers/common/Makefile >>>> +++ b/drivers/common/Makefile >>>> @@ -35,7 +35,11 @@ ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_PMD),y) >>>> CONFIG_RTE_LIBRTE_DPAA2_COMMON = $(CONFIG_RTE_LIBRTE_DPAA2_PMD) >>>> endif >>>> >>>> -ifeq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y) >>>> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_POOL),y) >>>> +CONFIG_RTE_LIBRTE_DPAA2_COMMON = $(CONFIG_RTE_LIBRTE_DPAA2_POOL) >>>> +endif >>>> + >>>> +ifneq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y) >>> >>> I guess this is a typo, but this prevents DPAA2_COMMON to be compiled !! >> >> It should be 'ifeq' rather than 'ifneq'. > >> And it will prevent COMMON >> compilation only if CONFIG_RTE_LIBRTE_FSLMC_BUS=n which is not the case >> right now. > > It was the case for me for x86 config, but you are right it is not the > default case for arm. > >> >> We will fix it. >> >>> >>>> CONFIG_RTE_LIBRTE_DPAA2_COMMON = $(CONFIG_RTE_LIBRTE_FSLMC_BUS) >>>> endif >>>> >>> >>> <...> >>>> +# library dependencies >>>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_eal >>>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_mempool >>>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_common_dpaa2_qbman >>> >>> This dependeny doesn not looks correct, there is no folder like that. >> >> This is something even I need to understand. From the DEPDIRS what I >> understood was that though it refers to a directory, it essentially >> links libraries in build/lib/*. >> >> Further, somehow the development is deploying drivers/bus, >> drivers/common and drivers/pool in lib/* under the name specified as >> LIB in Makefile. My understanding was that it is expected behavior and >> not special because of drivers folder. >> >> Thus, above line only links lib/librte_common_dpaa2_qbman generated by >> drivers/common/dpaa2/qbman code. >> >> In fact, I think, this might also one of the issues why a parallel >> shared build fails for DPAA2 PMD (added in Cover letter). >> The dependency graph cannot create a graph for drivers/common >> as dependency for drivers/net or drivers/bus and hence parallel build >> fails because of missing libraries which are being parallely compiled. > > DEPDIRS-y is mainly to resolve dependencies for compilation order, and > should point to the folder, > > Following line will cause "librte_eal" to be compiled before driver: > DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_eal > > So "lib/librte_common_dpaa2_qbman" does not makes more sense, since > there is no folder like that. > > > Somewhere in the history, with following commit, DEPDIRS-y gained a side > effect, it has been used to set dynamic linking dependencies, to fix > underlinking issue: > bf5a46fa5972 ("mk: generate internal library dependencies") > > I guess you are having that line to benefit from this side effect, but > this can be done with following more properly: > LDLIBS += lib/librte_common_dpaa2_qbman > > > To resolve the drivers/net to drivers/common dependency, following line > in this Makefile should work: > DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += drivers/common/dpaa2 > > This adds following, which will cause "drivers/common" compiled before > any "drivers/net": > LOCAL_DEPDIRS-drivers/net += drivers/common Thanks for your suggestion. This is one thing, I am not yet able to fix. Based on your suggestions: e.g. LDLIBS += -lrte_common_dpaa2_qbman DEPDIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += drivers/common/dpaa2 It does add entry in the ".depdirs" ./arm64-dpaa2-linuxapp-gcc/.depdirs:168:LOCAL_DEPDIRS-drivers/bus += drivers/common ./arm64-dpaa2-linuxapp-gcc/.depdirs:170:LOCAL_DEPDIRS-drivers += lib ./arm64-dpaa2-linuxapp-gcc/.depdirs:172:LOCAL_DEPDIRS-drivers += lib ./arm64-dpaa2-linuxapp-gcc/.depdirs:174:LOCAL_DEPDIRS-drivers/pool += drivers/common However, we keep on getting: LD librte_bus_fslmc.so.1.1 aarch64-linux-gnu-gcc: error: drivers/common/dpaa2: No such file or directory make[6]: *** [librte_bus_fslmc.so.1.1] Error 1 >> >>> >>>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_POOL) += lib/librte_bus_fslmc >>>> + >>>> +include $(RTE_SDK)/mk/rte.lib.mk >>> >>> <...> >>> >> > >