From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 965AEA04A4; Sun, 24 May 2020 17:12:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CBCE1D160; Sun, 24 May 2020 17:12:37 +0200 (CEST) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id F21B51C43A for ; Sun, 24 May 2020 17:12:35 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 7FD5E763; Sun, 24 May 2020 11:12:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 24 May 2020 11:12:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= QQgL5fKNEHNFI8IGfe+DnBT3M0gGem+cJlSDpIlzo/I=; b=GuhbKNpvGbpVNY9k UlB/aOwztaYnlJztsrJNqD6frgX/21sYH2pGgmiflIc03eWlMiEGE2rMgtT6/a/q hELMHXJsXQswV7nk8PyMzU6ubZJkHo2ZfTym4XsG7Jqjsc3iltCPcrnOOMmezVYB bYt2YfEJh0XOrQ4uxgcWtXic+qzLivschSSjyseOpCGccf9kRzNwem/NbER5AAq4 o7RTs9rl74mhJRTPiFfXTvql5xF6CELwrNuD+NcloGx2emCpZehLsr+RgBZXDRZE iM+zckF3ZXfhTCKqciVsBPQz9IWBJJxx6qPd4WRbkAQdhvOrqjwvjnsFLQi15G5C 4B+6Gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=QQgL5fKNEHNFI8IGfe+DnBT3M0gGem+cJlSDpIlzo /I=; b=0cMpm20qgFafuQBmnzAVXceHLmuMCFBZJ+0MYPneCOVWda9OJM5zuB/sR 4rRFCdn7y8ZnDoZ0uEcncfKkpCXJPjdMTG1cOzKXykvqVU/C3WaOQw2MRnOqaXXp T7EKY7Qs+96zwqe2AJ1YXMIWN0Vr/PdavPLDRy/QjkvEmyeqRPuHoaPky2UtLZ3l Mepf6t6lEv0Qnr79A7zwwwCoVjUz7eaQXWmhzEvKq2NRSkDwu9SUlIpmaBel+cmc FBzxZ7PI4kYp/FP6UxVekVNCrMUHnPmWgWiAwux/DK0BK80sHegtPq/iWIDTngh3 OZiUWeHinGH9Wa50gA7tq/BmAynGQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddukedgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BF3CE3280059; Sun, 24 May 2020 11:12:28 -0400 (EDT) From: Thomas Monjalon To: guohongzhi1@huawei.com Cc: dev@dpdk.org, olivier.matz@6wind.com, mb@smartsharesystems.com, konstantin.ananyev@intel.com, jiayu.hu@intel.com, ferruh.yigit@intel.com, nicolas.chautru@intel.com, cristian.dumitrescu@intel.com, zhoujingbin@huawei.com, chenchanghu@huawei.com, jerry.lilijun@huawei.com, haifeng.lin@huawei.com Date: Sun, 24 May 2020 17:12:27 +0200 Message-ID: <2292747.XxK6CxzJO9@thomas> In-Reply-To: <20200515130850.12760-1-guohongzhi1@huawei.com> References: <20200515130850.12760-1-guohongzhi1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/05/2020 15:08, guohongzhi: > 1.rte_ipv4_cksum will return invalid checksum value like 0xffff.(rfc1624) > 2.__rte_raw_cksum should consider Big Endian. > 3.checksum 0x0000 is invalid for udp, but valid for tcp.(rfc768) Please consider doing 3 patches, thanks. It was sent late for 20.05, I prefer not taking any risk, and wait for maintainers approval. The patches must be reviewed and discussed in 20.08 timeframe.