Re: [dpdk-dev] [PATCH v2] add one option memory-only for secondary processes

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-01-22 11:17, Bruce Richardson:
> On Thu, Jan 22, 2015 at 09:05:34AM +0000, Chi, Xiaobo (NSN - CN/Hangzhou) wrote:
> > Hi, Bruce,
> > Since the DPDK2.0 merge window is opened now, so is it possible for this patch to be one candidate for v2.0?
> > I searched in the DPDK patchwork(http://www.dpdk.org/dev/patchwork/project/dpdk/list/?state=*&q=memory-only&archive=both ), but can not find this V2 patch. Can you please help to check why? Thanks a lot.
> > 
> > Filters: Search = memory-only  remove filter
> > Patch	 Date	Submitter	Delegate	State
> > [dpdk-dev] add one option memory-only for those secondary PRBs	2014-12-02	chixiaobo		Not Applicable
> > [dpdk-dev] add one option memory-only for those secondary PRBs	2014-12-02	chixiaobo		Changes Requested
> > 
> > Brgs,
> > Chi Xiaobo
> > 
> That's a question that Thomas is better able to answer than me, since he is the
> man with control over patchwork! :-)
> 
> Thomas, any feedback here?

I have no log for this kind of problem.
But I know that patchwork ignores emails with special characters.
And in your commit log, there are some in "mechanism and it?��s upper libs".
Moreover, this commit log should be wrapped.
A quick look shows also that some spaces/tabs are missing.
It was a v2 and there is no change log.
Please submit a v3 after cleaning.

I didn't review this patch and nobody gave its Acked-by.
So at the moment, it's pending. I'll try to review v3 carefully.
Other comments are welcome. I feel this patch can break some important things.
Which tests have you done? (it could be described in commit log)

Last point: I don't like the current implementation of secondary process
and Ericsson wanted to discuss their own implementation:
	http://dpdk.org/ml/archives/dev/2014-December/009796.html

-- 
Thomas