From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BA3FB1B8B7
 for <dev@dpdk.org>; Thu, 10 Jan 2019 15:55:00 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 558EF2207F;
 Thu, 10 Jan 2019 09:54:58 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 10 Jan 2019 09:54:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=vw6DqJQn2fftoq4y1yH686y3XGBbrMaczTk3Qm2NmvM=; b=LZjPzyYiDcGh
 ULzy1jQIuttKHyWeEgwyv3LYOLyVc23GnuQNifcfNu7oTZ+f6UYvWWM48kY48JEo
 2YBHXG7qf7ptNn+aU9Nguo/KpmbEyX1SC0B/9bBmYZ2TIfwhfujmHhxXiG7AO5tT
 ukt2HH0T93yRTffH+YFj3Wpvl0PuHxc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=vw6DqJQn2fftoq4y1yH686y3XGBbrMaczTk3Qm2Nm
 vM=; b=xw2d4mbnCi3Ac2b3tN4hxG+f7Nze+oQApWkHeM8x5UKRuPnuxZ0ZdYrd4
 zmuhCPL9/XWRPlWbq7AFxhzRs2boF+NJU97CoM9OabM3KZbG1usmIacuRI/Lqo7+
 KVz+skjsMWNrbk9rEXDf7FV7a7JAedv2NXmbUulroNmv/CoHqnQhV8zfboho9CrO
 RqGUz8lT2pZ+AMKCWNBDS5cURNm4eFYNnj/l0T7JbZMnQV6ZBOaBh2xDULtUfvyZ
 R5yI7a615X/hFESOiyglhGJ8p1zUQ8AhLhPJVQchW6XG691wS6hCU5u4p7nyG2qv
 MiqFu6tP8QGg6OEViUYWIdvqP0u6A==
X-ME-Sender: <xms:wVw3XN_sdFKCbePovfgTX5txehv0zgoGbBdP7uV1fnXIKnHRZX7I2A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfeefgdejudcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt
 tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh
 gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo
 thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe
 drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
 nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:wVw3XKHNcVKtQBOSqwKju4CajZ1SGeT7aPdtVaPv77PK6N32XRV_VA>
 <xmx:wVw3XNOLY7KHCL7fDG9Z3VjIE-QmHQQ5LnI0MH51rHdmoG7dYVY2NQ>
 <xmx:wVw3XJRM5DVGBZYTd3kKdlpL4G6b3TeU9etQeWAhbYrJB-Q4wtk-mw>
 <xmx:wlw3XI1lnXwel49LqNWRb1WH5yi-BMdtKqMCryt9l1bBTFwYumPivA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id C22DC100BB;
 Thu, 10 Jan 2019 09:54:56 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Date: Thu, 10 Jan 2019 15:54:55 +0100
Message-ID: <2299789.JsJELPjGV9@xps>
In-Reply-To: <2601191342CEEE43887BDE71AB977258010D901C95@irsmsx105.ger.corp.intel.com>
References: <1546546586-22009-2-git-send-email-konstantin.ananyev@intel.com>
 <1589360.MiOzkj7FWM@xps>
 <2601191342CEEE43887BDE71AB977258010D901C95@irsmsx105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 00/10] ipsec: new library for IPsec
	data-path processing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 14:55:01 -0000

10/01/2019 15:52, Ananyev, Konstantin:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 10/01/2019 15:20, Konstantin Ananyev:
> > > v6 -> v7
> > > - Changes to address Thomas comments:
> > >     bump ABI version
> > >     remove related deprecation notice
> > >     update release notes, ABI changes section
> > 
> > You did not update the lib versions in the release notes.
> 
> For 'security: add opaque userdata pointer into security session':
> 1) removed deprecation notice
> 2) add ABI change into release note:
> +* security: New field ``uint64_t opaque_data`` is added into
> +  ``rte_security_session`` structure. That would allow upper layer to easily
> +  associate/de-associate some user defined data with the security session.
> +
> 3) Bumbed version in Makefile and meson.build
> 
> What else needs to be done here?

Like I said, "update the lib versions in the release notes".
Please check at the bottom of the page, there is a list of libraries.

> > I think you missed a deprecation notice removal in patch 1.
> As Pablo noticed that would happen in "cryptodev: update symmetric session",
> this patch will be just dropped from the series.

OK

> > Have you checked the doxygen warnings in last patch?
> I think I fixed that in v7, are still seeing them?

OK
I did not check. It was just a question because it is not in the changelog.