From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1CD2A0524; Tue, 13 Apr 2021 18:45:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADA2F1611B2; Tue, 13 Apr 2021 18:45:15 +0200 (CEST) Received: from mail-108-mta97.mxroute.com (mail-108-mta97.mxroute.com [136.175.108.97]) by mails.dpdk.org (Postfix) with ESMTP id B2C9C1611A7 for ; Tue, 13 Apr 2021 18:45:14 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta97.mxroute.com (ZoneMTA) with ESMTPSA id 178cc1f61260004964.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 13 Apr 2021 16:45:11 +0000 X-Zone-Loop: 180102976b430a07a422061c6126e7a9ede10fdf579a X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ymnx5ySvSMplAHrP6iL7EsAdtF8AqRocgvIVQSpmKmM=; b=QQlPAFxdTakS1BZJrtVXYn0oYz 9zNPLXUe6Nf27yDHXRRU9i0NW2lwldxSyCEwaihMJcnF3ku1bn6uXnaXyMraJiYhbxQoboqbDaV6w D+ZuO2b68c3s5KBnuxyJfPqWOp3tnef+/ghZolTwEV+vyFbzYdoszdbb5+aUPgZ/ROvQvGCl/cPik pueU1vRQ93lBBz/V4K+RQgIfFvyWT2xszT8YyP1o/7ZReUs8crj2vFp1y8AnegZGRuObc6fCBap5a oxyApvFLzYLXbGcHX5w8Sh7erHdS32yKiv4rAQMO+4K3E4o9GEC6C0lLuGE7bSfM4nrAn4/rAqHem i61EZ7hQ==; To: Thomas Monjalon Cc: dev@dpdk.org, jerinj@marvell.com, David Marchand , Neil Horman , Timothy McDaniel References: <20210413084525.3057669-1-thomas@monjalon.net> <1766003.i8BfvDrVoT@thomas> From: "Kinsella, Ray" Message-ID: <22a0b254-9909-8ecd-03ea-3bab5e85b6fa@ashroe.eu> Date: Tue, 13 Apr 2021 17:45:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1766003.i8BfvDrVoT@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/04/2021 17:44, Thomas Monjalon wrote: > 13/04/2021 18:09, Kinsella, Ray: >> On 13/04/2021 09:45, Thomas Monjalon wrote: >>> The eventdev driver DLB was removed in DPDK 21.05, >>> breaking the ABI check. >>> The exception was agreed so we just need to skip this check. >>> >>> Note: complete removal of a driver cannot be ignored >>> in devtools/libabigail.abignore, so the script must be patched. >>> >>> Fixes: 698fa829415d ("event/dlb: remove driver") >>> >>> Reported-by: David Marchand >>> Signed-off-by: Thomas Monjalon >>> --- >>> This should have been done as part of removing the driver. >>> The CI is currently broken, so it should be merged today. >>> --- >>> devtools/check-abi.sh | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh >>> index 9835e346da..ca523eb94c 100755 >>> --- a/devtools/check-abi.sh >>> +++ b/devtools/check-abi.sh >>> @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do >>> echo "Skipped glue library $name." >>> continue >>> fi >>> + if grep -qE "\>> + echo "Skipped removed driver $name." >>> + continue >>> + fi >> >> So this is brute force fix - we can anticipate this problem happening again. >> Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch? > > Yes indeed we could have a file for this. > Maybe we could have a dedicated section [suppress_lib] > in the existing file if libabigail is OK with unknown sections? > That would be tidier - I will take a look.