From: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
To: Weiguo Li <liwg06@foxmail.com>, <dev@dpdk.org>
Cc: <adypodoman@gmail.com>, <xiaoyun.li@intel.com>,
<tianfei.zhang@intel.com>, <bruce.richardson@intel.com>,
<ivan.malov@oktetlabs.ru>, <jgrajcia@cisco.com>,
<hkalra@marvell.com>, <ying.a.wang@intel.com>,
<ting.xu@intel.com>, <simei.su@intel.com>,
<qiming.yang@intel.com>, <motih@mellanox.com>,
<shreyansh.jain@nxp.com>, <skoteshwar@marvell.com>,
<stephen@networkplumber.org>,
<kalesh-anakkur.purayil@broadcom.com>,
<somnath.kotur@broadcom.com>, <declan.doherty@intel.com>,
<gakhil@marvell.com>, <nicolas.chautru@intel.com>
Subject: Re: [PATCH 08/20] net/cnxk: free 'node' memory when node add fail
Date: Thu, 7 Apr 2022 14:32:35 +0530 [thread overview]
Message-ID: <22a33b44-2ac2-6ab4-7074-48e6380d8992@marvell.com> (raw)
In-Reply-To: <tencent_A4F9A97D84BB4ED0B7C648B048680C0B0F06@qq.com>
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
On 2/22/22 11:48 PM, Weiguo Li wrote:
> When node_add failed and function return, then the memory of 'node'
> is leaked.
>
> Fixes: 4435371b8fb1c0 ("net/cnxk: add TM shaper and node operations")
>
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
> drivers/net/cnxk/cnxk_tm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c
> index 9015a452f8..81afafd5b7 100644
> --- a/drivers/net/cnxk/cnxk_tm.c
> +++ b/drivers/net/cnxk/cnxk_tm.c
> @@ -389,6 +389,7 @@ cnxk_nix_tm_node_add(struct rte_eth_dev *eth_dev, uint32_t node_id,
> if (rc < 0) {
> error->type = roc_nix_tm_err_to_rte_err(rc);
> error->message = roc_error_msg_get(rc);
> + rte_free(node);
> return rc;
> }
> error->type = RTE_TM_ERROR_TYPE_NONE;
next prev parent reply other threads:[~2022-04-07 9:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1645551559.git.liwg06@foxmail.com>
2022-02-22 18:17 ` [PATCH 01/20] baseband/acc100: fix a memory leak in acc100 queue setup Weiguo Li
2022-02-23 17:42 ` Chautru, Nicolas
2022-06-24 20:45 ` David Marchand
2022-02-22 18:18 ` [PATCH 02/20] common/dpaax: fix a memory leak in iterate dir Weiguo Li
2022-02-22 18:18 ` [PATCH 03/20] crypto/dpaa2_sec: fix memory leaks in error handlings Weiguo Li
2022-06-24 20:46 ` David Marchand
2022-02-22 18:18 ` [PATCH 04/20] crypto/qat: fix a memory leak when set encrypt key fail Weiguo Li
2022-06-24 20:49 ` David Marchand
2022-02-22 18:18 ` [PATCH 05/20] net/bnxt: fix a memory leak in error handling Weiguo Li
2022-02-22 18:18 ` [PATCH 06/20] net/bnxt: fix 'ctx' memory leak when new malloc fail Weiguo Li
2022-02-22 18:18 ` [PATCH 07/20] net/bnx2x: add clean up for 'rxq' to avoid a memory leak Weiguo Li
2022-02-22 18:18 ` [PATCH 08/20] net/cnxk: free 'node' memory when node add fail Weiguo Li
2022-04-07 9:02 ` Nithin Kumar Dabilpuram [this message]
2022-02-22 18:18 ` [PATCH 09/20] net/dpaa: fix a memory leak when validation fail Weiguo Li
2022-02-22 18:18 ` [PATCH 10/20] net/failsafe: fix a memory leak in error handling Weiguo Li
2022-02-22 18:18 ` [PATCH 11/20] net/iavf: " Weiguo Li
2022-02-22 18:18 ` [PATCH 12/20] net/ice: goto clean up lable to avoid memory leak Weiguo Li
2022-02-22 18:18 ` [PATCH 13/20] net/ice: fix memory leaks in error handlings Weiguo Li
2022-06-02 8:04 ` David Marchand
2022-02-22 18:18 ` [PATCH 14/20] net/ice: avoid fix memory leaks in register parser Weiguo Li
2022-02-22 18:18 ` [PATCH 15/20] net/memif: fix some memory leaks in error handlings Weiguo Li
2022-02-22 18:18 ` [PATCH 16/20] net/sfc: fix a memory leak in error handling Weiguo Li
2022-03-03 7:39 ` Andrew Rybchenko
2022-02-22 18:18 ` [PATCH 17/20] net/vmxnet3: fix memory leaks in error handlings Weiguo Li
2022-02-22 18:18 ` [PATCH 18/20] raw/ifpga/base: " Weiguo Li
2022-02-22 18:28 ` [PATCH 19/20] raw/ntb: fix some " Weiguo Li
2022-02-22 18:28 ` [PATCH 20/20] regex/mlx5: fix a memory leak in error handling Weiguo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22a33b44-2ac2-6ab4-7074-48e6380d8992@marvell.com \
--to=ndabilpuram@marvell.com \
--cc=adypodoman@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hkalra@marvell.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=jgrajcia@cisco.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=liwg06@foxmail.com \
--cc=motih@mellanox.com \
--cc=nicolas.chautru@intel.com \
--cc=qiming.yang@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=simei.su@intel.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=tianfei.zhang@intel.com \
--cc=ting.xu@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=ying.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).