From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1D1045A29; Wed, 25 Sep 2024 12:58:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75A434025D; Wed, 25 Sep 2024 12:58:57 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 249D5400EF for ; Wed, 25 Sep 2024 12:58:56 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-53653ee23adso6003615e87.3 for ; Wed, 25 Sep 2024 03:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1727261935; x=1727866735; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FkIxJdACDMjfaAZjZgKVtLsZUb5U6i6BeLZ0WcwLFJ0=; b=ikpz6QOuelNGUX7oYkokywoxZESCq575ayUNRXaFi+Fb56yfKWAFjOxddQiUKKI7Lm r2/YdA6UHEJdJg/fPF+GZ28LmeeUIYyDmRcR0lcEcVledG4ozHD085YQGc+0KbNU+HkJ Airf0HZv1bygElXvL9ScgWfFkkRDWuNDydWwhfGnKnHt44OMiKSwvRTOhJF2w97P/riL eVs2Ln1hMcqIHkhAIwO8tNWlB3rZ+yhDw1lAhh8Q0BzHXMyAS2tceJUQLN3aYlhbEji5 3EK1U+wIaWhl22DIcew0UKl9JGUnrcTdKAdS5wSWALxHAds4/dyKbi7TWYlNryPzjYHy 1NhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727261935; x=1727866735; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FkIxJdACDMjfaAZjZgKVtLsZUb5U6i6BeLZ0WcwLFJ0=; b=HeCayldX3S5DpfkcY8y54t+j/YYevpssXyMheqQDwwdaG8vPfBTtaVlzSll7IAcx4D 8oMjaMzQpriVcWX0VFewN5CCYwDJ6PcmoPTGCRVzyjVeuAXR4rCxKDcv8DbnXr/+Mlbv fIPgSLIhqyTvIjltXU/xHqDgWaNx78zWrFgyDypZjTVJmXRsyL0n2JHVrDViq2qfI4Lk jE/3j+2GJyXn5IQ5OQNZtPqS8t7s9S5xbuNwF+FyQs2u3kl0UFi/Y+lCC7AH0lIPGciZ hOTq7lEkVWqblWJOMvEPqwXXbVGVbc8bMepaNPI4ShP0xQwIsGJBh8RW0BwWa5qImXz9 rZng== X-Gm-Message-State: AOJu0Yz7T4P3Mw303r2t8Itlf7k8jBN7jZvA0T7/Q4OZNwFD2fuAZ566 lNoz8iieaaCQZIfks6S4dt1g+GYZKX5kmqGQe1nwnQsVXaYUfGJ4OIVPyQS/v58= X-Google-Smtp-Source: AGHT+IEvu/k7SUS5+o14xE/2azz0TnNX1Fk/+/GL7JlIY/bsIAeijc7FVQ/lOMQnTZ1FFS/wcdk5Bw== X-Received: by 2002:ac2:4c47:0:b0:536:53dd:6584 with SMTP id 2adb3069b0e04-53877530cf9mr1237535e87.34.1727261935410; Wed, 25 Sep 2024 03:58:55 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c5cf497429sm1763908a12.37.2024.09.25.03.58.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Sep 2024 03:58:54 -0700 (PDT) Message-ID: <22a5f571-94ee-4c14-9434-2f5d0ffb476e@pantheon.tech> Date: Wed, 25 Sep 2024 12:58:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] dts: parameterize what ports the TG sends packets to To: jspewock@iol.unh.edu, npratte@iol.unh.edu, yoan.picchi@foss.arm.com, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, alex.chapman@arm.com Cc: dev@dpdk.org References: <20240821191557.18744-1-jspewock@iol.unh.edu> <20240923184235.22582-1-jspewock@iol.unh.edu> <20240923184235.22582-3-jspewock@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240923184235.22582-3-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 23. 9. 2024 20:42, jspewock@iol.unh.edu wrote: > From: Jeremy Spewock > > Previously in the DTS framework the helper methods in the TestSuite > class designated ports as either ingress or egress ports and would wrap > the methods of the traffic generator to allow packets to only flow to > those designated ingress or egress ports. This is undesirable in some > cases, such as when you have virtual functions on top of your port, > where the TG ports can send to more than one SUT port. This patch > solves this problem by creating optional parameters that allow the user > to specify which port to gather the MAC addresses from when sending and > receiving packets. > > Signed-off-by: Jeremy Spewock > --- I'm not a fan of exposing the functionality in this way. The developers needs to fiddle with ports and there are likely better ways to accomplish this. Ideally, the only information the dev would provide that a test case is a VF test case and everything else would happen under the hood in the TestCase class. Barring that, we could decorate the whole TestSuite as requiring VFs, which would result in automatically creating and removing the VFs in setup/teardown (test case marking would be similar, but possibly more complicated, especially if we wanted to abide only by test cases selected in a given test run). Then the test cases could pass a simple vf=True parameter to the send/receive methods.