From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 677D71B00B for ; Wed, 16 May 2018 08:05:31 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E468A195477; Wed, 16 May 2018 06:05:30 +0000 (UTC) Received: from [10.36.112.25] (ovpn-112-25.ams2.redhat.com [10.36.112.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BE822166BAD; Wed, 16 May 2018 06:05:29 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org Cc: tiwei.bie@intel.com, zhiyong.yang@intel.com References: <1525767284-130484-1-git-send-email-jiayu.hu@intel.com> <1526023567-111448-1-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: <22b841f3-284f-524a-adee-b0346ff61f6b@redhat.com> Date: Wed, 16 May 2018 08:05:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526023567-111448-1-git-send-email-jiayu.hu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 06:05:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 06:05:30 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix feature setting with vhost-net backend X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 06:05:31 -0000 On 05/11/2018 09:26 AM, Jiayu Hu wrote: > When the backend is vhost-net, virtio-user must work in client mode and > needs to request features from the backend in virtio_user_dev_init(). > But currently, virtio-user is assigned to default features in this case. > > This patch is to fix this inappropriate feature setting. > > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") > Signed-off-by: Jiayu Hu > Tested-by: Lei Yao > --- > changes in v3: > - remove unnecessary code change. > changes in v2: > - remove unnecessary indent change. > - change commit log. > > drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to dpdk-next-virtio/master. Thanks! Maxime