From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id C36822BB5 for ; Fri, 1 Mar 2019 16:19:29 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id z84so12587661wmg.4 for ; Fri, 01 Mar 2019 07:19:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Dm4gaN7YzLdNisSYJINJccEMCli1yo3zEq6okrUBdZ8=; b=WVp0WDUB46sf4JeDgOC8rZX02sfboyiWfdGgldIxKVe2pgoFHvLLHV9VKcxinI+Z9B 0AAX2O378SaTZH2rgNsxVm56WKsOEBYZ2cOYpenJBl9CColvRu7qBxVdZv2b3M5nuFRZ 2S6MqR18Ywn6Bw+gosIerwUXCQw1J5CAlOSZpAsE6Ulf6v6vJ70vVWk1507OA+TSLU3D RxUt0q+e6BbIqM8VVO3EOS10KlQO9xeznL3hzxMiiXAK27Kg9Q+yiGH4a6qfJ2UPIh3+ ObStE5LrQ7aV6xf0h0d6ibVkpogTGvfNW3lfM28It0a3h4tyrMzJUmCQ+mPDkj5ky8xt 9doQ== X-Gm-Message-State: APjAAAX8SxVciuKigf/mIQZZ1a1jQ9+bkmYYUQS9JljhQT4g0Oe62CxM 60EQJvqslqPyKRm3u7pjElQ= X-Google-Smtp-Source: AHgI3IZ778eSoO/8tsHT6ryPCLwd37BuA8K87HzFewc0SdleHwGTBTsgpUYWaOP4ef4ZfFArUFpq9g== X-Received: by 2002:a1c:e084:: with SMTP id x126mr3639519wmg.39.1551453569246; Fri, 01 Mar 2019 07:19:29 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:b00c:66c8:99df:336]) by smtp.gmail.com with ESMTPSA id a2sm15268907wrr.60.2019.03.01.07.19.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 07:19:28 -0800 (PST) Message-ID: <22cc9e2b335b7363d873b051eda71f0812184f0d.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , Thomas Monjalon Cc: Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, jeffrey.b.shaw@intel.com, ranjit.menon@intel.com Date: Fri, 01 Mar 2019 15:19:27 +0000 In-Reply-To: <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com> References: <20190301071847.13376-1-anand.rawat@intel.com> <20190301071847.13376-2-anand.rawat@intel.com> <1633455.prhy9BIAj0@xps> <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 15:19:29 -0000 On Fri, 2019-03-01 at 14:17 +0000, Bruce Richardson wrote: > On Fri, Mar 01, 2019 at 03:03:02PM +0100, Thomas Monjalon wrote: > > 01/03/2019 08:18, Anand Rawat: > > >=20 > > [...] > > > @@ -17,13 +17,19 @@ elif host_machine.system() =3D=3D 'freebsd' > > > dpdk_conf.set('RTE_EXEC_ENV_BSDAPP', 1) subdir('bsdapp/eal') > > > =20 > > > +elif host_machine.system() =3D=3D 'windows' + > > > dpdk_conf.set('RTE_EXEC_ENV_WINDOWS', 1) > >=20 > > For consistency, it should RTE_EXEC_ENV_WINAPP. > >=20 > For this one you can partially blame me - early internal review > suggested > changing to winapp, but I suggested holding off on the change for > community > consensus. Personally, I would prefer a little inconsistency and > keep it > as windows for clarity. In future, I also think we should just rename > linxuapp to linux, and bsdapp to freebsd! >=20 > However, for now, if the majority prefer winapp, I'm ok with it. > [Though I > can't help reading it as winamp half the time! No llamas involved > here > though!] >=20 > /Bruce We already have many utility libs and tools in DPDK, surely it's fine to add userspace-accelerated MP3 playback too! --=20 Kind regards, Luca Boccassi