From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11D0BA04AF; Wed, 19 Aug 2020 05:40:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C7405B30; Wed, 19 Aug 2020 05:40:21 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 799D62C02 for ; Wed, 19 Aug 2020 05:40:19 +0200 (CEST) IronPort-SDR: +hezxu0936Xro26yniD5Et/SqhaXmooFkvx+ugPqOncnfDmOSL9Im8RlD03mSEZ3YhGXWHPf35 hniInFVpLnnQ== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="239873362" X-IronPort-AV: E=Sophos;i="5.76,329,1592895600"; d="scan'208";a="239873362" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 20:40:17 -0700 IronPort-SDR: mDwbh5JDXn/6lYaNXrLLf6f3CubEgw7X1JywM0hnLwa/9mpqdleCPcZqmlLlhGqArc3Hgx2wmz HOfGXyrbs6hQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,329,1592895600"; d="scan'208";a="371107057" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.178]) ([10.67.68.178]) by orsmga001.jf.intel.com with ESMTP; 18 Aug 2020 20:40:16 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20200814174514.25100-1-stephen@networkplumber.org> From: Jeff Guo Message-ID: <22d5df14-26b7-899c-e9b7-ec152d7af9db@intel.com> Date: Wed, 19 Aug 2020 11:40:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200814174514.25100-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, stephen Agree, it is make sense that the ignore event will sometimes involve the information which should not be ignore. On 8/15/2020 1:45 AM, Stephen Hemminger wrote: > The debug message was poorly worded and did not include the > part that would be useful. I.e it never said what was being ignored. > Change it to print the message so that if udev changes format or > other subsystems need to be added then the necessary information > will be in the debug log. > > Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") > Cc: jia.guo@intel.com Should this cc line be removed? After that, please and thanks. Acked-by: Jeff Guo . > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/linux/eal_dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c > index 83c9cd660754..83b6068264cb 100644 > --- a/lib/librte_eal/linux/eal_dev.c > +++ b/lib/librte_eal/linux/eal_dev.c > @@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param) > > ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN); > if (ret < 0) { > - RTE_LOG(DEBUG, EAL, "It is not an valid event " > - "that need to be handle.\n"); > + RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf); > return; > } >