From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25BBFA04A4; Wed, 2 Mar 2022 18:34:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6A2A4068B; Wed, 2 Mar 2022 18:34:42 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id A161E40141 for ; Wed, 2 Mar 2022 18:34:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646242480; x=1677778480; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=0o5sgJk4XdOH6kee6d385aPji5YKcKGGMF0X+dK98ho=; b=kl3QZN6VXgJCoKvn7JokzK9Oq3K8zxK2fbJxR4ZJtnHcH6r+SfFVhGOf EukPS/s2FDj2/nnOloiPZhwPMbhhjO4wMO/ZxCl7ciDwM+P6fTn1lTkQN nTXHGKVFktsv7S4YcDheETofPsECXhTQuvSJng7BnRq1L62+CLI68PUgA jjRPh3SgSM7ajWDihuL0wFAzt2ZZLgUHkj9oezbpScBZL15FRACQIvktu IK0Cn5ZSe7tyVzP5VD75NuSLUtihZVDp5N5zOkCTOqlK/XyfNQvSOYl20 8w/sx0NBLoccU812rAqSEK77Me4xbJwWD9xGZjJqIYtKbM3KwbKrgo3Me g==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="234078255" X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="234078255" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 09:34:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="778950109" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 02 Mar 2022 09:34:39 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 09:34:39 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 09:34:38 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 2 Mar 2022 09:34:38 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 2 Mar 2022 09:34:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M2jh+Zyts1mSHr92kBQqp1PwSCs2r2BU81205eB1RZwk4ViHgf/k23uFoME02tUb6ks65O2e7I9LHqH6Kibb3yhcWXoLSLSD8P1/HO3uVdIZtH/NSw3LsfvNENqeWA7Ivh4BD8utnpD9iqMJWR0YvsHx+WpTcYSf3tJ9S6AMmRi/wzu2+CHTaOIVXJnUGqFuWkPkjvxdDb1FRetWq4AKyx5NSVMcghfVQva4YODhkIvd67mGEomTIa2SLCNitxJEMB0QT/NmekO/4iY3niEPSqd7tpupRcC4Umy/wf0rajHpdgh0vDoa4x0gfLnxq8cD6pSwMQrIVyPF40p2uJeXdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TdrTjnYNVyDhxJz3JEYZcJTseBdEDlPs9eOKGxhdWMs=; b=GCLCK7cpRYHwtVo65BCCuoOsl1qlaGJX7FEY6ds7aKz0kfpbaG1DCeLT0VShRFMiFuIBviNyIwWKiecUYjaxuYL73J6t7sWrJbGEWf9+ZpSeyw7t7KgdVhxJ0lGQ1or6YkJgoCesR1fjyofJTopKYk+QJhJfa6tuzydvZthxrjChUhX01ADz82NkowD7LzUPuEREZjIITvdLbKciEij7hBQdnJVLW5F3T4iVN/FbWwyeHzzMeX57svPjEMFFBadS70XQxsL8E6H2bVLVvbuTrMsYfpcAn0SunkPveVi6oHNkxVCK/G02zqeICwIC62PBhxEx9OeX7vnY8esjYiv7MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN9PR11MB5369.namprd11.prod.outlook.com (2603:10b6:408:11a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 17:34:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 17:34:36 +0000 Message-ID: <22ea3217-36e3-ea18-d768-9506d545a6bb@intel.com> Date: Wed, 2 Mar 2022 17:34:30 +0000 Subject: Re: [PATCH] net/txgbe: fix a bit with boolean operator Content-Language: en-US To: Jiawen Wu , 'Weiguo Li' CC: References: <004601d82e0b$e60ab910$b2202b30$@trustnetic.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <004601d82e0b$e60ab910$b2202b30$@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0510.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e272e1e-d623-4724-0433-08d9fc72eb80 X-MS-TrafficTypeDiagnostic: BN9PR11MB5369:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l3cw72EVyTEF51iiKL8iJHEnp+kBDW/WTW2H9M0dwrLff6dZ8qkZAUmlQZORNccpywD8b6kh87ahn9ktWYJKw6o9jLpx3eym4Rp1u0WijB9hd3b5yjVmH7GNmGa9Oj/JAP+DcOT/m79faSfryhqv5ahXuJap7e4XOKirrhpjXBfVpvU3T/+N8yAgi2KHnrJW//pakENpv5QHTVQoW0xyloecYaxxlVXYCRtVi2WYxCuw24BXf35DmkbuhQr5DoV2CLdh7SKzHLALaZXjFMIxxaGChrxNTXsBSgzZXXOrAOrwuijhHpRu7b2r1aoqkJo5Z6yhy9Kz4gYDARRJM5Z/V2MlhcwP8KGM/jz2C6KQCl3fSFFD6sqbcJxpK9rYEQCnoOYJhlq45Vl3Ozs4rNyeNkTv3fDrluA4MxOJyBdttBKnwOwJY8Do6kQqQqazlaH3/Ii8xZCSQpOqEpPc0oq6WCFq4GS9sPHgIMAsJeunsD6oCeWR/00R04LUhYMyeD6/3XcNbWwknUrRk2AhGEXU+j1jvvDJAupAFmQQXcm8ZvCnq7kh82Esq7PKLzWASBPkr0MOv3ZehhGRHQC71caudcJ+Ngt+7Z/flhRBO48l3tNXdwa3xVddemUMqcc2kCAGm0o8RLqAUAtkiAooHR9HSlvEDMaHAAphVGDNFNEopf4NPCPfwFugQZLz2s8KxMwPTVpwa0ofQiW8B2jpyMzRGWENymcyL3VZZTkBDp3L/dq68N5//cnh9CJtUb947JUR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(36756003)(6486002)(4326008)(31696002)(316002)(66946007)(66556008)(66476007)(6666004)(6512007)(6506007)(26005)(53546011)(186003)(2616005)(2906002)(508600001)(110136005)(5660300002)(38100700002)(4744005)(82960400001)(31686004)(8936002)(44832011)(86362001)(48020200001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TndwcHlGQ1UxQVREeENzNUJNbi9Db3ZsMmJFZ0h0QzFENXd6WE81dzhVL01I?= =?utf-8?B?OWNwcmJkU2pLVDZZU3dhVFNWVERoQy9FN2Ywei9ZRTVEODF2V1BMUTlHbjNB?= =?utf-8?B?eEtwN3dmTnR3d0RoVDV4WjNnY2ZpTk9odWlYWkNrTEp6M2cvVnhEQ0tuWDQv?= =?utf-8?B?dHVRRTJuSjlGMVZZOUk2TmRhT0RjclRLanJsVGloUU5yMjkvcXBna0tCeUtK?= =?utf-8?B?a2IwRmdkK0pjdXpjOXpRUkZteXpscVh6M2M5cFJXYm1CUEtpcHJjUW5kZ1dI?= =?utf-8?B?U0QwREljZXRsRFBuTEh1WHN1TVllbmpuT0VEMEFqOHBQNDI4SVdPNXAvbW5N?= =?utf-8?B?OUNYVG5INjV3RVFRTmNNdnU4bmdwcW83QWxSWjc5cVFUaFREVFliSXlsaXNZ?= =?utf-8?B?UlV2Vk1NSFZ5TUNBSFJ4aWxKelMxTk9XYnlQRnk3WkNqNU1LUzFkNGlObzVi?= =?utf-8?B?N3ZCVklUVE9ySkttOVZYU3NTTnRUaGhrbm5OTzFFNzFFUmpDanh4Wk5iVDAy?= =?utf-8?B?b2JZTmhkVFRvUTU0OWo2NGViTEpzZ0FqZEZWWVNVb0tDRTJ5REkxdjlwbjVX?= =?utf-8?B?dGJFQlE4VEFURFpQTld3TVdDckNyS3FyMW1ES1VoTHhmSUo1T0JSZk80ekxp?= =?utf-8?B?blVsSStzYUkzM1BvektiS0lHZC9WVk84L1hYSVZzVVkzN0FOendCOW9CcVI3?= =?utf-8?B?TnlNMDFvbGtkb2hvbVRtaVNkaEI5dUdDWVlyVitlcUIyb1FiaTdWTkRVNElI?= =?utf-8?B?bFhValNYVEQ2bElUbE1zSzY1clZtNkh6S1BnUGFZTGJ5UWMyNDMvRFY5clE0?= =?utf-8?B?bEJPbnlMRWtRT1poMGMyOXdyM0VtT0lhS1lIYm5IS053VXMremRPWkZOWk1O?= =?utf-8?B?b3A4Smo2WFUwL0RNZkk1bGc3U3ZIYnFYM2xQNzNFVlVyOGlaVTF4MEFNTlpj?= =?utf-8?B?MDc0UGhNK1NNZXRVU1JiKzFMM1RHVGRFT1lxTmpha3J1YUlaSlQ2Vmx2TlY2?= =?utf-8?B?d1VPSGJuTEZ6cFdvdlFvcjRYR3hYNHE5RUJtL1VnOXdxWmJEcng4QjlvMkxI?= =?utf-8?B?YUpMTVFJOWNPTFZzQmVxUnQ5TU02a29iUHd5d1lJWWY4QTVqR2VzZ0hDK0x4?= =?utf-8?B?ZXdmTGovZVp1cHRCbnN3ZFdOSFhEZ0tTczMzK1MwUm52NUhxUHFHOU93UkUz?= =?utf-8?B?aUNleGR6MTZ6K2JjWS9SNWFCeExERktFdTU0WGdMaDhFN01BTEd3Nmo5YXRD?= =?utf-8?B?RXR1d3ZHODcxNWpnSmFNTHRsWEZUc1ZCUWd3dko4L0Y3cXJoSVo3OEVrSGJQ?= =?utf-8?B?V2lCZzgva044TlJYNmNPRll4eHI5WHZYUEV4QURlZkk4aU1PSmFLWHpNUk5D?= =?utf-8?B?VmI4V01MTzhLWkg0aCtxbHZ6aFN0SkNESFJRcVo3eVlOcTlRdE0zY21LUHdV?= =?utf-8?B?bTd1bHVONTBrSnEveWpKN2VVN2ozMlFYMkllQU1oT0owYkI5SW1xSjQ0MDhT?= =?utf-8?B?dVpSSE5ibjZWSE1HNUx0blllZXJTVHc3QXQydEVoMnMzNGxVV0l1dVhMcjc3?= =?utf-8?B?b1pQdXB2K3ZDUmVzM1gzT1lDa3JsRG5PVFROd2xxWTJDS3ZSKzRKeTRNTWFZ?= =?utf-8?B?M3F5b0UvRkNYUXJ5ZEp4SkhPZ1pDY3dQSEFycmV2RXcwSGVuMDFIQ0R5b1hI?= =?utf-8?B?R3V0Q3BKYzgwclVGUGlzY041YVFWMjVybmtKYVhLSzR6K3dVR1cvSG8wWnJG?= =?utf-8?B?MERUYnFlZUVXNHkvZ0c0RXNrNjRYL0c5aUgyRUUxd21hNUhMR1JFSDBydEFG?= =?utf-8?B?VTRUM1JTMW1GUHdLTkVQd3BKdTE0MURTOHpjZXY0U1Y2ZzdGV1dId0xoSjlr?= =?utf-8?B?YUpZdnEvREZVVWhpaERHanFlRDE1YmxtK0xTYUxvbnFSTkl5Z2FMa1pacHh2?= =?utf-8?B?KzIvYXJMQ1BBMTFQbE54SWM0Z3NIZ1p6cGVVQTd5Q1RNa0hXNWxqUkhBNUhu?= =?utf-8?B?UTB1QnVWOEN4UGJRSk9mdlBMOVZhNHZnL0toRm1jOWcwMTY1MC91VVlpSzdt?= =?utf-8?B?ZS9KbjFlanpqR21IYzdSWnFJQUY2a1JkNmFGRzRzbTNxb2EvR2ZOZnRFN2tl?= =?utf-8?B?VXB3S05qZ1JlTFJ5WHh6MDIxZlk4N2xUTU41eXN3aW9HUkIyNDJVUWRnK3h5?= =?utf-8?Q?lA40LazF44Jv66FVCJ3b2Vc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6e272e1e-d623-4724-0433-08d9fc72eb80 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 17:34:36.0749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mcX4Bn3ZwyHjBWQ9XGxJkvWytn3dNEB6YOnlP0tiFc1Y9EcXoVeFiahssUXYBTF7QxUEawjiJLW91sMhYSJpKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5369 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/2022 8:02 AM, Jiawen Wu wrote: > On March 1, 2022 2:09 PM, Weiguo Li wrote: >> Since boolean value is in 0 and 1, it's strange to combines a boolean > value with >> a bit operator. >> >> Thus it's highly possible a typo error with "if (A & !B)", and more > probably to >> use "if (A & ~B)" instead. >> >> Fixes: c1d4e9d37abdc6 ("net/txgbe: add queue stats mapping") >> >> Signed-off-by: Weiguo Li > > Acked-by: Jiawen Wu > Applied to dpdk-next-net/main, thanks.