DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Wilder <dwilder@us.ibm.com>, dev@dpdk.org
Cc: stable@dpdk.org, chaozhu@linux.vnet.ibm.com, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9.
Date: Wed, 20 Feb 2019 16:04:20 +0000	[thread overview]
Message-ID: <22f8d817-c649-2770-b86e-5229559bb13b@intel.com> (raw)
In-Reply-To: <20181116173538.5321-1-dwilder@us.ibm.com>

On 16-Nov-18 5:35 PM, David Wilder wrote:
> Removed the use of MAP_HUGETLB for anonymous mapping on ppc64.  The
> MAP_HUGETLB had previously been added to workaround issues on IBM Power8
> systems when mapping /dev/zero (see: commit
> 284ae3e9ff9a92575c28c858efd2c85c8de6d440).  In the current code the
> MAP_HUGETLB flag will cause the anonymous mapping to fail on Power9.
> Note, Power8 is currently failing to correctly mmap Hugepages, with and
> without this change.
> 
> Signed-off-by: David Wilder <dwilder@us.ibm.com>
> Reviewed-by: Pradeep Satyanarayana <pradeep@us.ibm.com>
> ---

The changes are contained entirely to POWER9 code paths/docs, so while i 
cannot verify them working for obvious reasons, i have no objections to 
this patch.

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>



-- 
Thanks,
Anatoly

  parent reply	other threads:[~2019-02-20 16:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 17:35 David Wilder
2018-11-18 13:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-11-27 10:50   ` Kevin Traynor
2019-02-18 15:46 ` Thomas Monjalon
2019-02-20  8:07   ` Chao Zhu
2019-02-20 16:04 ` Burakov, Anatoly [this message]
2019-02-20 16:27   ` [dpdk-dev] " Thomas Monjalon
2019-02-20 16:44     ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22f8d817-c649-2770-b86e-5229559bb13b@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=dwilder@us.ibm.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).