From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7573328F3; Wed, 20 Feb 2019 17:04:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 08:04:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="125896687" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.110]) ([10.237.220.110]) by fmsmga008.fm.intel.com with ESMTP; 20 Feb 2019 08:04:21 -0800 To: David Wilder <dwilder@us.ibm.com>, dev@dpdk.org Cc: stable@dpdk.org, chaozhu@linux.vnet.ibm.com, thomas@monjalon.net References: <20181116173538.5321-1-dwilder@us.ibm.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <22f8d817-c649-2770-b86e-5229559bb13b@intel.com> Date: Wed, 20 Feb 2019 16:04:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20181116173538.5321-1-dwilder@us.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 20 Feb 2019 16:04:24 -0000 On 16-Nov-18 5:35 PM, David Wilder wrote: > Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The > MAP_HUGETLB had previously been added to workaround issues on IBM Power8 > systems when mapping /dev/zero (see: commit > 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the > MAP_HUGETLB flag will cause the anonymous mapping to fail on Power9. > Note, Power8 is currently failing to correctly mmap Hugepages, with and > without this change. > > Signed-off-by: David Wilder <dwilder@us.ibm.com> > Reviewed-by: Pradeep Satyanarayana <pradeep@us.ibm.com> > --- The changes are contained entirely to POWER9 code paths/docs, so while i cannot verify them working for obvious reasons, i have no objections to this patch. Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> -- Thanks, Anatoly