From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F922A09D3; Wed, 19 Oct 2022 17:18:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5460742BB3; Wed, 19 Oct 2022 17:18:49 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2084.outbound.protection.outlook.com [40.107.100.84]) by mails.dpdk.org (Postfix) with ESMTP id 931EF42BB1 for <dev@dpdk.org>; Wed, 19 Oct 2022 17:18:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXXUHfHttxG5TZRFGVRhsh1wXXcSaT6phW/ADcOzTZpysXnK2v53PbMeKmQbRTYsmkX5lCfUC8DK+tJS9WEm59Vuzf8h6C/7H+Xq3mLRyINe0ssVpdAbOGUFs6+fG4/Brlon/8V9hy0S0Z7mmO75mMuipT4g4nVjWT8LrKOdBOlmXIwe71verD1xSlvXTCP7yspxBarZBpFbKoVBUqhNgoQmr2mbaS2b6d2VksYwboPVPD1KtdekDEMhv7yWR2of2JMdUGk3Y3aiqZfx0NKNGmXgnbN6G62BIbERdqrailWJAcTXyVaWn91E7YqZ+fEXgZf8twg71lsXHeNJJ8OZ3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9+40wBS+rBXQ/hGVWcmu97YkCfZSinQKbZ2MFdnAluo=; b=Rz9+jCUYZGyy/HYNhVC62D3THFPZNFJGVlBG4lIVp+YlIqiZRb7eb8fk7vJA8hVw8rSNy2mw5SHwR+cpFbTC/7m/BWugLkZtRw5N25xcxhJ5vWkEypXtiwZfrvf3dI7g9FTNiguHom5BahnBIMewAzuFDghkPbn4kac0r1gN7gHKKuvh5f+mW36hoqe6bMX7rNDHawoJ03xscRJfXFfxqDSrE2TEyXWJsjgTEsUtDOhgX/1qehcQrh5DF5dop8aM6Gicx0ssxCsSmt+yP13prTF6wmfq5qVdrVOLg9FdCuvZCZgfJ70YRWDBhcin9yaSgLaCQJYTYAW7bctilTuqsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9+40wBS+rBXQ/hGVWcmu97YkCfZSinQKbZ2MFdnAluo=; b=OreR0VYDoUTzviydd3eJlsajm3OIORMLIPGe45gYjGygcoR22tqH2zuCybdLmrrePtGCCChByOSiTDRer7Urg7gmRZhN+eBBKH2nP15y283i59sxbwd6AE+IGCx9VEMkx8Kv8zYBm6duaRvjAoGZS7eQ3VfRFWNdnb6hWITMuvU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by LV2PR12MB5989.namprd12.prod.outlook.com (2603:10b6:408:171::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct 2022 15:18:45 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022 15:18:45 +0000 Message-ID: <22ffbe85-8b30-c6c5-7c0d-117776e48b9c@amd.com> Date: Wed, 19 Oct 2022 16:18:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code Content-Language: en-US To: Hemant Agrawal <hemant.agrawal@nxp.com>, Junfeng Guo <junfeng.guo@intel.com>, "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>, "jingjing.wu@intel.com" <jingjing.wu@intel.com>, Stephen Hemminger <stephen@networkplumber.org> Cc: "dev@dpdk.org" <dev@dpdk.org>, "xiaoyun.li@intel.com" <xiaoyun.li@intel.com>, "awogbemila@google.com" <awogbemila@google.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "xueqin.lin@intel.com" <xueqin.lin@intel.com>, Haiyue Wang <haiyue.wang@intel.com> References: <20220927073255.1803892-2-junfeng.guo@intel.com> <20221010101757.878317-1-junfeng.guo@intel.com> <20221010101757.878317-2-junfeng.guo@intel.com> <ef0e9d52-2efa-09d9-02ed-b5b71b6a9ab4@amd.com> <AS8PR04MB906469E52CCD194D29CE00A2892B9@AS8PR04MB9064.eurprd04.prod.outlook.com> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <AS8PR04MB906469E52CCD194D29CE00A2892B9@AS8PR04MB9064.eurprd04.prod.outlook.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0207.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::14) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|LV2PR12MB5989:EE_ X-MS-Office365-Filtering-Correlation-Id: 87bd5abe-0162-4934-676e-08dab1e536ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v++wJlgQS19iDkEKnc+fT84zwET7kSK1RI+SpeUi9WhAcoPAUUo3LlAN3AfCnVZ7DxjJwGlx/vDnAKBtRQesaGLN4et/gmKI35z67vNS30qrkfAk/ALD9SvrD9QfCJrp2HttstcckV5h6zK5deERtFq/zJ3BzBuwz6pN/lmPXVmyxK+/PG+UTm5kb6EOBXZr1KoorlHFhr0/BvrkAwXY4a4X7h0vsO99FrwCuL712BYooX57DeDKE+bDhJQllbjqa+VT/4n7hb95RCDlasg+r5q/2lOayg2y/LaXgY8HiisOEDwo5egD1PUMwaxj8WYh6vEqskxWGLWalGyyqAaTwAAgENzUpKVHBQP/EBJpYdYisSJ/RaeX9URzyItxXMOYPyhKj4Y4zD0gc+vuFJv4fBJmRL/E9EdBsJl+9Jgg4W/GdKTPPxyoa3gyf4SO2yyp6kbRxgozV9+hhbeLUHLh0WVaT//dzSsFxcSzBF3wA2J9/THABdXozsdoN9XC7GWAKqM/0zpO8AYsSllhngV2Dkreio62xoPAndA2pOfAAuPl4vS9uDjU0leC27osKQ5sZkqieRHJ6i643k6S2mu8L+UxO3rCldPriU6UzWQ0c9pBXi8x4QeTs3GDYDwT1psLj25k5on1UQxoC63u7Q/fCAQDFXkZpE07xBpki1fe0QFjSotsvTM1eNbI0r/ycc2byfm5lTesIocK+SrBvvhv33kADESpUNcfZCqnYINicFjjQc4778B3VCrmmRRZcBNmoQP9o8uBq53+cNBjxslhJDGmLbeM4cJIMy0EIfNA6xfICjCl+pEnnaCuNuNRAy4f X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(451199015)(316002)(26005)(110136005)(54906003)(2616005)(53546011)(2906002)(66556008)(186003)(6506007)(36756003)(41300700001)(5660300002)(44832011)(7416002)(31696002)(6512007)(83380400001)(6666004)(4326008)(8936002)(66476007)(66946007)(8676002)(31686004)(38100700002)(86362001)(45080400002)(478600001)(6486002)(966005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3J2NVQ2ZlJqanlXYUtrdlVHRnlxaGhyQS80cmMzSUpnbTh5R3dIWnZmS0xG?= =?utf-8?B?QldrUzdyODZrcmZaMmFra0EwMFNBczBGeUdsOGZ2VHAvaXdBc0RFVXpYRUFp?= =?utf-8?B?Q3M4dHRQdmVvMkV3cWYwZWNXSHIveXpQaXIxVWhMNUFNKzgvSFFhdGVMKzBH?= =?utf-8?B?M2tUbi9IdW10UVNsanJRbjBoQWI0blB0bXFORlRvWTBJcjdQNjJtdDFQR2tH?= =?utf-8?B?RmNDM2FONkx5TE1LZDhNbUZGSml6a21iRlU4MEgxaG9LdGdaRVByTDhFUjdw?= =?utf-8?B?cHRTSXJGeHFCT0F3UWlpdURRbUZtMjdJVnE4UGM2RHN3MTUvUjlaM2ZSWTBn?= =?utf-8?B?Ri9XQ1E3UEtxb256WVFlRlhvRmtLVnM4WFBlTmxaTlcyRFljekFIaDF1MExn?= =?utf-8?B?aXp0RlVDU1J2bitSak5PVXFVMjlHWm01aW1QdXB6V3BvdnllaS9PenJYWElo?= =?utf-8?B?clRocjRsWWU0Z25IVXI4TzkzWStGS0V1ckl4NVRONWxQWnkyaG5jbzY0aGhT?= =?utf-8?B?ZlQzaVE1b3V1SGcxa2c1OFdaVUkybzdBeW9DTTYwaTJ1UVFwSGVmakRRRXZS?= =?utf-8?B?bGxBeENBajJLdlhHL2R4RVgwdDVDVVp5bHBYMnNiWDd1THVJOHg5N0xEaWF1?= =?utf-8?B?RGhBM2JWRmxhUFhicnpjTXFkOHBFaDlPeFJDbU5teTVQQzA3UmFRZTNxYTly?= =?utf-8?B?WjFmTXZ6aWkwK3VDMmNVTlVsT01IeGVxTjc1ZFhVdEl2bmVaR1A1bnhyY1Rt?= =?utf-8?B?L29hVExyYnRVWjNYLzA2clhKRXI1VEtxR2l3dzdtUTlJUkw3VG5lbmdJZHZZ?= =?utf-8?B?ZXpjcFlObFIwdGNJdjVsY1orTGx2R2ZJVUl1OEwweDRtZVYzRC9WRFFZVWgy?= =?utf-8?B?QzFKWTJ4Z3FvVitGcEU0SEpVTWNwazU1d2pUUWFPY1Q0OUVRQmlxM3NlbVpE?= =?utf-8?B?d1dLWGdIaWg1OXdKb2t0K1pzY21QVnlZdUpIczBMUXFlejRQZ0lhRG9TaGdI?= =?utf-8?B?MkFwQ01XWUl6eTZTWHJ3V3c2MGRoTzZhRWhyUDU4NGZ4bmlucmpOQmtSZHY1?= =?utf-8?B?REk5bjRwZHkwaUh5ekQzeSs1NGtqdklIRlZmNC95OXoxeXpzMGpLS3NLaEcx?= =?utf-8?B?KzZKWFdZS203ZlY5VnZkN2lGVnk4QnNONFhoUFRhU2RqOTQ5OFB0SkMzVjNt?= =?utf-8?B?MzU1Q2dyRU1oUGFEbWxhZE1wamJmQ3V6ZWtqRmZXcWJjcVo2Zml5VDh6aWpE?= =?utf-8?B?MzlXWi9JMDk3MnB0UlZMcmNJbUZDYVJTVFJKd0xZQnJvMmRubTE2UGpMS1di?= =?utf-8?B?bVYvc2FBLyt5SFV5aDZkQ3FrM0tCSDF1bm1BNCs2UXpWOHVKOTRzUy9DbTMw?= =?utf-8?B?WHpLQy8vbmJjMmZ6aEVvcEoxajNMVXhVMkc3VmdIRi8zWTkrZFF4VnF4dFdk?= =?utf-8?B?Z2R6Tms5cUpZVTVia3pZaWJTMnNJajYwQ3NKWEl3RWdLQVNiVzNNT1FyNXA1?= =?utf-8?B?UFJhQUJzZlVVZWNTWWdEeXdpcnB4c2ZEZFJ5Nld2bkdMVmRMTy9hSjNYc3NW?= =?utf-8?B?SWhldmxhTkdObE8wd0dYK0gvb3BROWc3Tm5ZQ0hZTTFmSy9GL1VGV2l5c2Rs?= =?utf-8?B?Ykw5V0REclFsZjlmcy9GWnFhbjJBbHdTU1g4QW02QklydDQ2T2hTWVFCTmRy?= =?utf-8?B?Y2JwUWVUSmN3UVBkU1MyVmcwRjZhbFdUdllBNTNScDhXNUhSdXYxWFpsSE5G?= =?utf-8?B?eFNyNXlFNGxJdCs0Z3JNZ203UDVoaVcvUFg1c093YnlEbVhkMDZPZHg4ZjdT?= =?utf-8?B?dkcxbmpQNSt6dlFEZENXYmRvVGJvQXZCWFJqcFc2TEVIVWU3eXM1MStiVHZQ?= =?utf-8?B?MERweUVhbWs5R1FibUJ0bnViNFlhQmpuRk1mQ1FMWnVRNVliM01nV20veC9v?= =?utf-8?B?OVZSSkM4R3I2bUcydmV4amh3Zk9yYUlyV0ptcmRmV2RmcTJOMjFoaTZPRSt2?= =?utf-8?B?UWtlZk5vUjlaTXhWM0ZweFBCYjhkM056QzV5eW9Sa1ZjbFdhTEQ4eGtaRUov?= =?utf-8?B?QlY1Q2V5dndKd2toUW9PNXVMTDBFUWtRVGhWSlRYR01Ia3pURmxuZ3NzNG43?= =?utf-8?Q?qgBZGuvurqIXqcEE8SrFpXuh4?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87bd5abe-0162-4934-676e-08dab1e536ce X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 15:18:45.3344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e+caqPd9mFG0bS05whpBh2QOou2g6WEZpwd4tWsiWclnCGDp8qtDSimkC44/b21/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5989 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 10/19/2022 4:13 PM, Hemant Agrawal wrote: >> On 10/10/2022 11:17 AM, Junfeng Guo wrote: >>> The following base code is based on Google Virtual Ethernet (gve) >>> driver v1.3.0 under MIT license. >>> - gve_adminq.c >>> - gve_adminq.h >>> - gve_desc.h >>> - gve_desc_dqo.h >>> - gve_register.h >>> - gve.h >>> >>> The original code is in: >>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >>> ub.com%2FGoogleCloudPlatform%2Fcompute-virtual-ethernet- >> linux%2F%2F&am >>> >> p;data=05%7C01%7Chemant.agrawal%40nxp.com%7C45cbc9718dcc40d04e4 >> 508dab1 >>> >> d82440%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6380178391 >> 21579415 >>> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi >> LCJBTiI6I >>> >> k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LHunq53xMl8i >> W6%2B3scjZ >>> q0Bx7oF08yLWk424aw5lnwA%3D&reserved=0 >>> tree/v1.3.0/google/gve >>> >>> Note that these code are not Intel files and they come from the kernel >>> community. The base code there has the statement of >>> SPDX-License-Identifier: (GPL-2.0 OR MIT). Here we just follow the >>> required MIT license as an exception to DPDK. >>> >>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com> >>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> >>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> >> >> <...> >> >>> diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h >>> new file mode 100644 index 0000000000..1b0d59b639 >>> --- /dev/null >>> +++ b/drivers/net/gve/base/gve.h >>> @@ -0,0 +1,58 @@ >>> +/* SPDX-License-Identifier: MIT >>> + * Google Virtual Ethernet (gve) driver >>> + * Version: 1.3.0 >> >> There is a version macro in the code, is version information required in the >> file comment? >> >>> + * Copyright (C) 2015-2022 Google, Inc. >>> + * Copyright(C) 2022 Intel Corporation >> >> I don't know if it is OK to add Intel copyright, as far as I know this requires big >> enough contribution to the code, if this is copy of existing code, may be only >> original copyright should exist. >> > [Hemant] Yes, the general guideline is that one should add their copyright if they have big enough contribution. But at the end it is a guideline - not the rule. > It is up-to the original copyright holder to object. Does this mean as long as original copyright holder did not object, it is OK to add more copyright? I don't think they are represented or aware of it this change at all, I believe we (as community) also have responsibility to make these things correct, in our capacity. > >> cc'ed @Hemant and @Stephen for more comment.