From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03616A0487 for ; Tue, 2 Jul 2019 17:00:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A9071B9D8; Tue, 2 Jul 2019 17:00:36 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 81CF31B9CA for ; Tue, 2 Jul 2019 17:00:35 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 52C7A4C8; Tue, 2 Jul 2019 11:00:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Jul 2019 11:00:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=uKow7iYdMlJkDv/6fVwunhEJTqDksjlERViD9pHZQh4=; b=Hs7BBTv9gsTN gM1GzuDKVacwO8hdTtHgi0RLBKz81P7DSKF877jg7iu7w38u96B7SowE/ham6x/s WYChnV5v2wokexlzqROCQzKxUvUGbGW3GADV8BJuS9la7Hme+YEh4vsRr6S+Q3o7 yse5umsQ/BRN3Lj8xg9cjdnXBj9LzBY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=uKow7iYdMlJkDv/6fVwunhEJTqDksjlERViD9pHZQ h4=; b=yCDAO33hKZf2EMVz2PnufR76h5VBHrI9CMg8j6rjcNUskr/lkusQegKvK jTopQSYna2n9RErIAqwDzf5tnu1Tv9pFwHdJPdDl10FI6+DFbfOWu5/n4qoSUGyf EJh8I0Xl2w5uHIDRD8jco/hw6CjV1w9QouPxmKGqCcc8y6GDCGqTi3iLq8H00iem OcLx+x9o2XKqAZ7R9FAvpnoqeseWkevI5dDzhwbeud0qBcO6t4T+LHhndBan2QJF FJq+NBcybV+YshavltvEsKFrXg5BxPN7m7xGrWNH434xZcFAyNJa9uqG3D83LdIC sy7Z8TgJABfwsSPID8XZhvhFLje6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdekgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F3DB380084; Tue, 2 Jul 2019 11:00:30 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, bluca@debian.org Date: Tue, 02 Jul 2019 17:00:27 +0200 Message-ID: <2302033.au1c5QeZfu@xps> In-Reply-To: <20190702143555.GC405@bricha3-MOBL.ger.corp.intel.com> References: <20190503133537.58712-1-bruce.richardson@intel.com> <1843519.YIzr3x4FOW@xps> <20190702143555.GC405@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 4/5] examples/vdpa: support building from pkg-config info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/07/2019 16:35, Bruce Richardson: > On Tue, Jul 02, 2019 at 09:57:48AM +0200, Thomas Monjalon wrote: > > It seems "CFLAGS += -DALLOW_EXPERIMENTAL_API" > > is reset by the call to pkg-config. > > > > No, it's not, it's reset by the call to the DPDK make build system in > the other leg of the code. I'll fix this in the Makefile in v3. OK > > > +build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build > > > > Better to use the real directory name as prerequisite, > > instead of "build". > > > Not sure what you mean here, build is the name of the directory. [This is > also consistent with what is done in all the other example makefiles. If it > needs updating, then it should be done as a general patch to all examples > in 19.11 release timeframe.] Ah my bad, I overlooked it :)