From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C692AA050A; Thu, 14 Apr 2022 09:17:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4C6A40687; Thu, 14 Apr 2022 09:17:20 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 2E83E4003F; Thu, 14 Apr 2022 09:17:19 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 964F55C02A1; Thu, 14 Apr 2022 03:17:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 14 Apr 2022 03:17:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1649920638; x= 1650007038; bh=3aBN5b8PdPWQYdfouSLeejNVw63bNeluDOdmgVBLl2I=; b=s jX7cvvccvq7XaF3FYT52pFshnOKehmDfix+F151w6sWFKqTR2/b3AvRhHL7G9pci URTMG2+SlaDa0HG/MPUAfr/tfw6RFMVy38UwwjuazvZv62r2ZLpNt/RZbbb5Xy3S ZRTZA/8s45xo4fhIhfS9ONqtEx0StjAUKQEqdPU3y7ojU5R0pEjx0xK2vIurZSnj p/XZiVYXn7kRRxshQJInehbtOpYdlmNq1f9cokCKZ4/EQJPegtWiziDK2wBtfX7E UBXFSso8309M1lC0/FizEIMQt/rhYxGPJAjf4Wa3yl+EntUcKB9doc9SEmmHZGm2 4JDUjqY0M5ntVFgY5p7sg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1649920638; x=1650007038; bh=3aBN5b8PdPWQY dfouSLeejNVw63bNeluDOdmgVBLl2I=; b=oCCBBp1i4Byi8fQ7U08vqmn3F0Ba0 fAte2WKDntFdId0ciFwnELYr/e6eqYPW2QsDI6bIKlNUShRWrEEEINVisW7Fi2eF GqTY5d8CDijF/kgggkh1KkFwu27qA+17B+V65sMXgsJMwJw3gr9klFq0yPMNM/Zp 8JhFW4TvTUNSEjbAEr01p7sglF40gUJ9vz7KYEgaYfCc2Xa6V5N8W50cGf1iNAig vyLA0G4IhzoPmoc9Zq5KCouq+XGdsrHLrJGNYHmAMrA58Am2ppOB1ZsiiMy1HJIF 2FrTvr40ZFB+JvQo9iX68DkhcnJTz54OLvsfxMKup0NrkE8Rsg257sAfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudelvddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Apr 2022 03:17:16 -0400 (EDT) From: Thomas Monjalon To: Kevin Traynor , Christian Ehrhardt Cc: Ori Kam , stable@dpdk.org, dev@dpdk.org, Abhishek Marathe , Ali Alnubani , benjamin.walker@intel.com, David Christensen , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Luca Boccassi , Pei Zhang , qian.q.xu@intel.com, Raslan Darawsheh , yuan.peng@intel.com, zhaoyan.chen@intel.com Subject: Re: 21.11.1 patches review and test Date: Thu, 14 Apr 2022 09:17:14 +0200 Message-ID: <2302806.yKrmzQ4Hd0@thomas> In-Reply-To: References: <20220401102216.642587-1-ktraynor@redhat.com> <42961b14-a277-8cfb-13c2-66b904015df2@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/04/2022 07:52, Christian Ehrhardt: > On Wed, Apr 13, 2022 at 12:06 PM Kevin Traynor wrote: > > commit 026470bafaa02cba0d46ed7b7e835262399a009a > > Author: Thomas Monjalon > > Date: Sun Mar 6 10:20:23 2022 +0100 > > > > build: hide local symbols in shared libraries > > > > [ upstream commit b403498e14229ee903c8fff9baefcb72894062f3 ] > > > > In this case the symbol is not redesignated but removed, but it doesn't > > look to have any use to a user, so I think it can be safe to remove. > > I'm 100% with all others, thanks for having a look. > On this one I can easily follow the argument of the fix for the newest release. > But for stable we can never really know if there are users. > In theory for anything that shipped in a Distribution someone might > have coded and linked something against it - we would not know. > The meant to be "stable" update will then break them the hard way. > > In this case gladly the function wasn't anything that one would > consider useful for use from outside, so I think it is ok. > > But still I wanted to make the point that in general a symbol: > 1. once released might be used and we can not never be sure if no one uses them > 2. even being EXPERIMENTAL, touching them too much in stable updates > means not-stable. Should we at least try to minimize the impact to > stable releases? Hiding symbols is mostly to enable future changes. I'm not sure there is a need for such patch in a stable release.