From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6273E1B19E for ; Thu, 5 Oct 2017 10:41:29 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 05 Oct 2017 01:41:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,480,1500966000"; d="scan'208";a="906987622" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.44]) ([10.237.220.44]) by FMSMGA003.fm.intel.com with ESMTP; 05 Oct 2017 01:41:27 -0700 To: santosh , dev@dpdk.org Cc: konstantin.ananyev@intel.com, jingjing.wu@intel.com, Nemanja Marjanovic , Rory Sexton References: <1507108515-186477-1-git-send-email-david.hunt@intel.com> <1507130720-48891-1-git-send-email-david.hunt@intel.com> <1507130720-48891-3-git-send-email-david.hunt@intel.com> <6743205e-e0ac-77a5-10f5-6bf91edc0bc4@caviumnetworks.com> From: "Hunt, David" Message-ID: <2303db38-ef51-c114-a8b6-568e4c5ca640@intel.com> Date: Thu, 5 Oct 2017 09:41:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6743205e-e0ac-77a5-10f5-6bf91edc0bc4@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 2/9] lib/librte_power: add extra msg type for policies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 08:41:30 -0000 Hi Santosh, On 4/10/2017 4:47 PM, santosh wrote: > Hi David, > > > On Wednesday 04 October 2017 08:55 PM, David Hunt wrote: >> Signed-off-by: Nemanja Marjanovic >> Signed-off-by: Rory Sexton >> Signed-off-by: David Hunt >> --- > Glad that ifdef clutter removed. > Few nits though.. > >> lib/librte_power/channel_commands.h | 42 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h >> index 484085b..020d9fe 100644 >> --- a/lib/librte_power/channel_commands.h >> +++ b/lib/librte_power/channel_commands.h >> @@ -46,6 +46,7 @@ extern "C" { >> /* Valid Commands */ >> #define CPU_POWER 1 >> #define CPU_POWER_CONNECT 2 >> +#define PKT_POLICY 3 >> >> /* CPU Power Command Scaling */ >> #define CPU_POWER_SCALE_UP 1 >> @@ -54,11 +55,52 @@ extern "C" { >> #define CPU_POWER_SCALE_MIN 4 >> #define CPU_POWER_ENABLE_TURBO 5 >> #define CPU_POWER_DISABLE_TURBO 6 >> +#define HOURS 24 >> + >> +#define MAX_VFS 10 >> + >> +#define MAX_VCPU_PER_VM 8 >> + >> +typedef enum {false, true} bool; >> + > do we really need typedef for bool; can't we simply > use bool data-type? Sure, will fix. >> +struct t_boost_status { >> + bool tbEnabled; >> +}; >> + >> +struct timer_profile { >> + int busy_hours[HOURS]; >> + int quiet_hours[HOURS]; >> + int hours_to_use_traffic_profile[HOURS]; >> +}; >> + >> +enum workload {HIGH, MEDIUM, LOW}; >> +enum policy_to_use { >> + TRAFFIC, >> + TIME, >> + WORKLOAD >> +}; >> + >> +struct traffic { >> + uint32_t min_packet_thresh; >> + uint32_t avg_max_packet_thresh; >> + uint32_t max_max_packet_thresh; >> +}; >> >> struct channel_packet { >> uint64_t resource_id; /**< core_num, device */ >> uint32_t unit; /**< scale down/up/min/max */ >> uint32_t command; /**< Power, IO, etc */ >> + char vm_name[32]; >> + > How about const char * Or in case not possible then #define RTE_xx 32 Or > use existing RTE_ for same purpose or some micro local to power lib. I'll change to use an existing RTE_xx. --snip-- Thanks, Dave.