From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
dpdk-dev <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Morten Brørup <mb@smartsharesystems.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Jerin Jacob <jerinj@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half
Date: Mon, 09 Nov 2020 13:59:49 +0100
Message-ID: <2304322.cEvxdTIR8G@thomas> (raw)
In-Reply-To: <CALBAE1Os91XN_MHiXjWUJL_o_pGjM6mkBfZzjE2tbAMFrjOapA@mail.gmail.com>
09/11/2020 13:01, Jerin Jacob:
> Hi @Thomas Monjalon
>
> Any specific reason why you removed the static assert from octeontx2.
I have a build failure when cross-compiling for octeontx2.
> I am not able to compilation issue with that static assert.
There is no issue when compiling for x86.
> The current vector driver assumes pool and tx offload needs to 2 DWORDS apart,
> Which is the case before and after your change.
You're right, pool and tx_offload are moved together.
The only difference is passing the cache line frontier.
> Please remove that static assert change, No issue from my side on this patch.
I cannot remove it without fixing something else,
maybe an issue in cache line alignment?
> In general, it is too much effort to re-verify and measure performance
> impact with
> all the cases after RC2, I hope this will last mbuf change in this release.
Yes it is the last change to mbuf layout,
sorry for pushing all these changes so late.
next prev parent reply other threads:[~2020-11-09 13:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 15:53 Thomas Monjalon
2020-11-07 17:12 ` Jerin Jacob
2020-11-07 18:39 ` Thomas Monjalon
2020-11-07 19:05 ` Jerin Jacob
2020-11-07 20:33 ` Thomas Monjalon
2020-11-09 5:18 ` Jerin Jacob
2020-11-09 8:04 ` Thomas Monjalon
2020-11-09 8:27 ` Jerin Jacob
2020-11-09 9:47 ` Bruce Richardson
2020-11-09 12:01 ` Jerin Jacob
2020-11-09 12:59 ` Thomas Monjalon [this message]
2020-11-09 13:35 ` Jerin Jacob
2020-11-09 14:02 ` Thomas Monjalon
2020-11-09 14:08 ` Jerin Jacob
2020-11-09 14:42 ` Thomas Monjalon
2020-11-09 14:53 ` Jerin Jacob
2020-11-09 8:16 ` Morten Brørup
2020-11-09 10:06 ` [dpdk-dev] [dpdk-techboard] " Bruce Richardson
2020-11-09 10:21 ` Morten Brørup
2020-11-09 18:04 ` Stephen Hemminger
2020-11-10 7:15 ` Morten Brørup
2020-11-07 18:57 ` [dpdk-dev] " Morten Brørup
2020-11-09 10:08 ` Bruce Richardson
2020-11-09 10:30 ` Morten Brørup
2020-11-09 10:33 ` Ananyev, Konstantin
2020-11-09 10:36 ` Bruce Richardson
2020-11-09 11:24 ` Ananyev, Konstantin
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 0/2] move mbuf pool pointer Thomas Monjalon
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build Thomas Monjalon
2020-11-10 18:05 ` Jerin Jacob
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half Thomas Monjalon
2020-11-10 10:05 ` Morten Brørup
2020-11-10 10:44 ` Thomas Monjalon
2020-11-10 16:25 ` Olivier Matz
2020-11-10 18:06 ` Jerin Jacob
2020-11-12 14:39 ` Thomas Monjalon
2020-11-10 18:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2304322.cEvxdTIR8G@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=mdr@ashroe.eu \
--cc=ndabilpuram@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git