From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DF8BE2BC7 for ; Sat, 15 Jul 2017 20:20:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8F350205FC; Sat, 15 Jul 2017 14:20:47 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 15 Jul 2017 14:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=2CnhE7bqpvn24+f 7nLfzij5sPJqrnlQUkJbEb0uaPEM=; b=Ij0XDO/H5U41l7/TZYPhJklQ3eb9HxB 99XC+kDrydEVT5JhLTVU7gHyLG+MtITuziRVf4mGC12GKhNy3Idt5FbB4uMibzgH qQZucV1xFG2oVR6mtj5Vfq8y9k9n/k24WoKWqNltQt062J4VBqcv/17ALgyIxknF 5lPWqshR3tVA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=2CnhE7bqpvn24+f7nLfzij5sPJqrnlQUkJbEb0uaPEM=; b=koYYa/Na nKtZEce86eccXYZvCNIbEYZQmMfgaoTuCyX4cl/5TA2i0Luz96UWrys0FZADSu5r V/AKpyFDTbQMzCgMEB+CBQFIHhtZCjbXJC+85IZPkbOHwiiy0QE3fZKE60WKyR76 Nj8ImGhKHiNnIg8Fr7wrgiYSh0eiL+6Ie9tGYMHw8W1als0navT8EItUC+UQGCVo 1luj45n/DFdetv8EKsL6YJ/vgtSUrvIso4Kgta+IsO6zn7wbw5szZ0gxQROVW7TT wGSib8zngnJH8/VfAJNeI8+GrvW1boj4QuhhEuWGp0ebAlYG2B9Py8hSaQKwsPl5 GEfk9rT/XldyKw== X-ME-Sender: X-Sasl-enc: AuGG68oPnzzFdDQ+khmjG6uWuSlHuEguoehx7KEHtoEh 1500142846 Received: from xps.localnet (220.41.136.77.rev.sfr.net [77.136.41.220]) by mail.messagingengine.com (Postfix) with ESMTPA id AE8DB7E312; Sat, 15 Jul 2017 14:20:46 -0400 (EDT) From: Thomas Monjalon To: Jan Blunck Cc: dev@dpdk.org Date: Sat, 15 Jul 2017 20:20:41 +0200 Message-ID: <2305334.OuEkxHkjai@xps> In-Reply-To: <20170714211213.34436-1-jblunck@infradead.org> References: <20170711232512.54641-1-jblunck@infradead.org> <20170714211213.34436-1-jblunck@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 00/15] devargs fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2017 18:20:49 -0000 14/07/2017 23:11, Jan Blunck: > The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking > API without prior notice. This series is reworking the rte_devargs changes > in a way hopefully compliant to the new failover PMD and still keeping API > compatible with earlier releases. > > The introduced changes to 17.08-rc1 are trading the tightly coupling of > struct rte_devargs to the PCI and vdev bus against the struct rte_bus. > The changes proposed in this series decouple struct rte_devargs from > the new dependencies. > > Changes since v1: > - explicitly pass busname to rte_eal_devargs_parse() and validate it > - better explain why changes are done Most of these changes does not seem to fix a bug or an API break. Before -rc1, we can take them for the sake of cleaning. But after -rc1, we must take only fixes. If I understand well, the urgent fix to make in -rc2 is to revert an API break without prior notice. Which change is it? rte_devtype? The plan is to fix hotplug/devargs while integrating failsafe in -rc2. After releasing -rc2, we must agree on the planned clean-up and be sure that the right deprecation notices are in 17.08. Then we will integrate all these patches in August for 17.11.