DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wiles, Roger Keith" <keith.wiles@windriver.com>
To: "RICHARDSON, BRUCE" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue
Date: Tue, 30 Sep 2014 13:46:22 +0000	[thread overview]
Message-ID: <2306E3D2-B159-42B0-AA59-3B3400E9A2A6@windriver.com> (raw)
In-Reply-To: <1412070008-4782-1-git-send-email-bruce.richardson@intel.com>

Acked-by: Keith Wiles <keith.wiles@windiver.com>

On Sep 30, 2014, at 4:40 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:

> Issue reported by Keith Wiles.
> Clang fails with an error about a variable being used uninitialized:
> 
>  CC ixgbe_rxtx_vec.o
> /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:67:30:
> error: variable 'dma_addr0' is uninitialized
>      when used here [-Werror,-Wuninitialized]
>                        dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
>                                                  ^~~~~~~~~
> 
> This error can be fixed by replacing the call to xor which
> takes two parameters, by a call to setzero, which does not take any.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> index 457f267..2236250 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> @@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq)
> 				 RTE_IXGBE_RXQ_REARM_THRESH) < 0) {
> 		if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >=
> 		    rxq->nb_rx_desc) {
> -			dma_addr0 = _mm_xor_si128(dma_addr0, dma_addr0);
> +			dma_addr0 = _mm_setzero_si128();
> 			for (i = 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) {
> 				rxep[i].mbuf = &rxq->fake_mbuf;
> 				_mm_store_si128((__m128i *)&rxdp[i].read,
> -- 
> 1.9.3
> 

Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533

  reply	other threads:[~2014-09-30 13:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-29 21:50 [dpdk-dev] Building current 1.8.1-rc1 with clang Wiles, Roger Keith
2014-09-30  9:34 ` Bruce Richardson
2014-09-30  9:40 ` [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue Bruce Richardson
2014-09-30 13:46   ` Wiles, Roger Keith [this message]
2014-09-30 17:14     ` Thomas Monjalon
2014-10-22 10:54 Bruce Richardson
2014-10-22 10:55 ` Richardson, Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2306E3D2-B159-42B0-AA59-3B3400E9A2A6@windriver.com \
    --to=keith.wiles@windriver.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).