From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id 4D1986A8B for ; Tue, 30 Sep 2014 15:39:43 +0200 (CEST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id s8UDkM8H022639 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Tue, 30 Sep 2014 06:46:22 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.18]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0174.001; Tue, 30 Sep 2014 06:46:22 -0700 From: "Wiles, Roger Keith" To: "RICHARDSON, BRUCE" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue Thread-Index: AQHP3JLX+aJY1coPSEOOSPoLB9CZhJwaJgiA Date: Tue, 30 Sep 2014 13:46:22 +0000 Message-ID: <2306E3D2-B159-42B0-AA59-3B3400E9A2A6@windriver.com> References: <1412070008-4782-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1412070008-4782-1-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.40.166] Content-Type: text/plain; charset="us-ascii" Content-ID: <394DDC6A8D6B4842A4809E1C55EF1981@local> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix clang compilation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2014 13:39:43 -0000 Acked-by: Keith Wiles On Sep 30, 2014, at 4:40 AM, Bruce Richardson = wrote: > Issue reported by Keith Wiles. > Clang fails with an error about a variable being used uninitialized: >=20 > CC ixgbe_rxtx_vec.o > /home/keithw/projects/dpdk-code/org-dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx_= vec.c:67:30: > error: variable 'dma_addr0' is uninitialized > when used here [-Werror,-Wuninitialized] > dma_addr0 =3D _mm_xor_si128(dma_addr0, dma_addr0); > ^~~~~~~~~ >=20 > This error can be fixed by replacing the call to xor which > takes two parameters, by a call to setzero, which does not take any. >=20 > Signed-off-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe= /ixgbe_rxtx_vec.c > index 457f267..2236250 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > @@ -64,7 +64,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq) > RTE_IXGBE_RXQ_REARM_THRESH) < 0) { > if (rxq->rxrearm_nb + RTE_IXGBE_RXQ_REARM_THRESH >=3D > rxq->nb_rx_desc) { > - dma_addr0 =3D _mm_xor_si128(dma_addr0, dma_addr0); > + dma_addr0 =3D _mm_setzero_si128(); > for (i =3D 0; i < RTE_IXGBE_DESCS_PER_LOOP; i++) { > rxep[i].mbuf =3D &rxq->fake_mbuf; > _mm_store_si128((__m128i *)&rxdp[i].read, > --=20 > 1.9.3 >=20 Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533