From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57838A00C5; Tue, 15 Feb 2022 14:01:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49F414113F; Tue, 15 Feb 2022 14:01:45 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 14D454115C for ; Tue, 15 Feb 2022 14:01:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644930104; x=1676466104; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=9wekjtelH62bZzy/+z29hpr6LXmmoJ9TMzuVg/tcF3g=; b=T1Qb7ItEBF0FYrQIXocnI3BCOrIu5zhrlUxMliJQVaBnpwrNpUlucMsc 5EQMpx4tpKhyZgIQaFuJbvKcHcLEKY98dnOiGeBfj+NRgnfbRKaXpkyL0 e8vhqTBOoSYV7hbs9hODfumcdo937pd5bCm3JUA49HZclk6E8pvgyBuXa Dl95rkHLcZPFCc6BwFHq6U2KKl2ehguXfPHMc40qm65vVEreEyV2GwJl+ Bmk4PXrxLYsK+peKYVPB/0enbl8LV/nD+IJJcKZzPfy5ojXN03fE0KrkE z2mSMcEdrY7r57x4+1FCaq3ts8ba88vhOvsHrkFDt+eOEmQb8lB6cJ10e w==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="313620104" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="313620104" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 05:01:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="775826448" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 15 Feb 2022 05:01:42 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 05:01:42 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 05:01:42 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 05:01:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 05:01:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k9h0xZ7mO5llQZxYIY0WR362jQ1mLdkTRnPwppBGbs76Dh5dEF0p98d/9u93kyp7o8GDYttxW5ghN2fej5o14TXE8TLnWxnHXNxDNd4um2pmyRskJYTpNuPcm+yc7pPSJ3FAU4UOfUsZo6tcxD1Rqx/HBtYCiFmiMObBbsj4nhKNTPvzM2N5G4Af5fryta6QL8kFh+xaYA5HWuTl2gvOtIKppfsWZDQ/rl7P+siCWhlcj85rTherbNGBHsguzZmPlMkzKOn6++5Xhh9/Hq6lLTWpB5bBd2L9Bp1uDIYtLyXikfezh/OR7NcH3XaUhxmedCxjbxe4+ZN+Nz6j7UxfpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IpYtN5Cyvnysrn8RXPcvcSoYwwLzUq4JeIadEGU+UFc=; b=bwTi5TG89374Z12GpU6XWvsKY7jjcP8pONHv3j2LXl9xkpnBiM4VQ+7p24m2hCBih+UYaRm4GgVy6Dgq7vVQxgd+4LN/DXLM1t8yikfOJS95dw1guJD/qYs2t9QT1qoKA5ZoCrRxj21MIz/DHccM98u7LLzs13gCTTyMS69lboOpHqT30kmmICrGNZXaaTou0h6alTUHU/SVsVqYnqzewO/ysC+yfoSfm7xxwD1wKrEMcF+bqS7giWuPoTZWtbpsWVsn+AlVUxN+LrkqpANvHnJ2G6a0IHHNwpxGruE6jfPELwsfubB4J0KI4jSOa6cbUZRwfu6WcWVOWCYcJkXNhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CO6PR11MB5649.namprd11.prod.outlook.com (2603:10b6:5:35b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb 2022 13:01:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 13:01:40 +0000 Message-ID: <2307b3b6-5129-446c-f062-db0a84fe2f63@intel.com> Date: Tue, 15 Feb 2022 13:01:34 +0000 Content-Language: en-US To: John Daley , CC: , Hyong Youb Kim References: <20220214204610.14921-1-johndale@cisco.com> From: Ferruh Yigit Subject: Re: [PATCH] net/enic: fix dereference before null check X-User: ferruhy In-Reply-To: <20220214204610.14921-1-johndale@cisco.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0059.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe58326d-7d6d-47c7-2de7-08d9f0834e9e X-MS-TrafficTypeDiagnostic: CO6PR11MB5649:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d98gfV8IakgrYbP0TzM3sKiwrqoGQVtapGqbxgtJ/Q/aeGaIOvsVZRVMxqXOkwmcRMRTjLy8lX/ZK3Oy8yXhXNmKon/9dHEoAVZyaZK4QSSdt+7H0UBEKkM4/4n75uMUbDK1FpxXekh4YShb4L68qMboYL1pqi315dWfIzjj6b/r+LacgQkhPHKwTCg57ITMCkxlT3OkkGyvfpqZu94Y97raeVoyHZTf4uzL0ymcQjFFpLu6Z3pINWpKGr5b5WQWHKAQY98aGo1+aNPot7CReSIy0kc8BxoyRZDn5qOX15QP7GXsiApDHa2XwSl8n3ebvE++9djolZn5tE7SUk1nh9hE9Wx+35Bu1+BkYiV6SfEhURI3r+Zdj9jz/Rq/83bOzNMKyvOPlxxjwQcAdKMNmaM/Jk17eBXkewak0pRotmroM/+pXif7TT2Ky/v7ZKThj1L8TEaTtZvc+tGKGE41QtEmA/6ZnzV88YYzUc4JXZ7rtPY3WjCPQiHUqJGLPs6i7Je+8FdfA8afHSBGrSQCgBbSsvgFHXuvzo0YupWr50J7twXp38GzRz2V0Oi0qMCoRlV9fu4vxbT0Xe05Oied4HR/BO/hXgpWjxEgxdkrcWTwIov3KdGhsDxylJzInUzndf/6656cXCMt/obY4Rj17oX59O5sLKKvP6DK8QsdmfRe8wNFpvUTnBFv260Ji2USnsTeNJ4m8ShxYqTQa3Vhzw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(2616005)(26005)(31686004)(186003)(86362001)(2906002)(4744005)(44832011)(36756003)(6506007)(8936002)(82960400001)(66556008)(66476007)(4326008)(8676002)(66946007)(31696002)(508600001)(6486002)(53546011)(6512007)(316002)(6666004)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0gvdVZWc3ZMMVBNdDZuOG85VTB5S3ZoZzBUUzdCcDE3Smo2NFI1K1FHRDFn?= =?utf-8?B?WmJsOXZBK0Q0dXl0c0lvbFFkQUc2YWRoaURhUWNMb3JXMUNJUExVVGpYYzBp?= =?utf-8?B?WXZ1QmQ4NnNmL21oSUZBSXdoTlpGWnQrbUZtTHBIbFo1alJqSTl0ZEhKa1d1?= =?utf-8?B?SXRUU2NrMWVtQUpjMmI2M0tBL3BvdUZ1OTlKcFlqQUVJbkJCMXFsbll1VFRp?= =?utf-8?B?cWdLbm5NZVhNNFdRMGZVK2hkcWVNcUliZkVKU1VjVnkxMzBHWlR0ZnJSczY1?= =?utf-8?B?L3JwVXJHR3dXR0RlZmJLbzVscFVsazU4b3pLMGcyQWMvWFNLcE50Qmh0anVZ?= =?utf-8?B?dVppK1g0TktOeURoWFFvb0t1ZDBVRlNydVNhRkZiVklVbnBQUFR4ak9CT0hE?= =?utf-8?B?dUhrV3JBYTd0anV4b1NMWTVZbWJHangvZG5LemlVK1JEVDNjQWxtdVpFNXVm?= =?utf-8?B?cFA2ZmVYaEY2Y0gyWGViekNuNG1yYWNuRkFjQlNtY1p6ZThKZkVyTDR5b1h2?= =?utf-8?B?RUhhVzNXdFE2cEFCOS80eWV2bnQxRWpxZlg2SytyT2hoUS9QQW9iVWMxVWZv?= =?utf-8?B?QmppS0VRZTYzZjZzVUpmSUV0THVyZXRFWHV4anE2YjQ1NXlWczBlRmFIT3ow?= =?utf-8?B?d3c2dVA3RUlwVk0zMDZIejRpMVUrdXBjS1lnVUV5WXpIay9PM3FXcHhkWVow?= =?utf-8?B?R2t1T1ViUk45QWIxcDc3enVCeVlzcU9uSTdReFNNc0ZBVjdqbHBzUGFRR0w4?= =?utf-8?B?OWlGS1c0OE0zdHpWK1Zac2JET0x5K1VNTEV5UjJWSFlDZ3o5ZWNCZG1sOCt6?= =?utf-8?B?OG9aTnhnVlIwUU9Id1FOY2F0cE9JZlZ4eWdORFZ3Z1ZMR05JSTRmYm5yamJ1?= =?utf-8?B?eVVhTWtQeVJPbU1SZjUrZGZPcTI3eXBwL0FuUUdQUjh6UWlQbWZsSkt2aXFT?= =?utf-8?B?YWRwT2pIRU1oTy9JcUJ2ZGFEVmhWSmI5Nzh1T2kyU3J5emNXa3FJUUloenQ4?= =?utf-8?B?UWNrbE1nZWZSMnJkdGJBK1JTcEZDalorZGd3M2ZSTFBSeHZsb3hvSE1NVWp5?= =?utf-8?B?TFhXeHo3RUFYbzE4MFEzT3NEUmcvR29TcFAwK09QZ1lQYWtSODd1SGswNWZG?= =?utf-8?B?bmN6dzNTNTA3ZWVoK3l0eVhqV1BEV2RXSEgwNFBOclpKR1ZsMUFNY3N6TmYx?= =?utf-8?B?U2ltRWVhWTUwZFUxc0VranNJUW1JQ1FVRUhiY2ZPa1BnRlRPMVZVbnhGd3NH?= =?utf-8?B?OTR2b0JCeEtHVEROdzc5QWRzVk9wTysrT0JHR1kxa2VaNlpVa0p0a09tc21W?= =?utf-8?B?c2U0UloyMHZPVnhXaGZER0x4RE93ajBpa1VVVHU5T08vSVprdytoR0VIeXhv?= =?utf-8?B?L1pnTmlXZENsb0hKTjNxTHAyQVUrUy83UTN1YnBsSFMrWjgxd3pteVkveE14?= =?utf-8?B?V0JsQkVxNUdIR2xZR1NnRk5odjdabU9GZ3VlbnRtWlpFYnRhSVBWQlpkZGpE?= =?utf-8?B?VzNwWFhjWXpLTHpoVVlNYnU2YUQ1eVFxOVg4SjR4QTNOZXdGeE5XR3FOWVdT?= =?utf-8?B?bVowcjBodlNQOG1GWGY2bGdYRzR4cDdnZzN1d2VEZnBzejB3UWtCalRrdmp3?= =?utf-8?B?Z25Lc24vOGxBdkpzQlNkcklPWWkzUFhWM3QyblQwdCtuS1VGQ3J6c1d2ckFw?= =?utf-8?B?bGJtY0R4T2xySlhJSDUzdWZidkFMSndqWWxkZFpFcFl5Znp4Mkt4OEpNNlNx?= =?utf-8?B?cmZPTEd5V1N3bm4xSTVOUlRaK1hwa25BVUkwR0FXZUpveUJKZkQ2bTE5NTRE?= =?utf-8?B?alhOWEhUaVI2a3NkWWJ0Q1VGU0xDMFZSLzdqWWRXMEg2OUM1VE0vVnVWNUV2?= =?utf-8?B?MEM0WjVNM2V0VGtEZFJkaXduNVp0SzJ1Y2VhRnF3ZkhJbjU5czJoKzVzWGpG?= =?utf-8?B?cG8wbG1wb1hZOXNUTVdsMGNSZDhRZldBZzVGRnRtWUtjQUtPS0d6SUlIeXh0?= =?utf-8?B?UXZkbEUxa1hxK0R6eEg5b1M4SjVOV3B0c3dpRkVSZnpHdWNXVXNjZUNSRmRI?= =?utf-8?B?eis4MkdnTnp0dEtPOFNOaWI0NE5mZXZGZEZaNHZpWi93QmVOQS9lSUtrT3dr?= =?utf-8?B?Z013ZVg3bGZrditGZGo2YTZNRHpYayt4SXYwYzJmVy9peDhnMTk5UVUrb1JJ?= =?utf-8?Q?cO42rtkzHz2pvFlXgQpSRX8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fe58326d-7d6d-47c7-2de7-08d9f0834e9e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 13:01:40.2641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bUpO/B1RZYyz7HC4VfeuN78Qo7O30q1mf4zXcCeDYACrk8xSOwFNkL5rcDYCSVR+KbDotoewsNz1OHyFijO/Bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5649 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2022 8:46 PM, John Daley wrote: > This patch fixes an issue found by coverity. It checks for a possible > null value of "error" before dereferencing it. > > CID: 375064: Dereference after null check > Either the check against null is unnecessary, or there may be a null > pointer dereference. > > Coverity issue: 375064 > Fixes: ee806eea59fe ("net/enic: support GENEVE flow item") > > Signed-off-by: John Daley > Reviewed-by: Hyong Youb Kim Applied to dpdk-next-net/main, thanks.