From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir
Date: Tue, 29 Jan 2019 12:40:37 +0100 [thread overview]
Message-ID: <2309208.nfQRyMXgnH@xps> (raw)
In-Reply-To: <20190125203019.GA57044@bricha3-MOBL.ger.corp.intel.com>
25/01/2019 21:30, Bruce Richardson:
> On Fri, Jan 25, 2019 at 08:26:38PM +0000, Bruce Richardson wrote:
> > The apps for testing are split between the "test" and "app" directories,
> > with a not-very-clear distinction between the two (at least to my mind).
> >
> > Given how the apps are being built, the easiest path to having
> > cmdline_test, test-acl and test-pipeline build using meson is to
> > consolidate all these apps back into the app folder and use the logic
> > there. The bpf folder doesn't contain an actual application, but
> > rather example bpf code which can be loaded into testpmd. That is
> > possibly best moved to the examples folder, but I'm open to feedback
> > on the best place for it.
> >
> > With these changes, the "test" folder then becomes the location for
> > unit tests only.
> >
> >
> > Bruce Richardson (4):
> > test/cmdline_test: move to app directory
> > test/test-acl: move to app directory
> > test/test-pipeline: move to app directory
> > test/bpf: move to examples folder
> >
>
> Although these patches are for 19.05, I'm sending them now for some early
> review, as I think we need a deprecation notice for this change in 19.02 if
> these changes are acceptable to people.
We don't need a deprecation notice, as it is an internal change
without any impact for the users.
> Therefore, please review and let me know any issues people see with this
> change.
We should move all test apps into the same directory.
Is there any benefit of keeping unit tests separate?
It looks more logic to move everything in test/
but it would make the git history of testpmd more complex.
The other choice is to move all tests in app/.
The other split to discuss is between app/ and usertools/.
We could move user-oriented apps to usertools.
pdump and proc-info fall into this basket because they
can be used for debugging purpose.
next prev parent reply other threads:[~2019-01-29 11:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 20:26 Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 1/4] test/cmdline_test: move to app directory Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 2/4] test/test-acl: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 3/4] test/test-pipeline: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 4/4] test/bpf: move to examples folder Bruce Richardson
2019-01-25 20:30 ` [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir Bruce Richardson
2019-01-29 11:40 ` Thomas Monjalon [this message]
2019-01-29 11:52 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 0/5] " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 9:14 ` Thomas Monjalon
2019-02-26 10:00 ` Bruce Richardson
2019-02-26 11:24 ` Bruce Richardson
2019-02-26 12:20 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 2/5] test/test-acl: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 3/5] test/test-pipeline: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-20 9:35 ` Ananyev, Konstantin
2019-02-20 9:39 ` Bruce Richardson
2019-02-20 9:42 ` Ananyev, Konstantin
2019-02-20 10:35 ` Thomas Monjalon
2019-02-25 16:22 ` Ananyev, Konstantin
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 5/5] test/test: move to app folder Bruce Richardson
2019-02-20 11:47 ` [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir Ferruh Yigit
2019-02-25 15:34 ` Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 2/5] test/test-acl: " Bruce Richardson
2019-02-26 12:27 ` Ananyev, Konstantin
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 3/5] test/test-pipeline: " Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 5/5] test/test: move to app folder Bruce Richardson
2019-02-26 14:40 ` [dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2309208.nfQRyMXgnH@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).