* [dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode
@ 2018-05-02 15:28 Adrien Mazarguil
2018-05-02 17:12 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Adrien Mazarguil @ 2018-05-02 15:28 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: dev
Since the commit referenced below, compiling mlx4 along with its glue
library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation
failure due to undefined symbols.
They are caused by Verbs calls made directly from the PMD instead of going
through the glue library.
Fixes: ffc7411cabfe ("net/mlx4: fix inner RSS support for broken kernels")
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx4/mlx4.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index c1cc95786..47451b651 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -469,14 +469,14 @@ mlx4_hw_rss_sup(struct ibv_context *ctx, struct ibv_pd *pd,
" quirk");
hw_rss_sup &= ~IBV_RX_HASH_INNER;
} else {
- claim_zero(ibv_destroy_qp(qp));
+ claim_zero(mlx4_glue->destroy_qp(qp));
}
if (ind)
- claim_zero(ibv_destroy_rwq_ind_table(ind));
+ claim_zero(mlx4_glue->destroy_rwq_ind_table(ind));
if (wq)
- claim_zero(ibv_destroy_wq(wq));
+ claim_zero(mlx4_glue->destroy_wq(wq));
if (cq)
- claim_zero(ibv_destroy_cq(cq));
+ claim_zero(mlx4_glue->destroy_cq(cq));
return hw_rss_sup;
}
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode
2018-05-02 15:28 [dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode Adrien Mazarguil
@ 2018-05-02 17:12 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-05-02 17:12 UTC (permalink / raw)
To: Adrien Mazarguil, Shahaf Shuler; +Cc: dev
On 5/2/2018 4:28 PM, Adrien Mazarguil wrote:
> Since the commit referenced below, compiling mlx4 along with its glue
> library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation
> failure due to undefined symbols.
>
> They are caused by Verbs calls made directly from the PMD instead of going
> through the glue library.
>
> Fixes: ffc7411cabfe ("net/mlx4: fix inner RSS support for broken kernels")
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-02 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 15:28 [dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode Adrien Mazarguil
2018-05-02 17:12 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).