From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53E6E41DF6; Mon, 6 Mar 2023 20:50:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFD7740EDB; Mon, 6 Mar 2023 20:50:15 +0100 (CET) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by mails.dpdk.org (Postfix) with ESMTP id EB55140A8A for ; Mon, 6 Mar 2023 20:50:13 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 4BEE22B06951; Mon, 6 Mar 2023 14:50:08 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 06 Mar 2023 14:50:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678132207; x=1678139407; bh=XClihmJ3/DQCGMbegYfUDyOFAzQ5h3xBGdY JyNL5bFA=; b=F1/YcJR//flHWDvK+ZTfPzY6LTuhDDYiV7qAyRGdXRvWcRSZKNO RnopAkOjwv1Z+YNOe+9gXraxWwen9FSKsQfF2HJIo4kIFzByBJrjcWMdE5qvQ8ON wdAWBtytklA/aZCYolCh1H2wl3bz9sYDAnexjbHcG3HEBzDAbv5dha08w4O6l6ZX NhOJeskNmWvtqMZJvWwHwZe7/Z75F+wzDgkOqf23+Qp0jXsAbhTjP1VylDtHOmA2 Z5KxqwM9fShLnzgxYgcGdos+7822Vpto72SBcrtSwQbZAyaWr4m7sBmXKYdZ45Eh 13x7Mk9ArR8/dCWAa4Sg185Lj6nsFUg7dPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678132207; x=1678139407; bh=XClihmJ3/DQCGMbegYfUDyOFAzQ5h3xBGdY JyNL5bFA=; b=LNXrOyYsooG6Z1Ro3ticpr0PVJyiEEixbZ0v8USRdxtzHs4R+LP ru3pOdvDcE3nVhL9C7kT7tjIvGl75xs3xj54IknORc3MOSH4v31q12zgONSgsqEq RZS/2HanlPOPaQ5xYF8Y9+tsfZaXGWkLl9ox1LBHmCr+bhQoYGqrTT4R9c0zlRk3 sRF4pnpwQ2x5prnV3QQhF/gi9pHaN2f17tTXz/84wm856DXAMkBnbxFCVisHeCPZ 3Z6EVOCQBmpJjTycv1rZfVn7Xv/aW+8ZjTgGRwEXuicZJGqboh92KOzK5KbCFJxW U2gwNvi3nYRt2UodfAu3c4IJfQ6RhdOJDeg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtkedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Mar 2023 14:50:01 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, David Marchand , Qi Zhang , Morten =?ISO-8859-1?Q?Br=F8rup?= , Shijith Thotton , Olivier Matz , Ruifeng Wang , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jingjing Wu , Beilei Xing , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Kai Ji , Pablo de Lara , Radha Mohan Chintakuntla , Veerasenareddy Burru , Chengwen Feng , Kevin Laatz , Pavan Nikhilesh , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Liang Ma , Peter Mccarthy , Jerin Jacob , Harry van Haaren , "Artem V. Andreev" , Andrew Rybchenko , Ashwin Sekhar T K , "John W. Linville" , Ciara Loftus , Chas Williams , "Min Hu (Connor)" , Gaetan Rivet , Dongdong Liu , Yisen Zhuang , Konstantin Ananyev , Qiming Yang , Jakub Grajciar , Tetsuya Mukawa , Jakub Palider , Tomasz Duszynski , Sachin Saxena , Hemant Agrawal Subject: Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf Date: Mon, 06 Mar 2023 20:49:57 +0100 Message-ID: <2310221.1SvkZsmPdQ@thomas> In-Reply-To: References: <20230219115529.3260580-1-thomas@monjalon.net> <20230306161328.3802696-2-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/03/2023 17:39, Bruce Richardson: > On Mon, Mar 06, 2023 at 05:13:27PM +0100, Thomas Monjalon wrote: > > - if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path) > > + if not get_option('enable_iova_as_pa') and require_iova_in_mbuf and not always_enable.contains(drv_path) > > I don't particularly like the always_enable check at the end. If a driver > is set to always-enable and it doesn't support the configured mode, we > should throw an error immediately IMHO, rather than silently continuing to > build the driver. We can think about the "forced enabling" as a developer test. But the developer could change the meson file to enable it. So I'm OK to replace it with an error. > > build = false > > - reason = 'driver does not support disabling IOVA as PA mode' > > + reason = 'requires IOVA in mbuf' > > endif > > I think the reason given is more accurate, but for those users not familiar > with the internals of DPDK builds it could be confusing. I think the > message needs to reference the 'enable_iova_as_pa' option. How about? > > reason = 'requires IOVA in mbuf (set enable_iova_as_pa option)' OK good