From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Markos Chandras <mchandras@suse.de>
Cc: dev@dpdk.org, Nirmoy Das <ndas@suse.de>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
Remy Horton <remy.horton@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary
Date: Tue, 04 Apr 2017 12:15:14 +0200 [thread overview]
Message-ID: <2310633.U6SXsHI9VC@xps13> (raw)
In-Reply-To: <1762973.YT1Za91pN5@xps13>
Ping
2017-03-09 21:13, Thomas Monjalon:
> 2017-02-16 16:17, Markos Chandras:
> > The librte_ethtool library depends on librte_pmd_ixgbe if that
> > pmd driver is enabled so we need to link against it when we compile
> > the ethtool application. It fixes the following build problem:
> >
> > /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-linux/bin/ld:
> > warning: librte_pmd_ixgbe.so.1, needed by /home/abuild/rpmbuild/BUILD/
> > dpdk-17.02/examples/ethtool/lib/x86_64-native-linuxapp-gcc/lib/
> > librte_ethtool.so, not found (try using -rpath or -rpath-link)
> > /home/abuild/rpmbuild/BUILD/dpdk-17.02/examples/ethtool/lib/
> > x86_64-native-linuxapp-gcc/lib/librte_ethtool.so: undefined reference to
> > `rte_pmd_ixgbe_set_vf_rxmode@DPDK_17.02'
> > collect2: error: ld returned 1 exit status
>
> We may add this line:
> Fixes: 077d223e25c3 ("examples/ethtool: use ixgbe public function")
>
> > Cc: Nirmoy Das <ndas@suse.de>
> > Signed-off-by: Markos Chandras <mchandras@suse.de>
> [...]
> > --- a/examples/ethtool/ethtool-app/Makefile
> > +++ b/examples/ethtool/ethtool-app/Makefile
> > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> > +LDLIBS += -lrte_pmd_ixgbe
> > +endif
>
> Please, could you confirm we can remove the same LDLIBS line from
> examples/ethtool/lib/Makefile ?
next prev parent reply other threads:[~2017-04-04 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:17 Markos Chandras
2017-02-17 16:11 ` Remy Horton
2017-02-17 16:27 ` Markos Chandras
2017-02-20 14:06 ` Remy Horton
2017-04-07 13:15 ` Timothy M. Redaelli
2017-02-20 14:06 ` Remy Horton
2017-03-09 20:13 ` Thomas Monjalon
2017-04-04 10:15 ` Thomas Monjalon [this message]
2017-04-04 11:12 ` Remy Horton
2017-05-01 20:10 ` [dpdk-dev] [PATCH v2] examples/ethtool: fix link with ixgbe shared lib Thomas Monjalon
2017-05-01 20:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2310633.U6SXsHI9VC@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=mchandras@suse.de \
--cc=ndas@suse.de \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).