From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 19C3C326C for ; Tue, 4 Apr 2017 12:15:17 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id k6so203002321wre.2 for ; Tue, 04 Apr 2017 03:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=O1bCqCO2NXeQENPjClAFTGrUBIKcLQoDe/p6qzCFidE=; b=LhD5KFA9mtG28qicYEzJzYl+XUIXj2Ww9YcnPzfu0b+BtWLVS92vbtM+9fSxdCWVX4 5zbfoJOwSaltNOZakcq1wp2JPV/t5UkLdpDt7Uq/+VqDQRcj+v0ANO5PPPm1PQOQsrhJ /kV1HgCczORwIarFDyDIz++FPjaz0l+7HeMY2f7L6z49w5uenTrStCco48yixniVxj+X +haVGJTLk5O9lkYVbR9JPz0aD/VLC+Ma+m9kArC9grdIeTF0BoyeZeksKB8cxhfzyIki GacSX8VewZmkXpVVWZTOMQ2/1TT+P+jNMr53sa8+JNgFA2fkiPgRdas0vd1QeIsBxOUD F3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=O1bCqCO2NXeQENPjClAFTGrUBIKcLQoDe/p6qzCFidE=; b=RZi+OHv0T2TvEZQdklDtwGHyAcO7m+V7TGszGC0U075ujIjRyVljqmVrkdYLuWZA68 8XS0VQCiz5V/9Oyeb4D2AuIV1RlQoSP+YHhkYZc54ztLn/vbyFDIXpTzrS30AY/ho1Fl 2kRvml09frgvXrU7syJxRXYdBY4zox8ijE6dwbWCJ5AbV71HIybYc2YPtH5mmJXZvb8Y 1R+woNuv7J8smHU2cDaOF8s5u64koUhiJqrMi7q/e9UP/IKPdhZQSOKCPVPOJkGUUqgm tUj0qOpcCvwwTbphG0K8XMXlW1XEokZdb3m8wUooW5fq9obFSHh2VY7FTGg/NaQ7zE1F 91Lw== X-Gm-Message-State: AFeK/H2PjwlIU4rgJKvlytI9pdesDuIL3l4CaY4xBKnwdn410gOzzPWU7qhup+9klqzKJGPy X-Received: by 10.223.146.164 with SMTP id 33mr19491324wrn.17.1491300916473; Tue, 04 Apr 2017 03:15:16 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a18sm21677839wrc.58.2017.04.04.03.15.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 03:15:15 -0700 (PDT) From: Thomas Monjalon To: Markos Chandras Cc: dev@dpdk.org, Nirmoy Das , "Iremonger, Bernard" , Remy Horton Date: Tue, 04 Apr 2017 12:15:14 +0200 Message-ID: <2310633.U6SXsHI9VC@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1762973.YT1Za91pN5@xps13> References: <20170216161731.4590-1-mchandras@suse.de> <1762973.YT1Za91pN5@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 10:15:17 -0000 Ping 2017-03-09 21:13, Thomas Monjalon: > 2017-02-16 16:17, Markos Chandras: > > The librte_ethtool library depends on librte_pmd_ixgbe if that > > pmd driver is enabled so we need to link against it when we compile > > the ethtool application. It fixes the following build problem: > > > > /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-linux/bin/ld: > > warning: librte_pmd_ixgbe.so.1, needed by /home/abuild/rpmbuild/BUILD/ > > dpdk-17.02/examples/ethtool/lib/x86_64-native-linuxapp-gcc/lib/ > > librte_ethtool.so, not found (try using -rpath or -rpath-link) > > /home/abuild/rpmbuild/BUILD/dpdk-17.02/examples/ethtool/lib/ > > x86_64-native-linuxapp-gcc/lib/librte_ethtool.so: undefined reference to > > `rte_pmd_ixgbe_set_vf_rxmode@DPDK_17.02' > > collect2: error: ld returned 1 exit status > > We may add this line: > Fixes: 077d223e25c3 ("examples/ethtool: use ixgbe public function") > > > Cc: Nirmoy Das > > Signed-off-by: Markos Chandras > [...] > > --- a/examples/ethtool/ethtool-app/Makefile > > +++ b/examples/ethtool/ethtool-app/Makefile > > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > +LDLIBS += -lrte_pmd_ixgbe > > +endif > > Please, could you confirm we can remove the same LDLIBS line from > examples/ethtool/lib/Makefile ?