From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 536071B86F
 for <dev@dpdk.org>; Sun, 13 May 2018 23:37:32 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B93B725C16;
 Sun, 13 May 2018 17:37:31 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 13 May 2018 17:37:31 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=PQ3VVUa4PbopibJAIxhd6rYO7x
 JrndlL1nWThH/wuUo=; b=XhjZJhCvMCYJ6UgQ60CtbusLr8S6Bzrvjxf/NmK4WP
 ByW7Tq00xW/RMJZp9nyfyIGlxumXqo7dRIAVa5J1KKBFbdSr7UIJfqVudx5lTo/T
 DI+uKC15zRodgZPWc9QZeyt37TDjBfeuQ5XFvc0Xz7RuYp3HNA4HxDXUlZ1ul3ga
 Y=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=PQ3VVU
 a4PbopibJAIxhd6rYO7xJrndlL1nWThH/wuUo=; b=iQjJWkuJhhR6h3X1AO4c5t
 cWM2ZHEjvzNDWqASAjwx/+VK19Xd+liSXGSzxLsiBrJOW0Hz2wOZn7KKbGudqVGR
 cTf9+qgsQFkuFzuQSE3JjQI1Fz8J3a2ByuGI7B9jyTPyzlHXDKxzOaI8LroR1CQK
 y3s+h3cPe9q0Ewz3mmlbi+MnZnPhV/Z+d952Y2/bjJWw8spSGKema+kk5klgObGq
 xqCuna9wZ8/9XCA0aidLm03ZP9gElXej5i62PK2X5/C0Z2/Cse3F6vRLajngjMot
 io7kK8AoWBZ12VPMVSECwCOtyMytcKDcXRV1HM9SOsJDd92R922hQc5UKNeclm/Q
 ==
X-ME-Sender: <xms:G7D4WmJkOnk2GXmfLi6_QDM5n1drP_rqd1B0yu1gHNucM7zXMPUTJw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E8642E444A;
 Sun, 13 May 2018 17:37:30 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com
Date: Sun, 13 May 2018 23:37:29 +0200
Message-ID: <2310860.D1JZ3WaQXe@xps>
In-Reply-To: <20180510053112.25491-1-david.hunt@intel.com>
References: <20180510053112.25491-1-david.hunt@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] examples: fix typdef in performance thread
	app
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2018 21:37:32 -0000

10/05/2018 07:31, David Hunt:
> The function pthread_create() expects void *(*func) (void *)
> for function pointer, however, lthread_func_t was defined as
> void (*func) (void *), so now gcc 8.1 warns that the cast is
> incorrect, causing a compilation failure. This patch changes
> the declaration of lthread_func_t from returning a void to
> returning a void*, and then changes the sample app in the
> relevant places that are affected by the typedef change.
> 
> Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem")
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
[...]
> -static void initial_lthread(void *args);
> -static void initial_lthread(void *args __attribute__((unused)))
> +static void *initial_lthread(void *args);

This declaration can be removed.

> +static void *initial_lthread(void *args __attribute__((unused)))
>  {

The function must return a pointer (like NULL) at the end.

Please check that all threads are returning something.