From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E053D42D09; Tue, 20 Jun 2023 16:33:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B76494068E; Tue, 20 Jun 2023 16:33:20 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C359F400D6 for ; Tue, 20 Jun 2023 16:33:19 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 59A545C02C1; Tue, 20 Jun 2023 10:33:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 20 Jun 2023 10:33:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687271599; x=1687357999; bh=x1SPh31QmbLB665HYUN7K6N2DX5G3+zmm6Y efgNEk64=; b=wm3HimCLjd/9DQslG+qVP1BcYSmUi4WLD8eI+O7/JsVqR4xG8ln QFei2t8j8ZJpLeL9gDbzEvaV8+YEpkj6QHxU8McpWD/MdwqRBKOTQrzUHeKtfyV8 q9gHdKfFKBg9kEBbmchWwXuITjau5OmQLAU79lVC7wJJUFLmZg2RjkgbUaDIHbGe /w3GSdMIyECGGbzH/x2zzMNPycyN1SEyh65EQnvormIqUjbjANP1Pgz8xaRs3KHe DUQ06zT+wJl8Kze9l+Yqt1wu4l+dI4aTS6mQ6o3LexbnYxCN+hRhWGW/TJFmW7yQ QZDQdaV8w6KsUXsBu/W1w51zJL3kcbD0cmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687271599; x=1687357999; bh=x1SPh31QmbLB665HYUN7K6N2DX5G3+zmm6Y efgNEk64=; b=TR2mAVmkHmb+IIo/e8iZAT/oASZDpq8OHHxkGOaX6WFkuSFNuUx TqaI162yc24eWRf6fms3FxHR9m2NV70MUFYFiG7dpc0bK0RNlmLOSRoQAd/4Eyxb 9WhQuFfZBclL4vIn9DGY28QpmkOz8ddjH4qDLB3CRm8JJUrQOify3cB0h2LggKkU l/ZoKbTpiup+aoRtLditqjBSaZviBrqYIW1qqHwHCNqOkDodzYyY2bNhS7qavEUz Hx2ufr8J72JoOrF5eua1xM/rmWENqBWbJ8Oib3ZYceUwle6dejVaT/rXeElZ7kyq 6WLg0s/aMAElSwxhIX2KANXBnQVr/NxAZPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefhedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Jun 2023 10:33:17 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Bruce Richardson Cc: dev@dpdk.org, bluca@debian.org, tredaelli@redhat.com, i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr, Aaron Conole , Michael Santana Subject: Re: [PATCH v3] build: select optional libraries Date: Tue, 20 Jun 2023 16:33:15 +0200 Message-ID: <23115010.6Emhk5qWAg@thomas> In-Reply-To: References: <20211117112847.7362-6-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 20/06/2023 11:03, Bruce Richardson: > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand wrote: > > On Tue, Jun 20, 2023 at 10:45=E2=80=AFAM Bruce Richardson > > wrote: > > > > > > > I notice the change in behaviour for enabling the deprecated = libs. Is there > > > > > > > any other change in behaviour for current users? > > > > > > > > > > > > The only change I see, is that this implementation breaks enabl= ing > > > > > > deprecated libs via disable_libs. > > > > > > It may break existing developer build directory and maybe some > > > > > > packaging scripts, this is why I am a bit puzzled. > > > > > > > > > > > > Relooking at the disable_libs option current implementation, it= seems > > > > > > backward to pass a disable_libs option when you want to build s= ome > > > > > > deprecated library. > > > > > > It is more straightforward to request building libraries via > > > > > > -Denable_libs=3D explicitly or -Denable_libs=3D* > > > > > > implicitly. > > > > > > > > > > > > But again, we may be breaking something for people who relied o= n this behavior. > > > > > > > > > > > > > > > > That's what I expected, and I think that is ok. I just wanted to = check that > > > > > the change in behaviour was only for the deprecated libs case. > > > > > > > > Thomas, wdyt? > > > > It requires some release note, at least. > > > > > > > I am assuming this is not targetting this release though, right? Assu= ming > > > 23.11, we can put in a deprecation note informing of the change ahead= of > > > time too. > >=20 > > I was hoping to get it in this release. > > But I am fine with postponing and announcing the change beforehand. > >=20 > Given the fact that we are likely changing behaviour, and the fact that t= he > deprecated libs makes it more complicated than the drivers one (since we > have always on, default on and default off cases to consider), I think it= 's > best we don't rush this. I'm not sure what is the best behaviour. I tend to think such options should be simple to understand with only 3 cases: =2D no option -> default =2D enable option -> only core mandatory and listed libraries =2D disable option -> all but the listed libraries It looks simpler to forbid having both enable and disable libraries. Would you be open to change the behaviour of the drivers options?