From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 5B8912A9 for ; Mon, 3 Nov 2014 08:49:25 +0100 (CET) Received: by mail-wg0-f52.google.com with SMTP id b13so9814603wgh.39 for ; Sun, 02 Nov 2014 23:58:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=CEIP4f0+eQaXjrTfNbbr4CXSQDojZdniIfWYmF4VUKY=; b=N0VuD7LTR/7E9RWZ5BN7IdvPlRItqqKUlGDh+U822g4jlCH9P/WPZue/6Z7ONhjccd GC0kVp4dTqRmgvR81O4ZHSwnVkzyEHcLiaL7+JxO5QrJcvDlHf4/NuKkF36YRUGq6aih +LVa4u5/ljm119BekJnxChz3wXx2ChpZpbibhpbBzVKMVz4sXR4T7ym3fcMLr9JWIwRe 3ed3tNzKrf+q5oGKcS/RnnWulQcqTanwQpgOaegTSArsO0ifGvl+aBGelqGPxZU43qqr WojlpN78EeOi9uWE4REGd03XW9Tj5JADjPPv/NmZoWO/VpOzGCddHKw9tMzdbL2eObKh D8lg== X-Gm-Message-State: ALoCoQl03TKci0iraV/ELAUXxE7zLzZJCrj2TcyvwQY+4pJOz53WuBcdUjOIm0OhuSRL8zuvThLc X-Received: by 10.194.19.4 with SMTP id a4mr34394309wje.3.1415001518446; Sun, 02 Nov 2014 23:58:38 -0800 (PST) Received: from xps13.localnet (3.17.90.92.rev.sfr.net. [92.90.17.3]) by mx.google.com with ESMTPSA id bf6sm17452190wjb.13.2014.11.02.23.58.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Nov 2014 23:58:37 -0800 (PST) From: Thomas Monjalon To: Neil Horman , Matthew Hall Date: Mon, 03 Nov 2014 08:41:53 +0100 Message-ID: <2311642.9a52mKMPYp@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20141009112918.GA20940@hmsreliant.think-freely.org> References: <1412045348-18543-1-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8B04B34@SHSMSX104.ccr.corp.intel.com> <20141009112918.GA20940@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 07:49:25 -0000 2014-10-09 07:29, Neil Horman: > On Thu, Oct 09, 2014 at 05:20:31AM +0000, Wu, Jingjing wrote: > > Hi, Neil > > > > To have rte_ip.h include netinet/in.h directly is also a choice. > > > > But netinet/in.h contains a lot of extra stuff, and these may be useless some DPDK applications, such as classification. > > rte_ip.h provides a more simplify way for the IP protocol layer. > > > Not sure what the relevance there is. The definitions you want are > standardized, theres no need for the dpdk to re-invent that wheel. Get them > from the system include file. The fact that extra macros are available in > netinet.h is neither relevant or true (as you can't really say for certain what > an application will need). Neil, Matthew, I totally agree with your point of view. Please, could you propose a patch to fix this issue? Thanks -- Thomas