From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Move mk/rte.extvars.mk to mk/internal/rte.extvars.mk
Date: Mon, 09 Mar 2015 12:14:48 +0100 [thread overview]
Message-ID: <2311648.DunbajaNGl@xps13> (raw)
In-Reply-To: <2151096.y3SmQntZBq@xps13>
2015-03-07 21:38, Thomas Monjalon:
> 2015-03-06 09:46, Olivier MATZ:
> > Hi Keith,
> >
> > On 03/04/2015 06:13 PM, Keith Wiles wrote:
> > > Move the rte.extvars.mk to an internal directory and
> > > update rte.vars.mk to find the file in the new location.
> > >
> > > Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> >
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> > (for after 2.0 I guess as it's not a fix)
>
> It's a good clean-up without risk. It should go in.
>
> > Note for Thomas: when you apply it, git complains there is a blank
> > line at the end of the file that is moved, I think you can strip it:
> >
> > dpdk/.git/rebase-apply/patch:94: new blank line at EOF.
> > +
>
> OK, thanks
Applied, thanks
prev parent reply other threads:[~2015-03-09 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 17:13 Keith Wiles
2015-03-06 8:46 ` Olivier MATZ
2015-03-07 20:38 ` Thomas Monjalon
2015-03-09 11:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2311648.DunbajaNGl@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).