From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id B1AA49AA4 for ; Mon, 9 Mar 2015 12:50:22 +0100 (CET) Received: by wghk14 with SMTP id k14so23614722wgh.3 for ; Mon, 09 Mar 2015 04:50:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9L9OdO63rgd8r9V8vHMrgoUboC8mEEEI3Th1gTfDhrU=; b=MP5GfAUpNIXfd086aqt7EMwiVTC3w/C+6TGL9JTE9XYJfHoNxUQhBdx6n9HRhqohJT z7HccMPlmNJmhxKGLY9Fh+PWNVEsDyKjWuphZMMs8vEkfkddGzCnHMMx40Y4f6wK4XDt LSQpwx0f/uLmWkhZ94NlaXAcoYXD+sa2z+MkaqZKnXEsa6qeWBiwijkbNXa0f1qRfD1g oYWLnDLRFyCspAXnTJQRg0MZYMeHfP8LqhIhD1Z4iuk3+RLauBC0icWdWBOXlLeBqF3w 8SXOsN9kLVcsbAuXo9HHEggF4XhGKydqhPJZZaiHU0pZHYW6x/KtejZMd6uA3tekua9o gkGA== X-Gm-Message-State: ALoCoQmbDPEEKHhraWW8YrRUtenwa3NJDmBQZIwJh83qXinOs8mszBgKrZy9dSvEPazBr1PSlrVC X-Received: by 10.180.104.66 with SMTP id gc2mr102191938wib.34.1425901822612; Mon, 09 Mar 2015 04:50:22 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id fo8sm15197134wib.14.2015.03.09.04.50.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 04:50:21 -0700 (PDT) From: Thomas Monjalon To: Keith Wiles Date: Mon, 09 Mar 2015 12:14:48 +0100 Message-ID: <2311648.DunbajaNGl@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <2151096.y3SmQntZBq@xps13> References: <1425489189-43477-1-git-send-email-keith.wiles@intel.com> <54F96951.2060406@6wind.com> <2151096.y3SmQntZBq@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Move mk/rte.extvars.mk to mk/internal/rte.extvars.mk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 11:50:22 -0000 2015-03-07 21:38, Thomas Monjalon: > 2015-03-06 09:46, Olivier MATZ: > > Hi Keith, > > > > On 03/04/2015 06:13 PM, Keith Wiles wrote: > > > Move the rte.extvars.mk to an internal directory and > > > update rte.vars.mk to find the file in the new location. > > > > > > Signed-off-by: Keith Wiles > > > > Acked-by: Olivier Matz > > (for after 2.0 I guess as it's not a fix) > > It's a good clean-up without risk. It should go in. > > > Note for Thomas: when you apply it, git complains there is a blank > > line at the end of the file that is moved, I think you can strip it: > > > > dpdk/.git/rebase-apply/patch:94: new blank line at EOF. > > + > > OK, thanks Applied, thanks