From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C00F22BF2 for ; Tue, 22 May 2018 21:53:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 12:53:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,430,1520924400"; d="scan'208,217";a="226411316" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 22 May 2018 12:53:31 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 22 May 2018 12:53:31 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.235]) by fmsmsx124.amr.corp.intel.com ([169.254.8.29]) with mapi id 14.03.0319.002; Tue, 22 May 2018 12:53:30 -0700 From: "Wiles, Keith" To: Alexandru Ciobotaru CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] Question about adding a new EAL Thread-Index: AQHT8gKlXsoBaN/AJ0CoCHHP4x2UHKQ8nm4A Date: Tue, 22 May 2018 19:53:30 +0000 Message-ID: <231457C6-BC47-42E3-8B3B-9B8AA121A580@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.53.246] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Question about adding a new EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 19:53:33 -0000 On May 22, 2018, at 2:23 PM, Alexandru Ciobotaru > wrote: Greetings, I can not answer all of your questions, but maybe a few. I'm currently checking on how to add new EAL "app" to the DPDK so I started by adding a new "xyzapp" next to "linuxapp" and "bsdapp". Now, I would probably expect to make this new EAL mainline compliant on day, and to avoid future headaches, the plan is to avoid modifying things outside of my "xyzapp". And thus, the first adaptation issue has arrived: EAL is designed so that I can re-implement the "common" source files into my "xyzapp" but how would I override the "include/rte_xyz.h" headers from the "common" part of the EAL library (e.g. librte_eal/common/include/rte_eal.h)? Some of the includes in these headers are currently N/A to my toolchain (via CROSS=3D) or to my executive environment. Normally, these types of differences are just empty variables or something = that allows the system build even when you do not support it. For example I do not have or which are currently included in some EAL API headers. Maybe you should make simple empty headers, to work around those headers. I= am sure it would be easier, but maybe someone has a better idea. Should more work into making the "common" part truly generic be put into this? We always like to see patches to make the EAL simpler to maintain, so pleas= e introduce a patch. Is the current EAL API frozen for compatibility reasons? Any "next" branch where such modifications are accepted? Changing a EAL API is really discouraged as it effect a lot of places. But = we do have a method to change exposed APIs. It will take two releases to ge= t your change into DPDK the first release gives notice and the second one a= llows the API to exist in the code. You can read more abort the process her= e: http://dpdk.org/dev make sure you read it all :-) Or, is there a straight method of enforcing my "xyzapp" symlinked EAL headers in the build directory without modifying the "common" Makefile? You should avoid symlinks in the main repo directories as they are difficul= t to maintain and some systems do not support them. Thank you, Alex Let us know if you need anything else. Regards, Keith